Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-05 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/#review219817 --- Ship it! Ship It! - Madhan Neethiraj On March 6, 2020, 6:26

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-05 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/ --- (Updated March 6, 2020, 6:26 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-05 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/#review219807 --- repository/src/main/java/org/apache/atlas/discovery/Classificatio

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-05 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/ --- (Updated March 6, 2020, 5:37 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-05 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/ --- (Updated March 5, 2020, 11:35 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-04 Thread Pinal Shah
> On March 4, 2020, 7:29 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > > Lines 286 (patched) > > > > > > typeNamePredicate can be null here

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-04 Thread Pinal Shah
> On March 4, 2020, 7:29 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > > Lines 169 (patched) > > > > > > Wouldn't this overwrite earlier assignment

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-03 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/#review219751 --- repository/src/main/java/org/apache/atlas/discovery/Classificatio

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-03 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/#review219750 --- repository/src/main/java/org/apache/atlas/discovery/EntitySearchP

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-02-24 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/ --- (Updated Feb. 25, 2020, 7:11 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-02-21 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/#review219628 --- repository/src/main/java/org/apache/atlas/discovery/EntitySearchP

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-02-21 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/ --- (Updated Feb. 21, 2020, 12:23 p.m.) Review request for atlas, Madhan Neethiraj,

Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-02-21 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/ --- Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subraman