Re: Review Request 72300: ATLAS-3696 : [Business Metadata] No option to check/uncheck Business Metadata field in search results

2020-04-07 Thread Pinal Shah
> On April 7, 2020, 3:19 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > > Lines 697 (patched) > > > > > > Use MapUtils.isNotEmpty.

Re: Review Request 72300: ATLAS-3696 : [Business Metadata] No option to check/uncheck Business Metadata field in search results

2020-04-07 Thread Pinal Shah
> On April 7, 2020, 4:06 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > > Lines 66 (patched) > > > > > > - I suggest to remove businessMetadataNames, as

Re: Review Request 72300: ATLAS-3696 : [Business Metadata] No option to check/uncheck Business Metadata field in search results

2020-04-07 Thread Pinal Shah
> On April 7, 2020, 4:06 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > > Lines 696 (patched) > > > > > > This returns all available

Re: Review Request 72300: ATLAS-3696 : [Business Metadata] No option to check/uncheck Business Metadata field in search results

2020-04-07 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72300/#review220241 ---

Re: Review Request 72300: ATLAS-3696 : [Business Metadata] No option to check/uncheck Business Metadata field in search results

2020-04-07 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72300/#review220240 ---

Review Request 72300: ATLAS-3696 : [Business Metadata] No option to check/uncheck Business Metadata field in search results

2020-04-01 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72300/ --- Review request for atlas, keval bhatt, Madhan Neethiraj, Mandar Ambawane, Nixon