Re: Review Request 49625: ATLAS-347 Atlas search APIs should allow pagination of results

> On July 12, 2016, 5:45 p.m., Neeru Gupta wrote: > > common/src/main/java/org/apache/atlas/AtlasProperties.java, line 44 > > > > > > It should be atlas.search.defaultlimit? > > > > This is persumably configu

Re: Review Request 49625: ATLAS-347 Atlas search APIs should allow pagination of results

> On July 14, 2016, 12:06 a.m., Hemanth Yamijala wrote: > > repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java, > > line 87 > > > > > > Just for my understanding, are these quo

Re: Review Request 49625: ATLAS-347 Atlas search APIs should allow pagination of results

> On July 14, 2016, 5:21 a.m., Hemanth Yamijala wrote: > > repository/src/main/scala/org/apache/atlas/query/Expressions.scala, line 789 > > > > > > This may just be debug, but the literal "order" should be "orderby"?

Re: Review Request 49625: ATLAS-347 Atlas search APIs should allow pagination of results

> On July 12, 2016, 6:07 p.m., Neeru Gupta wrote: > > common/src/main/java/org/apache/atlas/AtlasProperties.java, line 43 > > > > > > You might consider bumping up these default values. Otherwise it will > > break ex

Build failed in Jenkins: apache-atlas-nightly #371

See Changes: [sshivalingamurthy] ATLAS-957 Atlas is not capturing topologies that have $ in the data -- [...truncated 6006 lines...] [INFO] --- maven-source-plugin:2.4:test-jar-no-fork (atta

Re: Review Request 49625: ATLAS-347 Atlas search APIs should allow pagination of results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49625/ --- (Updated July 19, 2016, 4:45 p.m.) Review request for atlas. Changes ---

[jira] [Updated] (ATLAS-347) Atlas search APIs should allow pagination of results

[ https://issues.apache.org/jira/browse/ATLAS-347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shwetha G S updated ATLAS-347: -- Attachment: ATLAS-347-v3.patch > Atlas search APIs should allow pagination of results > -

Re: Review Request 49625: ATLAS-347 Atlas search APIs should allow pagination of results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49625/#review142770 --- addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/Hiv

Re: Review Request 49625: ATLAS-347 Atlas search APIs should allow pagination of results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49625/#review142775 --- client/src/main/java/org/apache/atlas/AtlasClient.java (line 1019

Re: Review Request 49625: ATLAS-347 Atlas search APIs should allow pagination of results

> On July 19, 2016, 5:50 p.m., Suma Shivaprasad wrote: > > client/src/main/java/org/apache/atlas/AtlasClient.java, line 1020 > > > > > > Should we expose 2 APIs - one without offset and limit? and which has a defau

[jira] [Updated] (ATLAS-639) Exception for lineage request

[ https://issues.apache.org/jira/browse/ATLAS-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vimal Sharma updated ATLAS-639: --- Attachment: ATLAS-639.patch Added condition in Gremlin query to return in case of cycle in Titan graph.

[jira] [Issue Comment Deleted] (ATLAS-639) Exception for lineage request

[ https://issues.apache.org/jira/browse/ATLAS-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vimal Sharma updated ATLAS-639: --- Comment: was deleted (was: I tried to reproduce this issue. However, I am getting the below exception.

Re: Review Request 49625: ATLAS-347 Atlas search APIs should allow pagination of results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49625/#review142827 --- repository/src/main/scala/org/apache/atlas/query/QueryParser.scal

[jira] [Commented] (ATLAS-1022) Update typesystem wiki with details

[ https://issues.apache.org/jira/browse/ATLAS-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384824#comment-15384824 ] Suma Shivaprasad commented on ATLAS-1022: - +1 > Update typesystem wiki with detai

[jira] [Updated] (ATLAS-639) Exception for lineage request

[ https://issues.apache.org/jira/browse/ATLAS-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suma Shivaprasad updated ATLAS-639: --- Attachment: ATLAS-639.1.patch Fixed failing tests > Exception for lineage request > --

[jira] [Commented] (ATLAS-639) Exception for lineage request

[ https://issues.apache.org/jira/browse/ATLAS-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385023#comment-15385023 ] Suma Shivaprasad commented on ATLAS-639: Also added enablePath() for loop gremlin Q

[jira] [Created] (ATLAS-1033) Fix issues flagged by Coverity scan - like potential NPE, unused code/variable

Madhan Neethiraj created ATLAS-1033: --- Summary: Fix issues flagged by Coverity scan - like potential NPE, unused code/variable Key: ATLAS-1033 URL: https://issues.apache.org/jira/browse/ATLAS-1033 Pr

[jira] [Updated] (ATLAS-1033) Fix issues flagged by Coverity scan - like potential NPE, unused code/variable

[ https://issues.apache.org/jira/browse/ATLAS-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1033: Attachment: ATLAS-1033.patch > Fix issues flagged by Coverity scan - like potential NPE, unu

Review Request 50209: ATLAS-1033: fix for issues flagged by Coverity scan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50209/ --- Review request for atlas. Bugs: ATLAS-1033 https://issues.apache.org/jira/b

Build failed in Jenkins: apache-atlas-nightly #372

See Changes: [sumasai.shivaprasad] ATLAS-1021 Update Atlas architecture wiki(yhemanth via sumasai) -- [...truncated 6097 lines...] [WARNING] Keystore file '

Re: Review Request 50209: ATLAS-1033: fix for issues flagged by Coverity scan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50209/#review142882 --- client/src/main/java/org/apache/atlas/AtlasClient.java (line 1159

Re: Review Request 50209: ATLAS-1033: fix for issues flagged by Coverity scan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50209/#review142884 --- webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthentic

Re: Review Request 50209: ATLAS-1033: fix for issues flagged by Coverity scan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50209/#review142885 --- webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthentic

[jira] [Commented] (ATLAS-639) Exception for lineage request

[ https://issues.apache.org/jira/browse/ATLAS-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385269#comment-15385269 ] Shwetha G S commented on ATLAS-639: --- +1 > Exception for lineage request > --

Re: Review Request 49625: ATLAS-347 Atlas search APIs should allow pagination of results

> On July 19, 2016, 5:34 p.m., Suma Shivaprasad wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java, > > line 221 > > > > > > constants for default limit and offset? Us

Re: Review Request 49625: ATLAS-347 Atlas search APIs should allow pagination of results

> On July 19, 2016, 5:50 p.m., Suma Shivaprasad wrote: > > client/src/main/java/org/apache/atlas/AtlasClient.java, line 1020 > > > > > > Should we expose 2 APIs - one without offset and limit? > > Suma Shivaprasad

Re: Review Request 49625: ATLAS-347 Atlas search APIs should allow pagination of results

> On July 19, 2016, 8:33 p.m., Suma Shivaprasad wrote: > > repository/src/main/scala/org/apache/atlas/query/QueryParser.scala, line 172 > > > > > > This change now means that if there are multiple queries, then selec

Re: Review Request 50209: ATLAS-1033: fix for issues flagged by Coverity scan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50209/#review142902 --- client/src/main/java/org/apache/atlas/AtlasClient.java (line 1159

Re: Review Request 49625: ATLAS-347 Atlas search APIs should allow pagination of results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49625/#review142905 --- Ship it! Ship It! - Suma Shivaprasad On July 19, 2016, 4:45

[jira] [Updated] (ATLAS-347) Atlas search APIs should allow pagination of results

[ https://issues.apache.org/jira/browse/ATLAS-347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shwetha G S updated ATLAS-347: -- Attachment: ATLAS-347-v4.patch Final patch removing the prefix for entity text property > Atlas search A

[jira] [Commented] (ATLAS-1032) Atlas hook package should not include libraries already present in host component - like log4j

[ https://issues.apache.org/jira/browse/ATLAS-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385430#comment-15385430 ] Shwetha G S commented on ATLAS-1032: The same should be done for other plugins as well