Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-11 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52533/#review152199 --- Ship it! Ship It! - Suma Shivaprasad On Oct. 11, 2016, 6:40

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-11 Thread Sarath Kumar Subramanian
> On Oct. 6, 2016, 10:38 p.m., Shwetha GS wrote: > > src/main/patches/001-hive_column_add_position.json, line 2 > > > > > > sorry, i missed this earlier, can you move the patch to hive-bridge > > module? moved to hiv

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-11 Thread Sarath Kumar Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52533/ --- (Updated Oct. 11, 2016, 11:40 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-06 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52533/#review151760 --- src/main/patches/001-hive_column_add_position.json (line 2)

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-06 Thread Sarath Kumar Subramanian
> On Oct. 5, 2016, 11:51 p.m., Shwetha GS wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java, > > line 232 > > > > > > This is a minor backward compatible change. We

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-06 Thread Sarath Kumar Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52533/ --- (Updated Oct. 6, 2016, 10:29 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-05 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52533/#review151632 --- addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/Hive

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-05 Thread Vimal Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52533/#review151631 --- Ship it! Ship It! - Vimal Sharma On Oct. 4, 2016, 11:17 p.m.

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-05 Thread Sarath Kumar Subramanian
> On Oct. 4, 2016, 10:56 p.m., Vimal Sharma wrote: > > repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java, > > line 68 > > > > > > what is the need for this check? We are iterating over mo

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-04 Thread Vimal Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52533/#review151459 --- repository/src/main/java/org/apache/atlas/services/ReservedTypesR

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-04 Thread Sarath Kumar Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52533/ --- (Updated Oct. 4, 2016, 4:17 p.m.) Review request for atlas, Madhan Neethiraj, S