Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

> On May 3, 2016, 4:42 a.m., Shwetha GS wrote: > > Build failed with checkstyle errors: > > [INFO] --- maven-checkstyle-plugin:2.9.1:check (checkstyle-check) @ > > atlas-notification --- > > [INFO] Starting audit... > >

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

> On May 3, 2016, 4:42 a.m., Shwetha GS wrote: > > Build failed with checkstyle errors: > > [INFO] --- maven-checkstyle-plugin:2.9.1:check (checkstyle-check) @ > > atlas-notification --- > > [INFO] Starting audit... > >

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

> On May 3, 2016, 4:42 a.m., Shwetha GS wrote: > > Build failed with checkstyle errors: > > [INFO] --- maven-checkstyle-plugin:2.9.1:check (checkstyle-check) @ > > atlas-notification --- > > [INFO] Starting audit... > >

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/ --- (Updated May 3, 2016, 1:21 p.m.) Review request for atlas. Changes ---

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

> On May 3, 2016, 4:42 a.m., Shwetha GS wrote: > > Build failed with checkstyle errors: > > [INFO] --- maven-checkstyle-plugin:2.9.1:check (checkstyle-check) @ > > atlas-notification --- > > [INFO] Starting audit... > >

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

> On May 3, 2016, 4:42 a.m., Shwetha GS wrote: > > Build failed with checkstyle errors: > > [INFO] --- maven-checkstyle-plugin:2.9.1:check (checkstyle-check) @ > > atlas-notification --- > > [INFO] Starting audit... > >

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

> On May 3, 2016, 4:42 a.m., Shwetha GS wrote: > > Build failed with checkstyle errors: > > [INFO] --- maven-checkstyle-plugin:2.9.1:check (checkstyle-check) @ > > atlas-notification --- > > [INFO] Starting audit... > >

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/ --- (Updated May 3, 2016, 10:51 a.m.) Review request for atlas. Changes ---

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/#review131452 --- Build failed with checkstyle errors: [INFO] ---

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

> On April 25, 2016, 6:10 p.m., Shwetha GS wrote: > > notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java, > > line 91 > > > > > > Lets take the case of one of the notification

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

> On April 25, 2016, 6:10 p.m., Shwetha GS wrote: > > notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java, > > line 91 > > > > > > Lets take the case of one of the notification

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/ --- (Updated April 26, 2016, 2:26 p.m.) Review request for atlas. Changes

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/#review130472 ---

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/ --- (Updated April 25, 2016, 3:44 p.m.) Review request for atlas. Changes

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

> On April 25, 2016, 7:10 a.m., Shwetha GS wrote: > > Thanks for the review! - Tom --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/#review130345

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/#review130345 --- distro/src/conf/atlas-log4j.xml (line 57)

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/#review130026 --- Ship it! Took a look at the rebased patch. Also built Atlas

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

> On April 8, 2016, 12:24 a.m., Hemanth Yamijala wrote: > > notification/src/main/java/org/apache/atlas/notification/MessageVersion.java, > > line 89 > > > > > > Unfortunately, the hashCode will not be consistent

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/ --- (Updated April 8, 2016, 2:53 p.m.) Review request for atlas. Bugs: ATLAS-631

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/#review127760 --- Other than the hashCode / equals fix, other things are fine for

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/#review127704 ---

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

> On April 6, 2016, 2:05 p.m., Hemanth Yamijala wrote: > > notification/src/main/java/org/apache/atlas/notification/MessageVersion.java, > > line 84 > > > > > > May not be a case that actually happens, but would we

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/ --- (Updated April 7, 2016, 8:46 p.m.) Review request for atlas. Changes ---

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

> On April 6, 2016, 2:05 p.m., Hemanth Yamijala wrote: > > notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java, > > line 34 > > > > > > I see we have two different types, one

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/ --- (Updated April 6, 2016, 6:17 p.m.) Review request for atlas. Changes ---

Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/#review127308 --- distro/src/conf/atlas-log4j.xml (line 48)