Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-05-12 Thread Shwetha GS
> On April 19, 2016, 11 a.m., Shwetha GS wrote: > > typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java, > > line 99 > > > > > > Can we maintain this as Set and check on just typeName? > >

Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-04-29 Thread David Kantor
> On April 19, 2016, 11 a.m., Shwetha GS wrote: > > typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java, > > line 99 > > > > > > Can we maintain this as Set and check on just typeName? > >

Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-04-29 Thread David Kantor
> On April 22, 2016, 6:41 a.m., Shwetha GS wrote: > > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java, > > line 728 > > > > > > Why is this removed? I removed it because it was

Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-04-29 Thread David Kantor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45948/ --- (Updated April 29, 2016, 7:24 p.m.) Review request for atlas. Changes

Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-04-22 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45948/#review130045 ---

Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-04-22 Thread Shwetha GS
> On April 19, 2016, 11 a.m., Shwetha GS wrote: > > typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java, > > line 99 > > > > > > Can we maintain this as Set and check on just typeName? > >

Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-04-19 Thread David Kantor
> On April 19, 2016, 11 a.m., Shwetha GS wrote: > > typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java, > > line 99 > > > > > > Can we maintain this as Set and check on just typeName? I

Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-04-19 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45948/#review129505 ---

Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-04-18 Thread David Kantor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45948/ --- (Updated April 18, 2016, 5:13 p.m.) Review request for atlas. Changes

Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-04-15 Thread David Kantor
> On April 13, 2016, 12:21 a.m., Hemanth Yamijala wrote: > > typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java, > > line 51 > > > > > > This may not be a valid case - maybe Shwetha would

Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-04-15 Thread David Kantor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45948/ --- (Updated April 15, 2016, 6:36 p.m.) Review request for atlas. Changes

Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-04-12 Thread Hemanth Yamijala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45948/#review128589 ---

Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-04-12 Thread David Kantor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45948/ --- (Updated April 12, 2016, 1:41 p.m.) Review request for atlas. Bugs: