Re: Review Request 46444: ATLAS-659: Fix issues with using embedded HBase on Windows

2016-05-05 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46444/#review131809 --- Ship it! Ship It! - Shwetha GS On May 4, 2016, 4:04 p.m.,

Re: Review Request 46444: ATLAS-659: Fix issues with using embedded HBase on Windows

2016-05-04 Thread David Kantor
> On May 4, 2016, 7:01 a.m., Shwetha GS wrote: > > distro/src/conf/hbase/windows-hbase-site.xml.template, line 22 > > > > > > Can you use system property and avoid using different config files for > > windows and

Re: Review Request 46444: ATLAS-659: Fix issues with using embedded HBase on Windows

2016-05-04 Thread David Kantor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46444/ --- (Updated May 4, 2016, 4:04 p.m.) Review request for atlas. Changes ---

Re: Review Request 46444: ATLAS-659: Fix issues with using embedded HBase on Windows

2016-05-04 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46444/#review131634 --- distro/src/conf/hbase/windows-hbase-site.xml.template (line 22)

Re: Review Request 46444: ATLAS-659: Fix issues with using embedded HBase on Windows

2016-04-29 Thread David Kantor
> On April 21, 2016, 7:24 p.m., Neeru Gupta wrote: > > distro/src/bin/atlas_config.py, line 360 > > > > > > It looks like this method either starts the hbase or stops it. Should > > this be renamed to

Re: Review Request 46444: ATLAS-659: Fix issues with using embedded HBase on Windows

2016-04-29 Thread David Kantor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46444/ --- (Updated April 30, 2016, 12:04 a.m.) Review request for atlas. Changes