Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46731/#review134619 --- Ship it! Ship It! - Suma Shivaprasad On May 24, 2016, 7:34

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

> On May 23, 2016, 5:02 a.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java, > > line 318 > > > > > > why is the check for isComposite removed? Can you

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46731/ --- (Updated May 24, 2016, 7:34 a.m.) Review request for atlas. Changes ---

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

> On May 23, 2016, 5:02 a.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java, > > line 318 > > > > > > why is the check for isComposite removed? Can you

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

> On May 23, 2016, 4:57 a.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java, > > line 429 > > > > > > if this needs to be fixed, pls raise a jira

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46731/#review134307 ---

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46731/#review134305 ---

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46731/#review134304 ---

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

> On May 9, 2016, 9:41 p.m., Suma Shivaprasad wrote: > > repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java, > > line 40 > > > > > > why is this removed? Not in the new patch - Shwetha

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

> On May 5, 2016, 10:09 p.m., Suma Shivaprasad wrote: > > client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java, > > line 95 > > > > > > traits null check is missing . Could lead to NPE ?

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

> On May 5, 2016, 9:56 p.m., Suma Shivaprasad wrote: > > client/src/main/java/org/apache/atlas/AtlasClient.java, line 579 > > > > > > would be better to keep the result consistent for all CRUD operations > > and

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

> On May 5, 2016, 10:05 p.m., Suma Shivaprasad wrote: > > client/src/main/java/org/apache/atlas/EntityAuditEvent.java, line 66 > > > > > > why do we need String comparision here and not direct quals which > > would

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

> On May 5, 2016, 10:02 p.m., Suma Shivaprasad wrote: > > client/src/main/java/org/apache/atlas/AtlasClient.java, line 602 > > > > > > This will cause some users an UI to break rt?. would be better to send > > a

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46731/ --- (Updated May 19, 2016, 5:41 a.m.) Review request for atlas. Changes ---

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

> On May 5, 2016, 10:05 p.m., Suma Shivaprasad wrote: > > client/src/main/java/org/apache/atlas/EntityAuditEvent.java, line 66 > > > > > > why do we need String comparision here and not direct quals which > > would

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

> On May 5, 2016, 9:56 p.m., Suma Shivaprasad wrote: > > client/src/main/java/org/apache/atlas/AtlasClient.java, line 579 > > > > > > would be better to keep the result consistent for all CRUD operations > > and

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46731/#review131957 ---

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46731/#review131955 --- client/src/main/java/org/apache/atlas/AtlasClient.java (line

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46731/#review131952 --- client/src/main/java/org/apache/atlas/AtlasClient.java (line

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46731/ --- (Updated April 27, 2016, 1:05 p.m.) Review request for atlas. Changes

Review Request 46731: ATLAS-716 Entity update/delete notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46731/ --- Review request for atlas. Bugs: ATLAS-716