Re: Review Request 51800: Support getTrait() API

2016-09-18 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51800/#review149429 --- Fix it, then Ship it! webapp/src/main/java/org/apache/atlas/we

Re: Review Request 51800: Support getTrait() API

2016-09-16 Thread Vimal Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51800/ --- (Updated Sept. 16, 2016, 8:49 a.m.) Review request for atlas. Repository: atl

Re: Review Request 51800: Support getTrait() API

2016-09-15 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51800/#review149034 --- client/src/main/java/org/apache/atlas/AtlasClient.java (line 1000

Re: Review Request 51800: Support getTrait() API

2016-09-14 Thread Vimal Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51800/ --- (Updated Sept. 15, 2016, 6:53 a.m.) Review request for atlas. Repository: atl

Re: Review Request 51800: Support getTrait() API

2016-09-14 Thread Vimal Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51800/ --- (Updated Sept. 15, 2016, 6:52 a.m.) Review request for atlas. Repository: atl

Re: Review Request 51800: Support getTrait() API

2016-09-14 Thread Vimal Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51800/ --- (Updated Sept. 14, 2016, 8:16 a.m.) Review request for atlas. Repository: atl

Re: Review Request 51800: Support getTrait() API

2016-09-13 Thread Vimal Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51800/ --- (Updated Sept. 13, 2016, 11:12 a.m.) Review request for atlas. Repository: at

Re: Review Request 51800: Support getTrait() API

2016-09-13 Thread Vimal Sharma
> On Sept. 12, 2016, 2:07 p.m., David Radley wrote: > > I am was thinking that a more intuitive API would be to follow the pattern > > used in the REST API for entities. So for entities with have > > .../entities/{entityguid}. So for consistancy we could have > > .../entities/{entityguid}/trait

Re: Review Request 51800: Support getTrait() API

2016-09-12 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51800/#review148487 --- I am was thinking that a more intuitive API would be to follow the

Review Request 51800: Support getTrait() API

2016-09-12 Thread Vimal Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51800/ --- Review request for atlas. Repository: atlas Description --- Given entity