Re: Auto closing stale PRs label

Glad to see it is working. The requests currently marked stale can be found with https://github.com/apache/beam/labels/stale On Tue, Jun 26, 2018 at 9:34 PM Rafael Fernandez wrote: > Neat! Thanks for showing me where the options are. > > On Tue, Jun 26, 2018 at 7:24 PM Kenneth Knowles wrote: >

Re: [DISCUSS] Automation for Java code formatting

++1 On Wed, Jun 27, 2018 at 7:36 AM, Ahmet Altay wrote: > +1 > > This is great idea. Does anyone know a similar tool for python? I believe > go already has this as part of its tools with go fmt. > > > On Tue, Jun 26, 2018 at 9:55 PM, Ankur Goenka wrote: > >> +1 >> >> Intellij can help but stil

Re: [DISCUSS] Automation for Java code formatting

+1 This is great idea. Does anyone know a similar tool for python? I believe go already has this as part of its tools with go fmt. On Tue, Jun 26, 2018 at 9:55 PM, Ankur Goenka wrote: > +1 > > Intellij can help but still formatting is an additional thing to keep in > mind. Enabling auto format

Re: [DISCUSS] Automation for Java code formatting

+1 Intellij can help but still formatting is an additional thing to keep in mind. Enabling auto formatting at gradle level will remove this additional thing to keep in mind. On Tue, Jun 26, 2018 at 9:49 PM Eugene Kirpichov wrote: > +1! > > In some cases the temptation to format code manually ca

Re: [DISCUSS] Automation for Java code formatting

+1! In some cases the temptation to format code manually can be quite strong, but the ease of just re-running the formatter after any change (especially after global changes like class/method renames) overweighs it. I lost count of the times when I wasted a precommit because some line became >100

Re: [DISCUSS] Automation for Java code formatting

+1! Remove guesswork :D On Tue, Jun 26, 2018 at 9:15 PM Kenneth Knowles wrote: > Hi all, > > I like readable code, but I don't like formatting it myself. And I > _really_ don't like discussing in code review. "Spotless" [1] can enforce - > and automatically apply - automatic formatting for Jav

Re: Auto closing stale PRs label

Neat! Thanks for showing me where the options are. On Tue, Jun 26, 2018 at 7:24 PM Kenneth Knowles wrote: > That's actually already how it works. We can configure how long it waits > after the message. Currently it is set for 60 day to stale and then 7 days > to close. You can see the options we

[DISCUSS] Automation for Java code formatting

Hi all, I like readable code, but I don't like formatting it myself. And I _really_ don't like discussing in code review. "Spotless" [1] can enforce - and automatically apply - automatic formatting for Java, Groovy, and some others. This is not about style or wanting a particular layout. This is

Re: [Design Proposal] Improving Beam code review

Does Kubernetes keep up with their backlog? We were hovering around 100 before our recent addition of committers & stalebot, and now around 80. I can imagine their 1000 open PRs might be an OK steady state; they have some 6 month and 2 month PRs but the overall distribution might be sort of like ou

Re: Auto closing stale PRs label

That's actually already how it works. We can configure how long it waits after the message. Currently it is set for 60 day to stale and then 7 days to close. You can see the options we've set up here; there may be more: https://github.com/apache/beam/blob/master/.github/stale.yml Kenn On Tue, Jun

Re: Auto closing stale PRs label

The new label makes sense to me, but Ismael: I want to make sure your concern is fully addressed. I see your point about making sure we are not shutting the door on a small fix that perhaps went unatended for benign reasons. Perhaps a step before closure is feasble? something like getting a nice me

Re: [Design Proposal] Improving Beam code review

I did a quick pass on the doc and left minor comments, thanks! I have some feedback and thoughts: - For metrics and tools, there ought to be mature OSS projects out there we can learn from. I believe Kubernetes has a very healthy practice, it'd be ideal to learn from them. +Griselda Cueva

Re: [Design Proposal] Improving Beam code review

Reuven, that's great. In this thread, we can continue discussing the usage of review tools, dashboards, and metrics. On Tue, Jun 26, 2018 at 5:27 PM Reuven Lax wrote: > So I suggested a while ago that we create a code-review guidelines doc, > and in fact I was coincidentally just now drafting up

Re: [Design Proposal] Improving Beam code review

So I suggested a while ago that we create a code-review guidelines doc, and in fact I was coincidentally just now drafting up a proposal doc. I'll share my proposal doc with the dev list soon. On Tue, Jun 26, 2018 at 5:18 PM Huygaa Batsaikhan wrote: > Hi, I've been looking into ways to improve B

Re: [Design Proposal] Improving Beam code review

Gonna take a look. Thanks !! Regards JB Le 27 juin 2018 à 08:18, à 08:18, Huygaa Batsaikhan a écrit: >Hi, I've been looking into ways to improve Beam's code review process >based >on previous discussions on dev list and summits, and I would like to >propose improvement ideas. Please take a look

[Design Proposal] Improving Beam code review

Hi, I've been looking into ways to improve Beam's code review process based on previous discussions on dev list and summits, and I would like to propose improvement ideas. Please take a look at: https://s.apache.org/beam-code-review. Main proposals suggested in the doc are: 1. Create a code re

Re: FYI on Slack Channels

Great idea. Thanks ! Regards JB Le 27 juin 2018 à 06:51, à 06:51, Griselda Cuevas a écrit: >This is awesome, thanks Rafael! > > > > >On Tue, 26 Jun 2018 at 13:46, Scott Wegner wrote: > >> This is great, thanks Rafael! >> >> On Tue, Jun 26, 2018 at 6:45 AM Rafael Fernandez > >> wrote: >> >>> Ah!

Re: FYI on Slack Channels

This is awesome, thanks Rafael! On Tue, 26 Jun 2018 at 13:46, Scott Wegner wrote: > This is great, thanks Rafael! > > On Tue, Jun 26, 2018 at 6:45 AM Rafael Fernandez > wrote: > >> Ah! Didn't know -- thanks Romain! >> >> Done for all channels I could find. Also, here is a list of channels: >

Re: [RESULT][VOTE] Apache Beam, version 2.5.0, release candidate #2

Thanks ! Just landed in Beijing. I will do the announcement this morning (China time). Regards JB Le 27 juin 2018 à 05:24, à 05:24, Ahmet Altay a écrit: >Beam site pull request is merged. > >JB, please send release announcement whenever it is convenient for you. > >Thank you again! >Ahmet > >On

Re: Filtered Pre-commit triggering is BACK!

Awesome! This will save so much time running tests. On Tue, Jun 26, 2018 at 2:29 PM Yifan Zou wrote: > Thanks Scott! It's nice to have this feature. > > On Tue, Jun 26, 2018 at 2:24 PM Pablo Estrada wrote: > >> This is great. Reducing load on infrastructure should help Beam scale >> into a larg

Re: Filtered Pre-commit triggering is BACK!

Thanks Scott! It's nice to have this feature. On Tue, Jun 26, 2018 at 2:24 PM Pablo Estrada wrote: > This is great. Reducing load on infrastructure should help Beam scale into > a larger project : ) - Thanks Scott! > > On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner wrote: > >> By popular demand [

Re: [RESULT][VOTE] Apache Beam, version 2.5.0, release candidate #2

Beam site pull request is merged. JB, please send release announcement whenever it is convenient for you. Thank you again! Ahmet On Mon, Jun 25, 2018 at 10:39 PM, Ahmet Altay wrote: > Thank you JB! > > On Mon, Jun 25, 2018 at 10:34 PM, Jean-Baptiste Onofré > wrote: > >> Hi, >> >> all has been

Re: Filtered Pre-commit triggering is BACK!

This is great. Reducing load on infrastructure should help Beam scale into a larger project : ) - Thanks Scott! On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner wrote: > By popular demand [1], filtered pre-commit triggering is now re-enabled. > Now when submitting pull request, only pre-commit tests

Filtered Pre-commit triggering is BACK!

By popular demand [1], filtered pre-commit triggering is now re-enabled. Now when submitting pull request, only pre-commit tests for your affected files will run: if you change just the Go SDK, you'll no longer need to run Java pre-commits. Last time we introduced this change it regressed our abil

Jenkins build is back to normal : beam_SeedJob #2085

See

Build failed in Jenkins: beam_SeedJob #2084

See -- GitHub pull request #5757 of commit f5c23c58ed3ed3a6b42ff1d09a323992f1d057b5, no merge conflicts. Setting status of f5c23c58ed3ed3a6b42ff1d09a323992f1d057b5 to PENDING with url https

Re: Going on leave for a bit

Enjoy time off. --Mikhail Have feedback ? On Tue, Jun 26, 2018 at 11:24 AM Xinyu Liu wrote: > Congrats! Enjoy the time without sleep. > > Thanks, > Xinyu > > On Tue, Jun 26, 2018 at 10:12 AM, Griselda Cuevas wrote: > >> Enjoy the time off Kenn! >> >> >> On Tue, 26

Re: Going on leave for a bit

Congrats! Enjoy the time without sleep. Thanks, Xinyu On Tue, Jun 26, 2018 at 10:12 AM, Griselda Cuevas wrote: > Enjoy the time off Kenn! > > > On Tue, 26 Jun 2018 at 12:14, Kai Jiang wrote: > >> Congrats! Enjoy your family time. >> >> Best, >> Kai >> >> On Tue, Jun 26, 2018, 09:11 Alan Myrvol

Re: bad logger import?

This is definitely a typo. Feel free to send PRs to correct these on sight :) On Tue, Jun 26, 2018 at 8:51 AM Rafael Fernandez wrote: > Filed https://issues.apache.org/jira/browse/BEAM-4644 for this. I > assigned it to +Ankur Goenka because it's the first > name in history :p (please reroute wh

Re: FYI on Slack Channels

This is great, thanks Rafael! On Tue, Jun 26, 2018 at 6:45 AM Rafael Fernandez wrote: > Ah! Didn't know -- thanks Romain! > > Done for all channels I could find. Also, here is a list of channels: > > #beam > #beam-events-meetups > #beam-go > #beam-java > #beam-portability > #beam-python > #beam-

Re: Going on leave for a bit

Enjoy the time off Kenn! On Tue, 26 Jun 2018 at 12:14, Kai Jiang wrote: > Congrats! Enjoy your family time. > > Best, > Kai > > On Tue, Jun 26, 2018, 09:11 Alan Myrvold wrote: > >> Congrats, Kenn and have a great break. >> >> On Tue, Jun 26, 2018 at 9:10 AM Alexey Romanenko < >> aromanenko

Re: Going on leave for a bit

Congrats! Enjoy your family time. Best, Kai On Tue, Jun 26, 2018, 09:11 Alan Myrvold wrote: > Congrats, Kenn and have a great break. > > On Tue, Jun 26, 2018 at 9:10 AM Alexey Romanenko > wrote: > >> Best wishes to you and your family, Kenneth! >> >> Alexey >> >> On 26 Jun 2018, at 15:45, Rafa

Re: Going on leave for a bit

Congrats, Kenn and have a great break. On Tue, Jun 26, 2018 at 9:10 AM Alexey Romanenko wrote: > Best wishes to you and your family, Kenneth! > > Alexey > > On 26 Jun 2018, at 15:45, Rafael Fernandez wrote: > > Have a great time, Kenn! > > On Tue, Jun 26, 2018 at 5:49 AM Ismaël Mejía wrote: >

Re: Going on leave for a bit

Best wishes to you and your family, Kenneth! Alexey > On 26 Jun 2018, at 15:45, Rafael Fernandez wrote: > > Have a great time, Kenn! > > On Tue, Jun 26, 2018 at 5:49 AM Ismaël Mejía > wrote: > Enjoy your family time. > > Best wishes, > Ismael > > > On Tue, Jun 26,

Re: bad logger import?

Filed https://issues.apache.org/jira/browse/BEAM-4644 for this. I assigned it to +Ankur Goenka because it's the first name in history :p (please reroute where appropriate). Thanks! r On Tue, Jun 26, 2018 at 8:23 AM Lukasz Cwik wrote: > That is an internal class to the Flink runner. Runners are

Re: bad logger import?

That is an internal class to the Flink runner. Runners are allowed to choose whichever logging framework they want to use with the understanding that the SDK and shared libraries use SLF4J but most likely its a simple typo. On Tue, Jun 26, 2018 at 7:22 AM Kenneth Knowles wrote: > Seems like a le

Re: bad logger import?

Seems like a legit bug to me. Perhaps we can adjust checkstyle, or some other more semantic analysis, to forbid it. Kenn On Tue, Jun 26, 2018 at 6:48 AM Rafael Fernandez wrote: > +Lukasz Cwik , +Henning Rohde > > On Tue, Jun 26, 2018 at 1:25 AM Romain Manni-Bucau > wrote: > >> Hi guys, >> >>

Re: bad logger import?

+Lukasz Cwik , +Henning Rohde On Tue, Jun 26, 2018 at 1:25 AM Romain Manni-Bucau wrote: > Hi guys, > > answering a question on slack i realized flink > ExecutableStageDoFnOperator.java uses JUL instead of SLF4J, not sure it is > intended so thought I would mention it here. > > Side note: arche

Re: Going on leave for a bit

Have a great time, Kenn! On Tue, Jun 26, 2018 at 5:49 AM Ismaël Mejía wrote: > Enjoy your family time. > > Best wishes, > Ismael > > > On Tue, Jun 26, 2018 at 12:13 PM Pei HE wrote: > >> (A late) Congrats for the newborn! >> -- >> Pei >> >> On Tue, Jun 26, 2018 at 1:42 PM, Kenneth Knowles wrot

Re: FYI on Slack Channels

Ah! Didn't know -- thanks Romain! Done for all channels I could find. Also, here is a list of channels: #beam #beam-events-meetups #beam-go #beam-java #beam-portability #beam-python #beam-sql #beam-testing On Tue, Jun 26, 2018 at 1:18 AM Romain Manni-Bucau wrote: > +1 sounds very good > > sid

Re: Going on leave for a bit

Enjoy your family time. Best wishes, Ismael On Tue, Jun 26, 2018 at 12:13 PM Pei HE wrote: > (A late) Congrats for the newborn! > -- > Pei > > On Tue, Jun 26, 2018 at 1:42 PM, Kenneth Knowles wrote: > > Hi friends, > > > > I think I did not mention on dev@ at the time, but my child #2 arrived

Re: Going on leave for a bit

(A late) Congrats for the newborn! -- Pei On Tue, Jun 26, 2018 at 1:42 PM, Kenneth Knowles wrote: > Hi friends, > > I think I did not mention on dev@ at the time, but my child #2 arrived March > 14 (Pi day!) and I took some weeks off. Starting ~July 4 I will be taking a > more significant absence

bad logger import?

Hi guys, answering a question on slack i realized flink ExecutableStageDoFnOperator.java uses JUL instead of SLF4J, not sure it is intended so thought I would mention it here. Side note: archetype and some test code does as well but it is less an issue. Romain Manni-Bucau @rmannibucau

Re: FYI on Slack Channels

+1 sounds very good side note: any channel must invite @asfarchivebot, I did it for the ones before "etc" but if you add others please ensure it is done Romain Manni-Bucau @rmannibucau | Blog | Old Blog