Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Danny McCormick via dev
> I have encountered a failure in a Python pipeline running with Runner v1: > RuntimeError: Beam SDK base version 2.46.0 does not match Dataflow Python worker version 2.45.0. Please check Dataflow worker startup logs and make sure that correct version of Beam SDK is installed. > We should underst

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Danny McCormick via dev
Hey Reuven, could you provide some more context on the bug/why it is important? Does it meet the standard in https://beam.apache.org/contribute/release-guide/#7-triage-release-blocking-issues-in-github ? The release branch was cut last Wednesday, so that is why it is not included. On Fri, Mar 3,

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Reuven Lax via dev
If possible, I would like to see if we could include https://github.com/apache/beam/pull/25642 as we believe this bug has been impacting multiple users. This was merged 4 days ago, but this RC cut does not seem to include it. On Fri, Mar 3, 2023 at 12:18 PM Valentyn Tymofieiev via dev < dev@beam.a

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Valentyn Tymofieiev via dev
I have encountered a failure in a Python pipeline running with Runner v1: RuntimeError: Beam SDK base version 2.46.0 does not match Dataflow Python worker version 2.45.0. Please check Dataflow worker startup logs and make sure that correct version of Beam SDK is installed. We should understand wh

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Robert Bradshaw via dev
+1 (binding). I verified that the artifacts and signatures all look good, all the containers are pushed, and tested some pipelines with a fresh install from one of the Python wheels. On Fri, Mar 3, 2023 at 11:13 AM Danny McCormick wrote: > > > The released artifacts seem to be missing the last c

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Danny McCormick via dev
> The released artifacts seem to be missing the last commit at > https://github.com/apache/beam/commit/c528eab18b32342daed53b750fe330d30c7e5224 > . Is this essential to the release, or just useful for validating it? It's strictly a test infrastructure change, it has no functional impact. For conte

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Robert Bradshaw via dev
The released artifacts seem to be missing the last commit at https://github.com/apache/beam/commit/c528eab18b32342daed53b750fe330d30c7e5224 . Is this essential to the release, or just useful for validating it? On Fri, Mar 3, 2023 at 11:02 AM Danny McCormick wrote: > > Thanks for calling that out,

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Danny McCormick via dev
Thanks for calling that out, and thanks for helping me fix it! We should be all set now On Fri, Mar 3, 2023 at 1:38 PM Robert Bradshaw wrote: > It appears your public key is not published in > https://dist.apache.org/repos/dist/release/beam/KEYS . > > On Fri, Mar 3, 2023 at 8:33 AM Anand Inguva

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Robert Bradshaw via dev
It appears your public key is not published in https://dist.apache.org/repos/dist/release/beam/KEYS . On Fri, Mar 3, 2023 at 8:33 AM Anand Inguva via dev wrote: > > +1 (non-binding) > Tested python wordcount quick start > https://beam.apache.org/get-started/quickstart-py/ on Direct Runner and >

Re: Refactor BigQuery SchemaTransforms naming

2023-03-03 Thread Ahmed Abualsaud via dev
Thank you Damon, I left a few comments. On Fri, Mar 3, 2023 at 11:14 AM Damon Douglas via dev wrote: > Hello Everyone, > > This PR brings BigQuery Schema transforms in line with the others in terms > of naming conventions and use of AutoService. > > https://github.com/apache/beam/pull/25706 > >

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Anand Inguva via dev
+1 (non-binding) Tested python wordcount quick start https://beam.apache.org/get-started/quickstart-py/ on Direct Runner and Dataflow Runner. Thanks! On Fri, Mar 3, 2023 at 11:21 AM Bruno Volpato via dev wrote: > +1 (non-binding) > > Tested with https://github.com/GoogleCloudPlatform/DataflowTe

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Bruno Volpato via dev
+1 (non-binding) Tested with https://github.com/GoogleCloudPlatform/DataflowTemplates (Java SDK 11, Dataflow runner). Thanks Danny! On Thu, Mar 2, 2023 at 5:16 PM Danny McCormick via dev wrote: > Hi everyone, > Please review and vote on release candidate #1 for the version 2.46.0, as > follow

Refactor BigQuery SchemaTransforms naming

2023-03-03 Thread Damon Douglas via dev
Hello Everyone, This PR brings BigQuery Schema transforms in line with the others in terms of naming conventions and use of AutoService. https://github.com/apache/beam/pull/25706 Best, Damon

Re: Beam Release 2.46

2023-03-03 Thread Danny McCormick via dev
> I'd like to suggest that we include in the release voting email template a link to a PR that runs all tests against the release branch. I think we used to include it, but I haven't seen it in recent voting threads. I added it to my email. I also have a running PR of doc improvements for the rele

Beam High Priority Issue Report (38)

2023-03-03 Thread beamactions
This is your daily summary of Beam's current high priority issues that may need attention. See https://beam.apache.org/contribute/issue-priorities for the meaning and expectations around issue priorities. Unassigned P1 Issues: https://github.com/apache/beam/issues/25675 [Bug]: Reenable te