Re: [BEAM-7819] -python - parsing message_id from PubSub message to the PubSubMessage attributes property

2019-08-03 Thread Matthew Darwin
gt;> Reply-To: dev@beam.apache.org<mailto:dev@beam.apache.org> To: dev mailto:dev%20%3c...@beam.apache.org%3e>>, Mark Liu mailto:mark%20liu%20%3cmark...@google.com%3e>> Subject: Re: [BEAM-7819] -python - parsing message_id from PubSub message to the PubSubMessage attributes property Date:

Re: [BEAM-7819] -python - parsing message_id from PubSub message to the PubSubMessage attributes property

2019-08-02 Thread Ahmet Altay
27;m being thick > here! Have I missed some steps in the build? > > Regards > > Matthew > > -Original Message- > *From*: Ahmet Altay > > *Reply-To*: dev@beam.apache.org > *To*: dev >, Udi > Meiri > > *Subject*: Re: [BEAM-7819] -python - parsing mes

Re: [BEAM-7819] -python - parsing message_id from PubSub message to the PubSubMessage attributes property

2019-07-31 Thread Matthew Darwin
h...@google.com%3e>> Subject: Re: [BEAM-7819] -python - parsing message_id from PubSub message to the PubSubMessage attributes property Date: Mon, 29 Jul 2019 09:50:14 -0700 This message originated from outside your organization Hi Matthew, This looks like

Re: [BEAM-7819] -python - parsing message_id from PubSub message to the PubSubMessage attributes property

2019-07-29 Thread Ahmet Altay
Hi Matthew, This looks like a reasonable approach. There is a difference how direct runner reads from pubsub compared to other runners. As you convert to a PR, please pay attention to the difference and add tests for both cases. On Mon, Jul 29, 2019 at 8:35 AM Matthew Darwin < matthew.dar...@carf

[BEAM-7819] -python - parsing message_id from PubSub message to the PubSubMessage attributes property

2019-07-29 Thread Matthew Darwin
Hi All, This is my first attempt at a change for Beam on https://issues.apache.org/jira/browse/BEAM-7819. This parses the message_id when reading from the PubSub protobuf and adds to the message_id, as suggested by the existing documentation - https://beam.apache.org/releases/pydoc/2.13.0/ap