Re: [DISCUSS] Remove JavaBeamZetaSQL and JavaBeamZetaSQLJava11 PreCommits

2020-07-29 Thread Rui Wang
Opened a PR: https://github.com/apache/beam/pull/12417 -Rui On Tue, Jul 28, 2020 at 5:10 PM Kenneth Knowles wrote: > Yes, it seems like we probably have redundancy. Based on > https://github.com/apache/beam/pull/9210#discussion_r315899335 it sounds > like you added the ZetaSQL precommit when t

Re: [DISCUSS] Remove JavaBeamZetaSQL and JavaBeamZetaSQLJava11 PreCommits

2020-07-28 Thread Kenneth Knowles
Yes, it seems like we probably have redundancy. Based on https://github.com/apache/beam/pull/9210#discussion_r315899335 it sounds like you added the ZetaSQL precommit when the SQL precommit was run as part of the Java precommit. Since then, the SQL precommit was separated from Java. It makes sense

[DISCUSS] Remove JavaBeamZetaSQL and JavaBeamZetaSQLJava11 PreCommits

2020-07-28 Thread Rui Wang
Hi community, I observed that when there is a BeamSQL related PR, there will be four precommits: SQL precommit, JavaBeamZetaSQL Precommit, and their Java11 version. It turns out that SQL precommit will run tests from the Beam ZetaSQL module. Thus we can remove JavaBeamZetaSQL and JavaBeamZetaSQLJ