Re: [PROPOSAL] python precommit timeouts

2019-12-23 Thread jincheng sun
Big +1 on it. Thanks a lot for the improvement Udi ! It also make sense to have this timeout for other tests like Max said. I'm thinking whether there are any timeout configurations for Jenkins, in this case, the timeout config could be applied to all tests if necessary. Best, Jincheng Robert

Re: [PROPOSAL] python precommit timeouts

2019-12-20 Thread Robert Bradshaw
On Fri, Dec 20, 2019 at 3:15 PM Udi Meiri wrote: > > ITs will have a different timeout, but they're still not migrated to pytest > so unaffected at the moment. > > So I created a PR and already seemed to find an issue. One test timed out > while scanning the local filesystem. > It seems that it

Re: [PROPOSAL] python precommit timeouts

2019-12-20 Thread Udi Meiri
ITs will have a different timeout, but they're still not migrated to pytest so unaffected at the moment. So I created a PR and already seemed to find an issue. One test timed out while scanning the local filesystem. It seems that it was scanning /tmp, wh

Re: [PROPOSAL] python precommit timeouts

2019-12-20 Thread Pablo Estrada
big +1! As Ahmet suggested, the IT-marked tests may need to have a different timeout. But other than that, I think this is great. On Fri, Dec 20, 2019 at 9:39 AM Udi Meiri wrote: > https://issues.apache.org/jira/browse/BEAM-9009 > > On Fri, Dec 20, 2019 at 6:18 AM Maximilian Michels wrote: > >

Re: [PROPOSAL] python precommit timeouts

2019-12-20 Thread Udi Meiri
https://issues.apache.org/jira/browse/BEAM-9009 On Fri, Dec 20, 2019 at 6:18 AM Maximilian Michels wrote: > +1 Good idea. We should also have this for Java if possible. > > On 20.12.19 02:59, Ahmet Altay wrote: > > This sounds reasonable. Would this be configurable per-test if needed? > > > > On

Re: [PROPOSAL] python precommit timeouts

2019-12-20 Thread Maximilian Michels
+1 Good idea. We should also have this for Java if possible. On 20.12.19 02:59, Ahmet Altay wrote: This sounds reasonable. Would this be configurable per-test if needed? On Thu, Dec 19, 2019 at 5:52 PM Udi Meiri > wrote: Looking at this console log

Re: [PROPOSAL] python precommit timeouts

2019-12-19 Thread Ahmet Altay
This sounds reasonable. Would this be configurable per-test if needed? On Thu, Dec 19, 2019 at 5:52 PM Udi Meiri wrote: > Looking at this console log > , >

[PROPOSAL] python precommit timeouts

2019-12-19 Thread Udi Meiri
Looking at this console log , it seems that some pytests got stuck (or slowed down considerably). I'd like to put a 10 minute default timeout on all unit test