[RESULT] [VOTE] Release 2.56.0, release candidate #2

2024-05-01 Thread Danny McCormick via dev
I'm happy to announce that we have unanimously approved this release. There are 7 approving votes, 3 of which are binding: * Jan Lukavský (binding) * Chamikara Jayalath (binding) * Valentyn Tymofieiev (binding) * XQ Hu * Yi Hu * Jeff Kinard * Ritesh Ghorse There are no disapproving votes. I will

Re: [VOTE] Release 2.56.0, release candidate #2

2024-05-01 Thread Valentyn Tymofieiev via dev
Thanks, Danny. +1 Verified Python pipelines on Dataflow, checked that released containers include fixes for a regression in GRPC IO that affected last release. On Wed, May 1, 2024 at 11:30 AM Danny McCormick wrote: > I added https://github.com/apache/beam/pull/31038#issuecomment-2088879104 >

Re: [VOTE] Release 2.56.0, release candidate #2

2024-05-01 Thread Danny McCormick via dev
I added https://github.com/apache/beam/pull/31038#issuecomment-2088879104 triaging the issues. The JPMS ones do seem to have been from the Dataflow containers not being published, they succeeded on retry. The remaining issues generally seem to be flakes or infrastructure issues. Thanks, Danny On

Re: [VOTE] Release 2.56.0, release candidate #2

2024-05-01 Thread Danny McCormick via dev
I'll go through and triage/rekick off some Dataflow suites and summarize the results in the PR. The JPMS ones (and possibly others) might be because I hadn't published Dataflow containers yet when I ran them, the log isn't helpful so I'll try to capture the actual job which failed. Thanks, Danny

Re: [VOTE] Release 2.56.0, release candidate #2

2024-05-01 Thread Valentyn Tymofieiev via dev
What is the high-level summary of test failures on https://github.com/apache/beam/pull/31038 - are all issues preexisting/infra-related/already tracked? In particular, I noticed two failures in the Java JPMS test suite, which I hadn't come across before. On Wed, May 1, 2024 at 8:16 AM Ritesh Ghor

Re: [VOTE] Release 2.56.0, release candidate #2

2024-05-01 Thread Ritesh Ghorse via dev
+1 (non-binding) Ran a few python pipelines on Direct and Dataflow runner Thanks! On Wed, May 1, 2024 at 10:00 AM Jeff Kinard via dev wrote: > +1 (non-binding) > > Validated Dataflow YamlTemplate using Java and Python transforms (xlang) > and several Beam YAML tests. > > Thanks, > Jeff > > On

Re: [VOTE] Release 2.56.0, release candidate #2

2024-05-01 Thread Jeff Kinard via dev
+1 (non-binding) Validated Dataflow YamlTemplate using Java and Python transforms (xlang) and several Beam YAML tests. Thanks, Jeff On Sat, Apr 27, 2024 at 7:42 AM Danny McCormick via dev wrote: > Hi everyone, > Please review and vote on the release candidate #2 for the version 2.56.0, > as fo

Re: [VOTE] Release 2.56.0, release candidate #2

2024-05-01 Thread j...@thekinards.com
+1 (non-binding)Validated Dataflow YamlTemplate using Java and Python transforms (xlang) and several Beam YAML tests.Thanks,JeffOn Apr 30, 2024, at 11:19 PM, Yi Hu via dev wrote:+1 (non-binding)Validated Dataflow Template [1] (except Yaml and Python xlang templates, which will be validated separa

Re: [VOTE] Release 2.56.0, release candidate #2

2024-04-30 Thread Yi Hu via dev
+1 (non-binding) Validated Dataflow Template [1] (except Yaml and Python xlang templates, which will be validated separately), and GCPIO load tests on Dataflow runner [2] [1] https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/1487 [2] https://github.com/GoogleCloudPlatform/DataflowTem

Re: [VOTE] Release 2.56.0, release candidate #2

2024-04-30 Thread Chamikara Jayalath via dev
+1 (binding) Validated multi-lang Java/Python and the transform upgrade feature. Thanks, Cham On Mon, Apr 29, 2024 at 12:57 AM Jan Lukavský wrote: > +1 (binding). > > Tested Java SDK with Flink runner. > > Jan > On 4/28/24 15:32, XQ Hu via dev wrote: > > +1 (non-binding). Tested it using the

Re: [VOTE] Release 2.56.0, release candidate #2

2024-04-29 Thread Jan Lukavský
+1 (binding). Tested Java SDK with Flink runner.  Jan On 4/28/24 15:32, XQ Hu via dev wrote: +1 (non-binding). Tested it using the dataflow ML pipeline: https://github.com/google/dataflow-ml-starter/actions/runs/8862170843/job/24334816481 On Sat, Apr 27, 2024 at 7:42 AM Danny McCormick via d

Re: [VOTE] Release 2.56.0, release candidate #2

2024-04-28 Thread XQ Hu via dev
+1 (non-binding). Tested it using the dataflow ML pipeline: https://github.com/google/dataflow-ml-starter/actions/runs/8862170843/job/24334816481 On Sat, Apr 27, 2024 at 7:42 AM Danny McCormick via dev wrote: > Hi everyone, > Please review and vote on the release candidate #2 for the version 2.5

[VOTE] Release 2.56.0, release candidate #2

2024-04-27 Thread Danny McCormick via dev
Hi everyone, Please review and vote on the release candidate #2 for the version 2.56.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) Reviewers are encouraged to test their own use cases with the release candidate, and vote +1 if no i