Re: [VOTE] Release vendored artifacts upgrading Guava usage to 26.0-jre, release candidate #1

2019-06-25 Thread Lukasz Cwik
Thanks Ismael. I'll cancel this vote for now with the intent that it is re-opened in the future once Ismael's points are addressed. I have opened a PR[1] which allows us to build the updated vendored artifacts without migrating our usage to them. I have started a doc[2] to gather people's notes on

Re: [VOTE] Release vendored artifacts upgrading Guava usage to 26.0-jre, release candidate #1

2019-06-24 Thread Ismaël Mejía
The upgrade is worth for security reasons and to catch the gRPC improvements so really nice that this is happening. However I am not clear if we are mixing two things here. (1) The release of the vendored versions and (2) the upgrade of it into Beam. I think those should be separate (obviously kno

Re: [VOTE] Release vendored artifacts upgrading Guava usage to 26.0-jre, release candidate #1

2019-06-24 Thread Lukasz Cwik
Pinging for PMC to validate & vote. On Thu, Jun 20, 2019 at 3:52 PM Ahmet Altay wrote: > +1 verified signatures and hashes. > > Thank you Luke. > > On Thu, Jun 20, 2019 at 12:27 PM Lukasz Cwik wrote: > >> We should verify the signatures of the artifacts. >> >> Otherwise, there is little risk in

Re: [VOTE] Release vendored artifacts upgrading Guava usage to 26.0-jre, release candidate #1

2019-06-20 Thread Ahmet Altay
+1 verified signatures and hashes. Thank you Luke. On Thu, Jun 20, 2019 at 12:27 PM Lukasz Cwik wrote: > We should verify the signatures of the artifacts. > > Otherwise, there is little risk in releasing these artifacts because no > one consumes them yet. PR/8899[1] updates Apache Beam to start

Re: [VOTE] Release vendored artifacts upgrading Guava usage to 26.0-jre, release candidate #1

2019-06-20 Thread Lukasz Cwik
We should verify the signatures of the artifacts. Otherwise, there is little risk in releasing these artifacts because no one consumes them yet. PR/8899[1] updates Apache Beam to start using them and will go through the regular precommit/postcommit tests. If you want to perform additional validat

Re: [VOTE] Release vendored artifacts upgrading Guava usage to 26.0-jre, release candidate #1

2019-06-20 Thread Ahmet Altay
What is the best way to validate this? On Thu, Jun 20, 2019 at 9:51 AM Lukasz Cwik wrote: > Hi everyone, > > Please review the release of the following artifacts that we vendor: > beam-vendor-guava-26_0-jre > beam-vendor-grpc-1_21_0 > > Please vote as follows: > [ ] +1, Approve the release > [ ]

[VOTE] Release vendored artifacts upgrading Guava usage to 26.0-jre, release candidate #1

2019-06-20 Thread Lukasz Cwik
Hi everyone, Please review the release of the following artifacts that we vendor: beam-vendor-guava-26_0-jre beam-vendor-grpc-1_21_0 Please vote as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available fo