Re: A question regarding BEAM-3280

2017-12-18 Thread Lukasz Cwik
Welcome. I added Norio as a contributor and assigned the task to them. On Fri, Dec 15, 2017 at 4:55 PM, Ahmet Altay wrote: > Hi Norio, > > The ticket is asking for an example however this feature is currently not > supported by the SDK. First the support needs to be added. > > On Tue, Dec 12, 2

Re: A question regarding BEAM-3280

2017-12-15 Thread Ahmet Altay
Hi Norio, The ticket is asking for an example however this feature is currently not supported by the SDK. First the support needs to be added. On Tue, Dec 12, 2017 at 10:44 PM, Akagi Norio wrote: > Hi Ahmet and Robert, > > Thank you for the reply. > Just to clarify, I initially thought this tic

Re: A question regarding BEAM-3280

2017-12-12 Thread Akagi Norio
Hi Ahmet and Robert, Thank you for the reply. Just to clarify, I initially thought this ticket is just to add an example, is it correct? An example from Roberts looks not supported by current SDK https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/ptransform.py#L280 <

Re: A question regarding BEAM-3280

2017-12-11 Thread Robert Bradshaw
+1. For example, one might do something like split_lines_result = (lines | beam.ParDo(SplitLinesToWordsFn().with_output_types( beam.typehints.Generator[int], SplitLinesToWordsFn.OUTPUT_TAG_SHORT_WORDS=beam.typehints.Generat

Re: A question regarding BEAM-3280

2017-12-11 Thread Ahmet Altay
Hi Norio, Thank you for your interest. If you would like to work on this I can assign the JIRA to you. I do not think this change in sufficient or correct. This reads as if SplitLinesToWordsFn returns a Tuple of things, however instead it produces three unrelated collections of different types. I

A question regarding BEAM-3280

2017-12-11 Thread Akagi Norio
Hi, I’m working on a task BEAM-3280 (Add typehints with TaggedOutput) and just want to clarify before I send a PR. https://issues.apache.org/jira/browse/BEAM-3280 Is it sufficient to modify the code in apache_beam.cookbook.multiple_output_pardo