Re: [EXTERNAL] Re: FirestoreIO connector [JavaSDK]

2019-12-02 Thread Chamikara Jayalath
> > > > Getting a review would be nice. > > > > All the best, > > Stefan > > > > *From:* Chamikara Jayalath > *Sent:* Wednesday, November 6, 2019 8:05 PM > *To:* dev > *Subject:* Re: [EXTERNAL] Re: FirestoreIO connector [JavaSDK] > > > >

RE: [EXTERNAL] Re: FirestoreIO connector [JavaSDK]

2019-12-02 Thread Stefan Djelekar
Subject: Re: [EXTERNAL] Re: FirestoreIO connector [JavaSDK] BTW, FYI, I'm also talking with folks from Google Firestore team regarding this. I think they had shown some interest in taking this up but I'm not sure. If they are able to contribute here, and if we can coordinate with some o

Re: [EXTERNAL] Re: FirestoreIO connector [JavaSDK]

2019-11-06 Thread Chamikara Jayalath
t; > I’ll make the PR in the next few days and let’s pick it up from there. > > > > King regards, > > Stefan > > > > > > *From:* Chamikara Jayalath > *Sent:* Tuesday, November 5, 2019 2:24 AM > *To:* dev > *Subject:* [EXTERNAL] Re: FirestoreIO c

RE: [EXTERNAL] Re: FirestoreIO connector [JavaSDK]

2019-11-06 Thread Stefan Djelekar
AM To: dev Subject: [EXTERNAL] Re: FirestoreIO connector [JavaSDK] Thanks for the contribution. Happy to help with the review. Also, probably it'll be good to follow patterns employed by the existing Datastore connector when applicable: https://github.com/apache/beam/blob/master/sdks/ja

Re: FirestoreIO connector [JavaSDK]

2019-11-04 Thread Chamikara Jayalath
Thanks for the contribution. Happy to help with the review. Also, probably it'll be good to follow patterns employed by the existing Datastore connector when applicable: https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/

Re: FirestoreIO connector [JavaSDK]

2019-11-04 Thread Ismaël Mejía
Hello, Please open a PR with the code of the new connector rebased against the latest master. It is worth to take a look at Beam's contribution guide [1] and PTransform style guide [2] in advance. In any case we can guide you on any issue during the PR review so please go ahead. Regards, Ismaël

FirestoreIO connector [JavaSDK]

2019-11-04 Thread Stefan Djelekar
Hi beam devs, I'm Stefan from Redbox. We are a customer of GCP and we are in need of beam Java connector for Firestore. There is a pending JIRA item for this. https://issues.apache.org/jira/browse/BEAM-8376 The team inside of the company has been working on this for a while and we would like