Re: [EXTERNAL] Re: Hiding logging for beam playground examples

2024-03-08 Thread Vlado Djerek via dev
Hi Joey, We just deployed the 2.54 changes on playground. Can you now check? Thanks, Vlado From: Joey Tran Sent: Friday, March 8, 2024 2:45:32 PM To: Andrey Devyatkin Subject: [EXTERNAL] Re: Hiding logging for beam playground examples Ah thanks Andrey! I had

Re: Hiding logging for beam playground examples

2024-03-08 Thread Joey Tran
> *Reply to: *"dev@beam.apache.org" > *Date: *Thursday, 7 March 2024 at 22:33 > *To: *Valentyn Tymofieiev > *Subject: *[EXTERNAL] Re: Hiding logging for beam playground examples > > > > I ended up making this change[1] but it looks like Playground is still >

Re: Hiding logging for beam playground examples

2024-03-08 Thread Andrey Devyatkin via dev
Valentyn Tymofieiev Subject: [EXTERNAL] Re: Hiding logging for beam playground examples I ended up making this change[1] but it looks like Playground is still outputting all the log statements. Could someone help me with this? I suppose it's best to try and actually test this, but I ha

Re: Hiding logging for beam playground examples

2024-03-07 Thread Joey Tran
I ended up making this change[1] but it looks like Playground is still outputting all the log statements. Could someone help me with this? I suppose it's best to try and actually test this, but I had a hard time getting the environment set up. [1]https://github.com/apache/beam/pull/29948

Re: Hiding logging for beam playground examples

2023-11-16 Thread Joey Tran
Good idea though it ended up being a shallow trace ``` File "/opt/playground/backend/executable_files/91e3e49b-7197-4252-a8bd-93c5b252ed55/91e3e49b-7197-4252-a8bd-93c5b252ed55.py", line 57, in assert False ``` I think I found where the log level is set anyways ``` https://github.com/apache/b

Re: Hiding logging for beam playground examples

2023-11-15 Thread Valentyn Tymofieiev via dev
I am also not familiar with Playground. I suspect you could try to make it crash and maybe find a stacktrace? Setting logging could like like so: https://github.com/apache/beam/blob/729c4de416b8252ec99f0a1253ac7af3023733df/sdks/python/apache_beam/examples/wordcount.py#L110 On Wed, Nov 15, 2023 at

Re: Hiding logging for beam playground examples

2023-11-15 Thread Joey Tran
The motivating example does not use LogElements, just Map(print) https://beam.apache.org/documentation/transforms/python/aggregation/combineglobally/#example-2-combining-with-a-lambda-function Some examples of the extraneous logging: ``` 2023-09-08 22:46:37,334 [INFO] ===

Re: Hiding logging for beam playground examples

2023-11-15 Thread Valentyn Tymofieiev via dev
Are the examples using LogElements? https://github.com/apache/beam/blob/2012107a0fa2bb3fedf1b5aedcb49445534b2dad/sdks/python/apache_beam/transforms/util.py#L1271 Note that LogElements by default prints to stdout, but can be configured to use a different logger. We could also change the default. O

Re: Hiding logging for beam playground examples

2023-11-14 Thread Robert Bradshaw via dev
+1 to at least setting the log level to higher than info. Some runner logging (e.g. job started/done) may be useful. On Tue, Nov 14, 2023 at 9:37 AM Joey Tran wrote: > > Hi all, > > I just had a workshop to demo beam for people at my company and there was a > bit of confusion about whether the b

Hiding logging for beam playground examples

2023-11-14 Thread Joey Tran
Hi all, I just had a workshop to demo beam for people at my company and there was a bit of confusion about whether the beam python playground examples were even working and it turned out they just got confused by all the runner logging that is output. Is this worth keeping? It seems like it'd be