PCollection#applyWindowingStrategyInternal

2024-04-06 Thread Jan Lukavský
Hi, I came across a case where using PCollection#applyWindowingStrategyInternal seems legit in user core. The case is roughly as follows:  a) compute some streaming statistics  b) apply the same transform (say ComputeWindowedAggregation) with different parameters on these statistics

Re: PCollection#applyWindowingStrategyInternal

2024-04-06 Thread Jan Lukavský
Lukavský wrote: Hi, I came across a case where using PCollection#applyWindowingStrategyInternal seems legit in user core. The case is roughly as follows:  a) compute some streaming statistics  b) apply the same transform (say ComputeWindowedAggregation) with different parameters on these

Re: PCollection#applyWindowingStrategyInternal

2024-04-06 Thread Reuven Lax via dev
t; PCollections with incompatible windowFns more user-friendly. The current > approach where we require the same windowFn for all input PCollections > creates some unnecessary boilerplate code needed on user side. > > Jan > > On 4/6/24 15:45, Jan Lukavský wrote: >

Re: PCollection#applyWindowingStrategyInternal

2024-04-09 Thread Jan Lukavský
current approach where we require the same windowFn for all input PCollections creates some unnecessary boilerplate code needed on user side.   Jan On 4/6/24 15:45, Jan Lukavský wrote: > Hi, > > I came across a case where using > PCollection#applyWindow

Re: PCollection#applyWindowingStrategyInternal

2024-04-09 Thread Kenneth Knowles
if we can make flattening >> PCollections with incompatible windowFns more user-friendly. The current >> approach where we require the same windowFn for all input PCollections >> creates some unnecessary boilerplate code needed on user side. >> >> Jan >> >> On

Re: PCollection#applyWindowingStrategyInternal

2024-04-10 Thread Jan Lukavský
input PCollections creates some unnecessary boilerplate code needed on user side.   Jan On 4/6/24 15:45, Jan Lukavský wrote: > Hi, > > I came across a case where using > PCollection#applyWindowingStrategyInter

Re: PCollection#applyWindowingStrategyInternal

2024-04-10 Thread Reuven Lax via dev
and very poorly documented, so I doubt many users >> know about this! >> >> Reuven >> >> On Sat, Apr 6, 2024 at 7:09 AM Jan Lukavský wrote: >> >>> Immediate self-correction, although setting the strategy directly via >>> setWindowingStrategyInte

Re: PCollection#applyWindowingStrategyInternal

2024-04-11 Thread Jan Lukavský
pproach where we require the same windowFn for all input PCollections creates some unnecessary boilerplate code needed on user side.   Jan On 4/6/24 15:45, Jan Lukavský wrote: > Hi, > > I cam

Re: PCollection#applyWindowingStrategyInternal

2024-04-11 Thread Reuven Lax via dev
previous window 11-12). Users can do this by providing a >>> WindowMappingFunction to the View - essentially a function from window to >>> window. Unfortunately this is hard to use (one must create their own >>> PCollectionView class) and very poorly docume

Re: PCollection#applyWindowingStrategyInternal

2024-04-15 Thread Jan Lukavský
reates some unnecessary boilerplate code needed on user side.   Jan On 4/6/24 15:45, Jan Lukavský wrote: > Hi, > > I came across a case where using > PCollection#applyWindowingStrategyInternal seems

Re: PCollection#applyWindowingStrategyInternal

2024-04-15 Thread Reuven Lax via dev
>>>> >>>> >>>> In Side input we also allow the user to control this mapping, so for >>>> example side input elements could always map to the previous fixed window >>>> (e.g. while processing window 12-1, you want to see summary data of all >

Re: PCollection#applyWindowingStrategyInternal

2024-04-22 Thread Kenneth Knowles
the global-window elements into the main-input's >>>>> fixed window. >>>>> >>>>> This is a one-sided merge function, there is a 'main' and 'side' >>>>> input, but the generic symmetric merge might be possible as w

Re: PCollection#applyWindowingStrategyInternal

2024-04-23 Thread Jan Lukavský
te code needed on user side.   Jan On 4/6/24 15:45, Jan Lukavský wrote: > Hi, > > I came across a case where using > PCollection#applyWindow

Re: PCollection#applyWindowingStrategyInternal

2024-04-23 Thread Reuven Lax via dev
t; However >>>>>> main input elements are supposed to see side input elements in the same >>>>>> window (and in fact main inputs are blocked until the side-input window >>>>>> is >>>>>> ready), so we must do a mapping. If for e

Re: PCollection#applyWindowingStrategyInternal

2024-04-25 Thread Jan Lukavský
ections creates some unnecessary boilerplate code needed on user side.   Jan On 4/6/24 15:45, Jan Lukavský wrote:

Re: PCollection#applyWindowingStrategyInternal

2024-04-25 Thread Reuven Lax via dev
;>> construction >>>>>>> time. Alternatively only as a small syntactic sugar, something like: >>>>>>> >>>>>>> >>>>>>> Flatten.pCollections().withWindowingStrategy(WindowResolution.into(oneInput.getWindo

Re: PCollection#applyWindowingStrategyInternal

2024-05-05 Thread Jan Lukavský
The current approach where we require the same windowFn for all input PCollections creates some unnecessary boilerplate code needed on user