Re: PAssertTest#runExpectingAssertionFailure() and waitUntilFinish()

2016-12-05 Thread Kenneth Knowles
Hi Stas, This is something special to TestPipeline and the test configuration for a runner. If runExpectingAssertionFailure() does not succeed, then our whole suite of RunnableOnService tests is not going to work, because they all have an assumption that TestPipeline#run() waits until the asserti

PAssertTest#runExpectingAssertionFailure() and waitUntilFinish()

2016-12-05 Thread Stas Levin
Hi, PAssertTest#runExpectingAssertionFailure() contains the following block: try { pipeline.run(); } catch (AssertionError exc) { return exc; } I was wondering if in some cases this might not produce the desired effect, particularly if the run() method returns before the pipeline has ended.