[GitHub] bigtop pull request #382: Bigtop-3070 support Spark Thrift Server in Charm

2018-08-20 Thread buggtb
GitHub user buggtb opened a pull request: https://github.com/apache/bigtop/pull/382 Bigtop-3070 support Spark Thrift Server in Charm The thrift server has no exposure and should be configurable for Spark SQL support etc. You can merge this pull request into a Git repository by runn

[GitHub] bigtop pull request #382: Bigtop-3070 support Spark Thrift Server in Charm

2018-08-23 Thread kwmonroe
Github user kwmonroe commented on a diff in the pull request: https://github.com/apache/bigtop/pull/382#discussion_r212387730 --- Diff: bigtop-packages/src/charm/spark/layer-spark/reactive/spark.py --- @@ -236,7 +235,8 @@ def reconfigure_spark(): # Almost all config changes

[GitHub] bigtop pull request #382: Bigtop-3070 support Spark Thrift Server in Charm

2018-08-24 Thread kwmonroe
Github user kwmonroe commented on a diff in the pull request: https://github.com/apache/bigtop/pull/382#discussion_r212650418 --- Diff: bigtop-packages/src/charm/spark/layer-spark/reactive/spark.py --- @@ -236,7 +235,8 @@ def reconfigure_spark(): # Almost all config changes

[GitHub] bigtop pull request #382: Bigtop-3070 support Spark Thrift Server in Charm

2018-08-28 Thread buggtb
Github user buggtb commented on a diff in the pull request: https://github.com/apache/bigtop/pull/382#discussion_r213245996 --- Diff: bigtop-packages/src/charm/spark/layer-spark/reactive/spark.py --- @@ -236,7 +235,8 @@ def reconfigure_spark(): # Almost all config changes s

[GitHub] bigtop pull request #382: Bigtop-3070 support Spark Thrift Server in Charm

2018-08-28 Thread buggtb
Github user buggtb commented on a diff in the pull request: https://github.com/apache/bigtop/pull/382#discussion_r213354825 --- Diff: bigtop-packages/src/charm/spark/layer-spark/reactive/spark.py --- @@ -318,3 +318,10 @@ def client_present(client): def client_should_stop(client

[GitHub] bigtop pull request #382: Bigtop-3070 support Spark Thrift Server in Charm

2018-08-28 Thread buggtb
Github user buggtb commented on a diff in the pull request: https://github.com/apache/bigtop/pull/382#discussion_r213355410 --- Diff: bigtop-packages/src/charm/spark/layer-spark/lib/charms/layer/bigtop_spark.py --- @@ -400,6 +400,10 @@ def start(self): else:

[GitHub] bigtop pull request #382: Bigtop-3070 support Spark Thrift Server in Charm

2018-08-31 Thread kwmonroe
Github user kwmonroe commented on a diff in the pull request: https://github.com/apache/bigtop/pull/382#discussion_r214484656 --- Diff: bigtop-packages/src/charm/spark/layer-spark/lib/charms/layer/bigtop_spark.py --- @@ -400,6 +400,10 @@ def start(self): else:

[GitHub] bigtop pull request #382: Bigtop-3070 support Spark Thrift Server in Charm

2018-08-31 Thread kwmonroe
Github user kwmonroe commented on a diff in the pull request: https://github.com/apache/bigtop/pull/382#discussion_r214485545 --- Diff: bigtop-packages/src/charm/spark/layer-spark/reactive/spark.py --- @@ -236,7 +235,8 @@ def reconfigure_spark(): # Almost all config changes

[GitHub] bigtop pull request #382: Bigtop-3070 support Spark Thrift Server in Charm

2018-08-31 Thread kwmonroe
Github user kwmonroe commented on a diff in the pull request: https://github.com/apache/bigtop/pull/382#discussion_r214485587 --- Diff: bigtop-packages/src/charm/spark/layer-spark/reactive/spark.py --- @@ -318,3 +318,10 @@ def client_present(client): def client_should_stop(clie

[GitHub] bigtop pull request #382: Bigtop-3070 support Spark Thrift Server in Charm

2018-08-31 Thread kwmonroe
Github user kwmonroe commented on a diff in the pull request: https://github.com/apache/bigtop/pull/382#discussion_r214485628 --- Diff: bigtop-packages/src/charm/spark/layer-spark/reactive/spark.py --- @@ -318,3 +318,10 @@ def client_present(client): def client_should_stop(clie