eolivelli commented on issue #81: BOOKKEEPER-753: Bookie should run garbage
collection before startup when all directories became full
URL: https://github.com/apache/bookkeeper/pull/81#issuecomment-314988353
@jvrao @reddycharan this is another long standing patch. Do you think we can
ship
eolivelli commented on issue #205: Issue 208: Improve ledger fence logic
URL: https://github.com/apache/bookkeeper/pull/205#issuecomment-314970090
@sijie are going to merge this now? I can merge this and other approved
patches today
eolivelli commented on issue #205: Issue 208: Improve ledger fence logic
URL: https://github.com/apache/bookkeeper/pull/205#issuecomment-314988197
@sijie sorry I did not see that it needs a rebase
This is an automated message
eolivelli commented on issue #238: Issue-237 Upgrade to ZooKeeper 3.5.3-BETA
URL: https://github.com/apache/bookkeeper/pull/238#issuecomment-314971055
@sijie @jiazhai is this ok for you? We upgraded to 3.5 branch for DL.
Thi
eolivelli commented on issue #233: WIP - Issue 232: Add code-coverage report
using JaCoCo
URL: https://github.com/apache/bookkeeper/pull/233#issuecomment-314970390
@sijie I will update the patch with the same jacoco config of DL. Infra team
did not respond to my email about coveralls.io .
Got it. will add code-coverage and "http server"
Thanks.
On Thu, Jul 13, 2017 at 10:22 AM, Sijie Guo wrote:
> Thank you Jia for putting this up.
>
> Can we also add an item for the http server? I follow the pull requests,
> but the pull request has been idle for a while. I know there are multipl
eolivelli commented on issue #205: Issue 208: Improve ledger fence logic
URL: https://github.com/apache/bookkeeper/pull/205#issuecomment-314970090
@sijie are going to merge this now? I can merge this and other approved
patches today
jvrao commented on issue #240: ISSUE #239: typo in class name
SpeculativeRequestExecutor
URL: https://github.com/apache/bookkeeper/pull/240#issuecomment-314969220
+1
This is an automated message from the Apache Git Service.
jvrao commented on issue #205: Issue 208: Improve ledger fence logic
URL: https://github.com/apache/bookkeeper/pull/205#issuecomment-314968855
@sijie thanks for the explanation; ok for me.
This is an automated message from th
sijie commented on issue #205: Issue 208: Improve ledger fence logic
URL: https://github.com/apache/bookkeeper/pull/205#issuecomment-314968274
@jvrao any more comments?
This is an automated message from the Apache Git Service
sijie commented on issue #239: Typo in class name SpeculativeRequestExectuor
URL: https://github.com/apache/bookkeeper/issues/239#issuecomment-314966510
Nice caught! @eribeiro
This is an automated message from the Apache Git
eribeiro opened a new pull request #240: ISSUE #239: typo in class name
SpeculativeRequestExecutor
URL: https://github.com/apache/bookkeeper/pull/240
Fix a simple typo in class name. It should be `SpeculativeRequestExecutor`
instead of `SpeculativeRequestExectuor`.
--
eribeiro opened a new issue #239: Typo in class name SpeculativeRequestExectuor
URL: https://github.com/apache/bookkeeper/issues/239
Trivial issue: refactoring a class name then fixing a typo.
expected to see:
SpeculativeRequestExecutor.java
what I see:
Speculativ
Please add this to the agenda tomorrow. Dustin please plan on attending.
On Wed, Jul 12, 2017 at 7:18 PM wrote:
> sijie commented on issue #210: BOOKKEEPER-1100: Add Http Server for
> Bookkeeper
> URL: https://github.com/apache/bookkeeper/pull/210#issuecomment-314950842
>
>
>@jvrao @eolivell
Thank you Jia for putting this up.
Can we also add an item for the http server? I follow the pull requests,
but the pull request has been idle for a while. I know there are multiple
efforts working on this. It would be good if we can consolidate all the
efforts and move the development forward.
-
sijie commented on issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/210#issuecomment-314950842
@jvrao @eolivelli @yzang @jiazhai do any of you want to start an email
thread in dev@ to carry this discussion forward? It doesn't seem th
sijie commented on issue #233: WIP - Issue 232: Add code-coverage report using
JaCoCo
URL: https://github.com/apache/bookkeeper/pull/233#issuecomment-314950498
I think DL also uses jacoco to report code coverage to coveralls.io. It
might be good to make these two repo using same mechanism,
sijie commented on issue #231: Issue 230: Add Checkstyle to the build process
(Part 1)
URL: https://github.com/apache/bookkeeper/pull/231#issuecomment-314950142
@eolivelli what is your take for this? shall we move on?
This i
sijie commented on issue #220: BOOKKEEPER-1095: Long Poll - Server and Client
Side Changes
URL: https://github.com/apache/bookkeeper/pull/220#issuecomment-314950046
@merlimat @jvrao can you guys review this?
This is an autom
On Wed, Jul 12, 2017 at 10:35 PM, Enrico Olivelli
wrote:
> Sijie, JV, just a recap my point of view:
> - considering latency = "time for asynchAddEntry to complete"
> - there is a some difference from 4.4 and 4.5 in the usage of memory, but
> no so clear
> - the type of GC (parallel vs G1) does n
👍
On Thu, Jul 13, 2017 at 5:34 AM, Venkateswara Rao Jujjuri wrote:
> Awesome. !!
>
> On Tue, Jul 11, 2017 at 6:06 AM, Enrico Olivelli
> wrote:
>
> > The ticket has been closed.
> > The protection is on
> >
> > -- Enrico
> >
> > 2017-07-07 11:22 GMT+02:00 Enrico Olivelli :
> >
> > >
> > >
> > >
Awesome. !!
On Tue, Jul 11, 2017 at 6:06 AM, Enrico Olivelli
wrote:
> The ticket has been closed.
> The protection is on
>
> -- Enrico
>
> 2017-07-07 11:22 GMT+02:00 Enrico Olivelli :
>
> >
> >
> > 2017-07-07 1:51 GMT+02:00 Sijie Guo :
> >
> >> +1 for disable force push to master
> >>
> >
> >
>
Sijie, JV, just a recap my point of view:
- considering latency = "time for asynchAddEntry to complete"
- there is a some difference from 4.4 and 4.5 in the usage of memory, but
no so clear
- the type of GC (parallel vs G1) does not impact very much but with G1 you
achieve best latency
- using the
23 matches
Mail list logo