That's a great work
I will review carefully
Thanks
Enrico
Il lun 29 gen 2018, 07:00 Sijie Guo ha scritto:
> Updates:
>
> I merged the corresponding modules into a bk branch. details are described
> in https://github.com/apache/bookkeeper/issues/1068
>
> A subsequent PR to
That's a great work
I will review carefully
Thanks
Enrico
Il lun 29 gen 2018, 07:00 Sijie Guo ha scritto:
> Updates:
>
> I merged the corresponding modules into a bk branch. details are described
> in https://github.com/apache/bookkeeper/issues/1068
>
> A subsequent PR to
Updates:
I merged the corresponding modules into a bk branch. details are described
in https://github.com/apache/bookkeeper/issues/1068
A subsequent PR to integrate those modules with BK pom files. In this PR,
this modules will not be built unless `-Pdistributedlog` is provided.
+1
Release notes is good
checksums are good
source and binary pages are good.
On Sun, Jan 28, 2018 at 2:50 PM, Yiming Zang
wrote:
> +1
>
> - MD5 SHA signature looks good
> - Source code looks good
> - Binary looks good
>
> On Sun, Jan 28, 2018 at 6:59 AM, David Rusek
+1
- MD5 SHA signature looks good
- Source code looks good
- Binary looks good
On Sun, Jan 28, 2018 at 6:59 AM, David Rusek wrote:
> I'll take a look first thing tomorrow morning.
>
> On Sun, Jan 28, 2018 at 3:23 AM Enrico Olivelli
> wrote:
>
> >
I'll take a look first thing tomorrow morning.
On Sun, Jan 28, 2018 at 3:23 AM Enrico Olivelli wrote:
> Thank you all,
> We need another PMC +1
>
> Enrico
>
> Il ven 26 gen 2018, 17:42 Ivan Kelly ha scritto:
>
> > +1
> >
> > - sha1, md5, gpg sigs are good
Thank you all,
We need another PMC +1
Enrico
Il ven 26 gen 2018, 17:42 Ivan Kelly ha scritto:
> +1
>
> - sha1, md5, gpg sigs are good
> - NOTICE and LICENSE are "good"
> - src passes rat, spotbugs, unit tests pass eventually
> - binary package and maven repo jar passed a run