Here it is the patch
Please Sijie take a look.
I would like to restore Coveralls before releasing 4.8
Thanks
Enrico
Il giorno mar 24 lug 2018 alle ore 20:10 Enrico Olivelli <
eolive...@gmail.com> ha scritto:
>
>
> Il mar 24 lug 2018, 18:00 Venkateswara Rao Jujjuri ha
> scritto:
>
>> I don't
Il mar 24 lug 2018, 18:00 Venkateswara Rao Jujjuri ha
scritto:
> I don't see bookkeeper-server in the https://coveralls.io/builds/17501203
> report. Rest looks almost identical.
> That must be causing the overall drop.
>
Thank you.
I have an idea, that change introduced a specific
I don't see bookkeeper-server in the https://coveralls.io/builds/17501203
report. Rest looks almost identical.
That must be causing the overall drop.
On Tue, Jul 24, 2018 at 8:20 AM, Enrico Olivelli
wrote:
> Hi,
> In June, the 14th, code coverage dropped
>
> here: 72%
>
Hi,
In June, the 14th, code coverage dropped
here: 72%
https://coveralls.io/builds/17447847
here: 54%
https://coveralls.io/builds/17501203
This commit seems the cause (as reported by Coveralls.io)
https://github.com/apache/bookkeeper/commit/c5a36219bbb7cfce343137bf3c361f7eb80bd64e
Anyone has
Il giorno mar 24 lug 2018 alle ore 13:38 Enrico Olivelli <
eolive...@gmail.com> ha scritto:
>
>
> Il mar 24 lug 2018, 10:49 Sijie Guo ha scritto:
>
>> On Tue, Jul 24, 2018 at 12:32 AM Enrico Olivelli
>> wrote:
>>
>> > Il giorno mar 24 lug 2018 alle ore 09:25 Sijie Guo
>> ha
>> > scritto:
>> >
On Tue, Jul 24, 2018 at 12:32 AM Enrico Olivelli
wrote:
> Il giorno mar 24 lug 2018 alle ore 09:25 Sijie Guo ha
> scritto:
>
> > I am not sure need this configuration.
> >
> > based on my understanding, if we are using `${sha1}`, jenkins will use
> > Github's tentative merge of the compare and
Il giorno mar 24 lug 2018 alle ore 09:25 Sijie Guo ha
scritto:
> I am not sure need this configuration.
>
> based on my understanding, if we are using `${sha1}`, jenkins will use
> Github's tentative merge of the compare and base branches (e.g.
> refs/pull//merge) if the PR can be automatically
I am not sure need this configuration.
based on my understanding, if we are using `${sha1}`, jenkins will use
Github's tentative merge of the compare and base branches (e.g.
refs/pull//merge) if the PR can be automatically merged or
the head of the pull request (e.g. refs/pull//head) if
they can
Hi,
I am surprised that in our pre-commit jobs on Jenkins we are not merging
the Pull Request Branch with current master before running all tests/checks.
Ideally we have to simulate the final status of the repository after
merging the branch to "master"
This can be simply achieved but adding an
