Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/issues/221
@reddycharan @sijie the close method of the factory is expected to be
called once.
I am OK with the fact that close methods should be idempotent too but if it
is possible it is better
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/220
@sijie awesome
I hope that "simple clients" in the future will be able to leverage such
powerful feature without having to add new "coordination services middlewares&q
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/80
@sijie do you have some cycle to go on with this issue ?
I apologize for being "annoying" on this topic
---
If your project is set up for it, you can reply to this email and have
Github user eolivelli closed the pull request at:
https://github.com/apache/bookkeeper/pull/214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/214
@kishorekasi I am closing this PR as the fix as been committed by @sijie
Thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/issues/198
@kishorekasi my error report was against an old version of the master.
I think that @merlimat suggestion is good. Can you give it a try?
---
If your project is set up for it, you can
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/206
@sijie I think that the readme file would be enough to start.
It is important to use actual version, the trunk, of jenkins job builder,
the latest released version is somehow buggy and does
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/217
@sigee I will be happy to have the checkstyle plugin on but we should
discuss on the d...@bookeeper.apache.org list about the rules to set up, maybe
you can start a new thread
---
If your
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/217
Thank you @sigee interesting proposal.
@sijie I think this patch could break some pending Pull Request
in general I am OK with this kind of patch but I think it would be better
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/206
@sijie I have tested the script on my companies Jenkins and it is working
as expected.
Do you want to try out locally ?
Actual configuration of the master job is
https
Github user eolivelli closed the issue at:
https://github.com/apache/bookkeeper/issues/212
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user eolivelli closed the pull request at:
https://github.com/apache/bookkeeper/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/213
this closes issue #212
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/80
@sijie I am going to use this improvement in order to make a necessary
change in order to support java9. I would like to make 4.5 runnable on java9 as
we are starting to test all of our apps
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/214
some errors from my logs:
org.apache.bookkeeper.test.TestBackwardCompat-output.txt:
```
io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/214
@kishorekasi with this fix on Jenkins and on my laptop the build crashes
during tests.
This never happens on actual master.
see
https://builds.apache.org/job/bookkeeper-precommit
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/183
@sijie for me this patch is OK, I don't know if other developers/committer
want to add other comments
@kishorekasi can you change the description of the PR which usually it
written
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/210
Some comments:
1) is it possible NOT to bundle all the implementations in
bookkeeper-server project ?
Or at least mark the dependencies as "provided" o "runtime
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/193
@athanatos can you change the title to "BOOKKEEPER-1098:
ZkUnderreplicationManager cache watcher"
our bot is binding comments to the wrong issue
---
If your project is set up f
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/193
@sijie I think this change can be merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/200
@sijie in
https://cwiki.apache.org/confluence/display/BOOKKEEPER/BP-9+-+Github+issues+for+Issue+Tracking
@jiazhai wrote "Always create an issue for a pull request" as @fpj
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/205
@sijie maybe you can change the description of the PR dropping the "Be sure
to do all of the following to help us incorporate your contribution" lines
---
If your project
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/192
@sijie for you is ok ? so that we can merge and start using it for new
issues/pr ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user eolivelli opened an issue:
https://github.com/apache/bookkeeper/issues/198
TestBackwardCompat.testCompat410 often fails due to
io.netty.util.IllegalReferenceCountException
The test is failing very often on Jenkins.
It is a bug related to Netty 4 buffers usage
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/issues/196
I am investigating.
I will be back soon with news
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/188
@reddycharan the patch is ok. I think @sijie will try merge current patch
list in the best order
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/189
@sijie as far as I can see the flag only adds an additional check on the
configuration and it does not affect the way we are going to calculate disk
space (which now it will be correct
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/183
Overall is ok,
but rat is failing and on jenkins one of the new tests failed, the mixed
cluster one
Can you fix it?
---
If your project is set up for it, you can reply
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/127
jenkins job crashed, I restarted it
https://builds.apache.org/job/bookkeeper-precommit-pullrequest/54/console
CI completed with 2 tests failures, I think they are not releated
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/81
sorry my comments are about #127, not this issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/81
CI complete with due tests failures, I think they are not releated to the
patch
Failed tests:
TestSpeculativeRead.testSpeculativeReadFirstReadCompleteIsOk:260
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/81
jenkins job crashed, I restarted it
https://builds.apache.org/job/bookkeeper-precommit-pullrequest/54/console
---
If your project is set up for it, you can reply to this email and have your
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/181
@sijie this patch has been reviewed and all previous commits have been
merged, can you rebase ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user eolivelli opened a pull request:
https://github.com/apache/bookkeeper/pull/185
BOOKKEEPER-1017 Create documentation for ZooKeeper ACLs
This is the documentation for ZooKeeper security and there is an intro
about security in general.
It is work-in-progress, I created
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/81
@sijie @jvrao @reddycharan
do you think we can proceed with this patch ? or is there any conflict with
new patches @reddycharan is going to push ?
---
If your project is set up
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/issues/184
another problem...how can we create release notes ?
maybe for 4.5.0 we should stay on JIRA as most of the issues are on that
system
---
If your project is set up for it, you can reply
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/issues/184
I am not expert of GitHub API and I am a python newbie, @Sijie I think
you created the actual script and maybe you be be able to edit is in
order to enhance it
I think
GitHub user eolivelli opened an issue:
https://github.com/apache/bookkeeper/issues/184
Support GitHub issues in bk-merge script
This issue is to support GitHub issues in bk-merge script as well as we are
doing with ASF JIRA.
---
If your project is set up for it, you
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/127
I am sorry @reddycharan but findbugs is still failing
[INFO] Boxing/unboxing to parse a primitive
org.apache.bookkeeper.bookie.BookieShell$LostBookieRecoveryDelayCmd.runCmd(CommandLine
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/180
@sijie I did a more deep review and it is all great for me.
Do you think it would be useful to add a test for readUnconfirmedEntries ?
Actually the implementation is shared
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/183
I wonder if we have to add some "stat" about SSL clients. Maybe we can
enhance this aspect in the future
---
If your project is set up for it, you can reply to this email and have
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/80
@sijie did you have time to take a look to this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/97
closing this PR in favour of #183 from @kishorekasi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user eolivelli closed the pull request at:
https://github.com/apache/bookkeeper/pull/97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/80
I just got into this interesting reading about fallocate
https://groups.google.com/forum/m/#!topic/mechanical-sympathy/UMrKt75yOmg
I am ok with the current patch and the jni approach
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/174
I did a review on code. It looks great.
All tests are passing.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/108
+1 for me. Thank you @reddycharan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/178
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/177
@sijie got it. Sorry. I will only proceed with reviews. Just wanted to help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/177
@sijie I have merged #176 maybe you will have to rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/168
Ok
Il gio 1 giu 2017, 22:35 Sijie Guo <notificati...@github.com> ha scritto:
> @eolivelli <https://github.com/eolivelli> @merlimat
> <https://github.c
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/168
Ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/176
@sijie did you tell that we should mark some other contributor for this
sequence of patches? Exact names?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/175
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/161
@sijie I will merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/145
@merlimat @jvrao new ideas ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/171
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/173
Sorry @sijie , While merging Rat reported an error, the new class
AlertStatsLogger does not have a good license header
---
If your project is set up for it, you can reply to this email
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/171
@sijie I assume that this improvements are the base for further commits
I am going to run tests and approve this
---
If your project is set up for it, you can reply to this email
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/164
@sijie I am going to merge this, I you are currently doing merges too I can
hold off
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/161
@sijie this PR needs rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/168
@sijie I am testing locally @merlimat patch for failed tests and I will
merge as soon as the tests are OK on my laptop (within max 30 minutes)
---
If your project is set up for it, you can
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/170
No I only changed master job not the one for prs.
I will check too asap
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/160
+1 still great.
I am going to merge, or @sijie are you merging?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/108
@reddycharan this patch has now some conflict,
can you rebase and address @sijie comments so that we can get this merged ?
---
If your project is set up for it, you can reply
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/160
@sijie can you rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/80
@sijie we can merge this patch and I will create a follow up jira for
redhat build support or we can merge my patch
Ok?
---
If your project is set up for it, you can reply to this email
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/issues/165
Done
I cannot close this issue, @bwsw can you close it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/issues/165
@sijie committed to staging website, see
https://issues.apache.org/jira/browse/BOOKKEEPER-1080
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/168
It sounds really interesting!
One question, can you use linux as os? Instead of mac.
Is there any reason for using mac?
---
If your project is set up for it, you can reply
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/issues/165
@sijie
we can add a link to the project here
http://bookkeeper.apache.org/docs/master/bookkeeperTutorial.html
after the reference to @ivankelly repository
https://github.com
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/issues/165
@sijie I will do as soon as possible
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/166
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/117
I have created a new PR, #166
@arvindkandhare you can close this PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user eolivelli opened a pull request:
https://github.com/apache/bookkeeper/pull/166
BOOKKEEPER-1010 Moving Guava to 20.0
This patch updates Guava to version 20.0 and shades it
You can merge this pull request into a Git repository by running:
$ git pull https
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/161
ping @jvrao
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/164
@sijie I have merged #163 but it seems that there is a conflict, can you
resolve it ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/issues/165
@bwsw awesome !
Thank you for sharing you work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/162
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/117
@sijie I think that my version of this patch is overll OK
@arvindkandhare I you want I can pick this issue and finish the details
---
If your project is set up for it, you can reply
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/159
+1 LTGM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/161
For me is +1
I am using stats loggers to get JMX stats too
@jvrao @merlimat @revans2 are you OK for dropping this ?
---
If your project is set up for it, you can reply
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/80
@jiazhai try to install package cmake then try again, maybe you will get
new errors, and you will need to install locally additional libraries
---
If your project is set up for it, you can
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/80
@sijie
I have pushed here a fix for builds on Fedora and Centos
can you pick up this commit too (if it sounds look good to you) ?
https://github.com/eolivelli/bookkeeper/tree
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/97
@kishorekasi this sounds great to me, I will close this PR once you open
yours
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/97
@sijie @jvrao @kishorekasi
I will wait for your ACK before starting the rebase I think I will not be
trivial
---
If your project is set up for it, you can reply to this email and have
GitHub user eolivelli opened a pull request:
https://github.com/apache/bookkeeper/pull/158
BOOKKEEPER-1070 bk-merge-pr.py use apache-rat:check goal
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eolivelli/bookkeeper BOOKKEEPER
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/117
@arvindkandhare seems that apache-rat:check is failing here
https://builds.apache.org/job/bookkeeper-master-git-pullrequest/384/
Failed to execute goal org.apache.rat:apache-rat-plugin
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/156
I was trying to merge, but FindBugs check failed,
@merlimat can you fix the warnings ?
```
[INFO] BugInstance size is 3
[INFO] Error size is 0
[INFO] Total bugs: 3
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/127
@reddycharan I have started a review.
All tests run without failures on my laptop (after rebasing to current
master)
Apache Rat check is OK
But I see the findbugs errors
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/152
Yes recently we removed a similar line due to findbugs warning
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/141
@jvrao we can add a configuration property for "fast shutdown".
IMHO I don't think that this change really impact bookies even in case of
graceful shutdown.
The pr
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/145
@jvrao I see your point.
In order to achieve this goal in my company we use error collectors which
gather error streams from the various machines (using Kafka/ElasticSearch and
so
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/138
@merlimat After checking out the latest commit I am able to run the full
test suite in 23min without errors
findbugs and rat are OK !
---
If your project is set up for it, you can reply
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/138
Sorry @merlimat I will checkout your latest changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/138
I am seeing this errors
{code}
Tests run: 120, Failures: 0, Errors: 44, Skipped: 0, Time elapsed: 64.802
sec <<< FAILURE! - in org.apache.bookkeeper.client.BookieRec
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/145
@jvrao @merlimat
IHMO In case of a failed bookie it is not good to spam logs with errors. It
is enough that the method returns an error code.
I am OK if you prefer to distinguish
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/141
@jvrao the main explanation is that we already call shutdownNow if the pool
does not end execution within 1 minute.
In my personal usecases I usually kill bookies (kill -9) and do
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/138
Great work @merlimat and @kishorekasi!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/144
@merlimat could you also include NetBeans files:
`/**/nb-configuration.xml`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
1 - 100 of 162 matches
Mail list logo
