[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15162955#comment-15162955
]
Hudson commented on BOOKKEEPER-879:
---
FAILURE: Integrated in bookkeeper-master #1296 (See
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159364#comment-15159364
]
Sijie Guo commented on BOOKKEEPER-879:
--
Thanks [~eolivelli] for the change and thanks [~fpj] for
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159355#comment-15159355
]
ASF GitHub Bot commented on BOOKKEEPER-879:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146488#comment-15146488
]
ASF GitHub Bot commented on BOOKKEEPER-879:
---
Github user fpj commented on the pull request:
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138463#comment-15138463
]
ASF GitHub Bot commented on BOOKKEEPER-879:
---
Github user sijie commented on the pull
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133124#comment-15133124
]
Enrico Olivelli commented on BOOKKEEPER-879:
Ok. I updated the pull request
> Record
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127944#comment-15127944
]
Enrico Olivelli commented on BOOKKEEPER-879:
I'm sorry, what do you mean with "Optional" ?
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127789#comment-15127789
]
ASF GitHub Bot commented on BOOKKEEPER-879:
---
Github user sijie commented on a diff in the
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124969#comment-15124969
]
ASF GitHub Bot commented on BOOKKEEPER-879:
---
Github user fpj commented on a diff in the pull
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124970#comment-15124970
]
ASF GitHub Bot commented on BOOKKEEPER-879:
---
Github user fpj commented on a diff in the pull
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105345#comment-15105345
]
Enrico Olivelli commented on BOOKKEEPER-879:
I updated the pull request
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097788#comment-15097788
]
Enrico Olivelli commented on BOOKKEEPER-879:
I have to change LedgerMetadata.parseConfig
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098352#comment-15098352
]
Sijie Guo commented on BOOKKEEPER-879:
--
[~eolivelli] This option 1 looks reasonable to me. Since
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052581#comment-15052581
]
Enrico Olivelli commented on BOOKKEEPER-879:
if we keep mtime inside LedgerMetadata, so
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052582#comment-15052582
]
Enrico Olivelli commented on BOOKKEEPER-879:
if we keep mtime inside LedgerMetadata, so
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053544#comment-15053544
]
Sijie Guo commented on BOOKKEEPER-879:
--
Let's focus on ctime right now. I could see ctime is
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035431#comment-15035431
]
Sijie Guo commented on BOOKKEEPER-879:
--
it would be not tight with the zookeeper details on
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15031636#comment-15031636
]
Enrico Olivelli commented on BOOKKEEPER-879:
Maybe be it would be
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027717#comment-15027717
]
Matteo Merli commented on BOOKKEEPER-879:
-
I have a couple of concerns on the pull request:
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025620#comment-15025620
]
Matteo Merli commented on BOOKKEEPER-879:
-
Ledger z-node already has a ctime that can be
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024918#comment-15024918
]
Sijie Guo commented on BOOKKEEPER-879:
--
[~eolivelli] that's cool.
re 1): maybe follow the
[
https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024930#comment-15024930
]
Venkateswararao Jujjuri commented on BOOKKEEPER-879:
+1 for ctime. :)
> Record
22 matches
Mail list logo
