Jenkins build is back to stable : brooklyn-master-build #586

See

Jenkins build became unstable: brooklyn-master-build #585

See

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r90568817 --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/rebind/RebindConfigInheritanceTest.java --- @@ -0,0 +1,145 @@ +/* + * Licensed t

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r90568746 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/xstream/ClassRenamingMapper.java --- @@ -42,7 +42,7 @@ public ClassRenamingMapper(Mapper

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r90567752 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -170,12 +306,88 @@ public String getConflictResolut

Re: [Proposal] Managing security groups using jclouds

Hi all, thanks for your replies. Richard Downer, Aled Sage, I agree with you about it looks a jclouds problem, but it looks it would be solved easily from Brooklyn. Aled Sage, I see your point about jclouds philosophy, jclouds allows a node (VM) to be deleted, but you should wait to the node w

Jenkins build is back to normal : brooklyn-server-master #376

See

Build failed in Jenkins: brooklyn-server-master #375

See Changes: [aled.sage] SshMachineLocationTest: make non-integration [aled.sage] BROOKLYN-405: ssh doesn't log password environment variables [aled.sage] SshMachineLocationIntegrationTest: change unreachable ip ---

[GitHub] brooklyn-server pull request #473: Test framework: avoid repeated stacktrace...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/473 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server issue #473: Test framework: avoid repeated stacktrace loggin...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/473 Thanks @grkvlt - I've changed the declaration of `Task task` as suggested. I haven't changed to use `try (...)` for closing the `LogWatcher` (we certainly could use that java 7 idiom, b

[jira] [Commented] (BROOKLYN-405) Passwords in environment variables logged by brooklyn.SSH debug

[ https://issues.apache.org/jira/browse/BROOKLYN-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712348#comment-15712348 ] ASF GitHub Bot commented on BROOKLYN-405: - Github user asfgit closed the pull re

[GitHub] brooklyn-server pull request #475: BROOKLYN-405: ssh doesn't log password en...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/475 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server pull request #473: Test framework: avoid repeated stacktrace...

Github user grkvlt commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/473#discussion_r90473445 --- Diff: test-framework/src/test/java/org/apache/brooklyn/test/framework/TestSensorTest.java --- @@ -332,6 +343,56 @@ public void testFailFastIfNoSe

[GitHub] brooklyn-server pull request #473: Test framework: avoid repeated stacktrace...

Github user grkvlt commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/473#discussion_r90475367 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/repeat/Repeater.java --- @@ -334,8 +335,14 @@ public void runRequiringTrue() {

[GitHub] brooklyn-server pull request #473: Test framework: avoid repeated stacktrace...

Github user grkvlt commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/473#discussion_r90474345 --- Diff: test-framework/src/test/java/org/apache/brooklyn/test/framework/TestSensorTest.java --- @@ -332,6 +343,56 @@ public void testFailFastIfNoSe

[GitHub] brooklyn-server pull request #473: Test framework: avoid repeated stacktrace...

Github user grkvlt commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/473#discussion_r90474128 --- Diff: test-framework/src/test/java/org/apache/brooklyn/test/framework/TestSensorTest.java --- @@ -332,6 +343,56 @@ public void testFailFastIfNoSe

[jira] [Commented] (BROOKLYN-405) Passwords in environment variables logged by brooklyn.SSH debug

[ https://issues.apache.org/jira/browse/BROOKLYN-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712326#comment-15712326 ] ASF GitHub Bot commented on BROOKLYN-405: - Github user aledsage commented on a d

[GitHub] brooklyn-server pull request #475: BROOKLYN-405: ssh doesn't log password en...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/475#discussion_r90475467 --- Diff: core/src/test/java/org/apache/brooklyn/location/ssh/SshMachineLocationIntegrationTest.java --- @@ -19,53 +19,206 @@ package org.apac

[jira] [Commented] (BROOKLYN-405) Passwords in environment variables logged by brooklyn.SSH debug

[ https://issues.apache.org/jira/browse/BROOKLYN-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712282#comment-15712282 ] ASF GitHub Bot commented on BROOKLYN-405: - Github user grkvlt commented on a dif

[GitHub] brooklyn-server pull request #475: BROOKLYN-405: ssh doesn't log password en...

Github user grkvlt commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/475#discussion_r90471366 --- Diff: core/src/test/java/org/apache/brooklyn/location/ssh/SshMachineLocationIntegrationTest.java --- @@ -19,53 +19,206 @@ package org.apache

Build failed in Jenkins: brooklyn-server-master #374

See Changes: [bostko] Revert "Replace MultimapSerializer with jackson-datatype-guava library" [bostko] Add API test for format of retrieved multimap sensor -- [...truncated 47857 lines...]

[GitHub] brooklyn-server pull request #471: add location details as sensors

Github user andreaturli closed the pull request at: https://github.com/apache/brooklyn-server/pull/471 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] brooklyn-server issue #471: add location details as sensors

Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-server/pull/471 thanks @geomacy @sam @ahgittin and @googlielmo for your feedbacks As the goal is purely to make the information available in the UI I think we should use the existing API and sho

[GitHub] brooklyn-server pull request #472: Revert 5377839: Replace MultimapSerialize...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/472 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-dist issue #63: Add manually created LICENSE file for Karaf distrib...

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-dist/pull/63 I've addressed the previous 'TODO' point in bullet 2 above about the extra jars, squashed and updated the PR. --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-server issue #472: Revert 5377839: Replace MultimapSerializer with ...

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/472 Test failure seems unrelated: ``` CleanOrphanedLocationsIntegrationTest.testCleanedCopiedPersistedState:167 CleanOrphanedLocationsIntegrationTest.testSelectionWithOrphanedLoca

Re: [Proposal] Managing security groups using jclouds

A "recycle bin" sounds like a nice solution to the problem. We could improve jclouds to clean up security groups but I believe having Brooklyn manage them is where we should be heading long term. The reason is that Brooklyn is starting to create security groups on its own (say through SharedLoc

Re: Brooklyn CLI vs curl

Andrea, Just tried it with latest build of Brooklyn (both br and dist). I get the following timings: real0m0.034s user0m0.006s sys 0m0.011s So seems it's context sensitive. Doing a wireshark capture and comparing the output for curl and br could help in pinpointing where the problem

Re: Brooklyn CLI vs curl

the CLI has felt a little bit slow at times. i had chalked it up to bad networking and it hasn't been a big issue. but if there are some easy optimisations which would noticeable improve user experience -- which andrea's timing data makes me think might be possible -- that would be nice! --a O

Re: [Proposal] Managing security groups using jclouds

This litter is irritating. On the other hand we don't want application stops to wait an arbitrarily long time for sec groups to become deletable. I'd love to switch to a model where location instances become entities. Security groups could also become part of that, and managed explicitly in the r

[GitHub] brooklyn-server issue #471: add location details as sensors

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/471 if the goal is purely to make the information available in the UI can't we use the existing API ? reading `/v1/applications/0001` gives you a block including `locations: [0002]`, y

[GitHub] brooklyn-server pull request #443: Adds maxConcurrentChildCommands parameter...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/443 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server issue #472: Revert 5377839: Replace MultimapSerializer with ...

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/472 Thanks @bostko. I'll wait for tests to pass and will merge it then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[jira] [Commented] (BROOKLYN-405) Passwords in environment variables logged by brooklyn.SSH debug

[ https://issues.apache.org/jira/browse/BROOKLYN-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711778#comment-15711778 ] Svetoslav Neykov commented on BROOKLYN-405: --- Related to https://issues.apache.

[GitHub] brooklyn-server issue #443: Adds maxConcurrentChildCommands parameter to Dyn...

Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/443 I'm going to merge this now. Happy to address any further comments separately. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] brooklyn-server issue #472: Revert 5377839: Replace MultimapSerializer with ...

Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/472 @ahgittin you are right, sorry. Changed the PR to be with `git revert`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] brooklyn-docs pull request #128: 0.10.0 release notes

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/128#discussion_r90431884 --- Diff: guide/misc/release-notes.md --- @@ -14,15 +14,121 @@ to Brooklyn's commercial users for funding much of this development. ### Ne

[jira] [Commented] (BROOKLYN-405) Passwords in environment variables logged by brooklyn.SSH debug

[ https://issues.apache.org/jira/browse/BROOKLYN-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711758#comment-15711758 ] ASF GitHub Bot commented on BROOKLYN-405: - GitHub user aledsage opened a pull re

[GitHub] brooklyn-server pull request #475: BROOKLYN-405: ssh doesn't log password en...

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/475 BROOKLYN-405: ssh doesn't log password environment variables First commit just tidies up tests (allowing more of them to run as unit tests). Second commit actually changes non-tes

[jira] [Created] (BROOKLYN-405) Passwords in environment variables logged by brooklyn.SSH debug

Aled Sage created BROOKLYN-405: -- Summary: Passwords in environment variables logged by brooklyn.SSH debug Key: BROOKLYN-405 URL: https://issues.apache.org/jira/browse/BROOKLYN-405 Project: Brooklyn

[GitHub] brooklyn-docs issue #128: 0.10.0 release notes

Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-docs/pull/128 P.S. I put together a really quick script for retrieving the PRs that were merged into brooklyn-server that may be useful the next time someone wants to write release notes: https://gist.gi

[GitHub] brooklyn-server pull request #474: Test sensor backoff to config

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/474 Test sensor backoff to config Please first review and merge https://github.com/apache/brooklyn-server/pull/473, which this builds on (then I'll rebase this PR). You can merge this pull r

[GitHub] brooklyn-server pull request #473: Test framework: avoid repeated stacktrace...

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/473 Test framework: avoid repeated stacktrace logging You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-server TestSensor

[GitHub] brooklyn-server issue #472: Revert 5377839: Replace MultimapSerializer with ...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/472 @bostko is there a reason you didn't `git revert` this? (looks like the commit is not a strict reversion as it adds new tests.) @neykov good summary of the problems. agree having

[GitHub] brooklyn-docs pull request #128: 0.10.0 release notes

GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-docs/pull/128 0.10.0 release notes Phew! You can merge this pull request into a Git repository by running: $ git pull https://github.com/sjcorbett/brooklyn-docs release-notes Alternatively you can

[GitHub] brooklyn-server pull request #472: Revert 5377839: Replace MultimapSerialize...

Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/472#discussion_r90429269 --- Diff: rest/rest-resources/src/test/java/org/apache/brooklyn/rest/util/json/BrooklynJacksonSerializerTest.java --- @@ -203,6 +204,14 @@ public voi

Re: Brooklyn CLI vs curl

hi Andrea, it's not something I'd noticed myself. `br` would be a bit slower than curl but it shouldn't be dramatic. I'll look into it, but it would be certainly good to hear others' experiences here? cheers Geoff On Thu, 1 Dec 2016 at 11:04 Andrea Turli wrote: > Hi team, > > I'm comparing

Brooklyn CLI vs curl

Hi team, I'm comparing br cli performance vs plain curl commands and this is some of the surprising results I'm seeing: $ time br app myApp entity myEntity sensor > /dev/null real0m3.833s user0m0.008s sys 0m0.010s and $ br login http://brooklyn:8081 user password $ time curl -s -u

[GitHub] brooklyn-server issue #471: add location details as sensors

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/471 @sjcorbett, agreed, - to tie some threads together I'll link @ahgittin's suggestion here https://github.com/apache/brooklyn-server/pull/300#issuecomment-262499059. I'd agree that doing it

[GitHub] brooklyn-server issue #472: Revert 5377839: Replace MultimapSerializer with ...

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/472 LGTM. Suggest rewriting the test as commented above. Then good to merge. I think this is good as a short term fix. Longer term would be nice to get the package back in, resolving the

[GitHub] brooklyn-server pull request #472: Revert 5377839: Replace MultimapSerialize...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/472#discussion_r90421382 --- Diff: rest/rest-server/src/test/java/org/apache/brooklyn/rest/entity/SensorsApiTest.java --- @@ -0,0 +1,64 @@ +/* + * Licensed to the Apa

Re: [Proposal] Managing security groups using jclouds

Note the PR "Factor security group code out into separate utility class" [1] from last week, might be of some use here, but it just provides a basic toolkit for security groups (not keys yet, but they could be added?). Factor out the functionality for security groups. Brings the create/de

[GitHub] brooklyn-server issue #471: add location details as sensors

Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/471 Another interim option would be to write an enricher that does the publication so its inclusion is up to the user. --- If your project is set up for it, you can reply to this email and ha

[GitHub] brooklyn-server issue #471: add location details as sensors

Github user googlielmo commented on the issue: https://github.com/apache/brooklyn-server/pull/471 I'd like to preserve the gist of @andreaturli's proposal. To address @ahgittin's comment, I propose that, instead of adding more sensors, we publish this information as additional prop