Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/908#issuecomment-141981274
Code looks good. Good to merge once asfbot says it passes.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/870#issuecomment-136320305
This is a better idea IMO than just adding anything which can be coerced to
an integer to the security group. Although we do need to keep an eye on
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/795#issuecomment-128778387
Merged. @mikezaccardo our normal process when there's a merge conflict with
master is to rebase the branch rather than merge master into it -
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/743#issuecomment-125157967
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/661#issuecomment-105923422
I think that Gson is a dependency of jclouds too. What version does jclouds
depend on? Are these two dependencies going to introduce a conflict
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/650#discussion_r31115419
--- Diff: docs/guide/yaml/winrm/re-authentication.md ---
@@ -0,0 +1,38 @@
+---
+title: Re-authenticating within a powershell
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/650#discussion_r31114432
--- Diff: docs/guide/yaml/winrm/index.md ---
@@ -0,0 +1,17 @@
+---
+title: Windows blueprints using WinRM
+layout: website
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/639#issuecomment-101647067
Please alter the commit message (not the PR message, although you could do
that too) to include documentation of this feature. Your example in the
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/639#discussion_r30224760
--- Diff:
locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1050,42 +1050,59 @@ public void apply
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/639#discussion_r30224198
--- Diff:
locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1050,42 +1050,59 @@ public void apply
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/639#discussion_r30223925
--- Diff:
locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1050,42 +1050,59 @@ public void apply
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/481#issuecomment-72432472
@andreaturli that's the same guidelines that I follow, and that was the
advice that @ahgittin alluded to! In fact I think it's worth pr
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/499#issuecomment-72431999
Embarrassing :flushed: your fix looks good. I'll shout up if I see a
problem in practice, but test coverage is good so I don't anticipate
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/476#issuecomment-72190609
Addressed review comments, and rebased on latest master for good luck.
@aledsage regarding your comment, sadly that property did not work
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/485#issuecomment-72004494
Merged. Does exactly what it says on the tin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/464#issuecomment-71859723
I'd be in favour of removing the non-Apache repos because that's the only
place the Apache Brooklyn will deploy to. If anyone (*cough*Cloud
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/460#issuecomment-71833560
Pushed a fix for the failing test. If the next test run passes, am I good
to merge this @sjcorbett @andreaturli ?
---
If your project is set up for
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/404#issuecomment-67380698
Looks OK to me, but I have not tested the svn deletion command. If you
have, then this is clear to merge. If you're unable to test at the m
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/404#discussion_r21997884
--- Diff: docs/README.md ---
@@ -206,9 +206,13 @@ You can then preview the public site of
[localhost:4000](http://localhost:4000
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/398#issuecomment-67349703
This is looking very good now and I'm prepared to say +1 for it to be
merged :+1:
---
If your project is set up for it, you can reply to
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/398#issuecomment-67339745
`./_build/build.sh test-both --serve` appears to be installing the wrong
index.html - it's got the "Brooklyn Website and Docs (dev bu
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/398#issuecomment-67327226
I've finished eyeballing the commits, happy with all the commits bar one
(767d3d1). I'll next proceed to look at the final version, test
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/385#issuecomment-66762038
Perfect. I will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/384#issuecomment-66761897
Umm, yeah that was rather stupid of me to not notice the PR builder
:flushed:
---
If your project is set up for it, you can reply to this email and
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/385#issuecomment-66759233
I've tried out these instructions and they worked well. There's a couple of
points which I think are worth making.
1. The comman
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/385#discussion_r21737819
--- Diff: docs/use/guide/management/index.md ---
@@ -207,7 +207,23 @@ If not using the web console, you can specify
During dev/test
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/384#issuecomment-66754682
"truely" should be spelled "truly", but since you didn't start that, I'll
not insist you change it! :neckbeard:
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/365#issuecomment-65097985
Thanks @grkvlt - I've rebased it and will now merge.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/365#issuecomment-65063040
Any comments on this PR? Would be good to get a decision either way and get
the release process moving again!
---
If your project is set up for it
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/360#discussion_r20931954
--- Diff:
utils/common/src/test/java/brooklyn/util/net/NetworkingUtilsTest.java ---
@@ -107,8 +107,11 @@ public void
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/360#issuecomment-64547266
:+1:
OK to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/301#issuecomment-61812320
Fix seems reasonable but from the sound of your description of the problem,
it's more like a workaround than a solution. I'm assuming it
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/299#issuecomment-61783992
Sandbox is part of the source release so needs to be considered the same
way as anything else.
It needs a full clearout, but that's a
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/295#issuecomment-61632528
I don't particularly like the qpid-test-plugin.jar workaround of hosting it
on developers.cloudsoftcorp.com, as at some point in the future it
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/275#issuecomment-60760317
Looks good. A couple of minor comments, and we need to wait for the PR
builder to tell success. After that, ready for merge.
---
If your project is
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/273#issuecomment-60574767
Looks good in principle, a couple of minor comments. Could you confirm if
the build failure is related or if it is a transient failure?
A
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/246#issuecomment-59228485
actually I'll wait for the PR builder to comment before I merge...
---
If your project is set up for it, you can reply to this email and have
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/246#issuecomment-59227999
:+1: merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/244#issuecomment-59197848
One comment about the documentation that needs a response. :+1: to all the
code changes.
---
If your project is set up for it, you can reply to
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/242#issuecomment-59026812
@neykov, #240 has been merged, if you want to rebase this PR against master.
---
If your project is set up for it, you can reply to this email and
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/240#issuecomment-59026703
Thanks, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/239#issuecomment-59017186
I'm happy with this too. Proceeding to merge. After checking with
@aledsage, decided that remaining comments are low priority and can be handle
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/237#discussion_r18778411
--- Diff:
software/base/src/main/java/brooklyn/entity/brooklynnode/BrooklynNode.java ---
@@ -73,7 +73,7
GitHub user richardcloudsoft opened a pull request:
https://github.com/apache/incubator-brooklyn-site/pull/14
Server install doc - fix broken curl command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/richardcloudsoft
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/224#issuecomment-58201930
I'm confused over the "simulation" changes. `SimulatedJBoss7Server` et al
are classes that I wasn't previously aware of and wh
GitHub user richardcloudsoft opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/220
Fix XsltTransformerTest on Windows
Hardcoded use of "\n" fails on Windows. Switch to use line.separator
property.
You can merge this pull request into a Git rep
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/212#issuecomment-57803734
Closing PR in favour of @ahgittin's investigation in #213.
---
If your project is set up for it, you can reply to this email and have your
Github user richardcloudsoft closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/212
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user richardcloudsoft opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/212
Investigate ServerReplacerTest failure. NOT FOR MERGE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/richardcloudsoft
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/208#issuecomment-57782038
This last failure is spurious - it's affected a few other PRs - I'm
investigating, but for this PR the failure can be ignored.
---
If yo
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/208#issuecomment-5562
After commit 3e8f386, Jenkins reported these failures:
SensorResourceTest.testSet:237 expected [204] but found [500
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/195#issuecomment-57775814
I think we can safely say that updating a documentation page did not cause
[ServiceReplacerTest to
fail](https://builds.apache.org/job/incubator
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/206#issuecomment-57626951
Hi @abayer, can you close this pull request please? We can't close it
ourselves except through merging it :anguished:
---
If your project is s
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/200#issuecomment-57491538
@aledsage, ready for re-review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/200#issuecomment-57487914
@aledsage, I'll make your suggested updates now.
---
If your project is set up for it, you can reply to this email and have your
reply appe
GitHub user richardcloudsoft opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/200
User guide: update to the Chef blueprint chapter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/richardcloudsoft
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/13#issuecomment-57439027
Pushed to website; should be visible shortly when the infra tools sync the
new content over.
---
If your project is set up for it, you can
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/13#issuecomment-57438571
Better :) merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/13#issuecomment-57180551
@sjcorbett, https://github.com/apache/incubator-brooklyn/pull/187 has been
merged which affects this PR. Could you either re-build these pages
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/191#issuecomment-57047076
Reviewed by visual inspection but not run; however there's nothing really
controversial here, so if the build is good then +1 to merging.
-
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/13#issuecomment-56835663
Hi Sam. Seems there's a bit of a problem with the generated HTML - the
previous version of these pages were manually patched after generati
GitHub user richardcloudsoft opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/187
Catalog pages fixes
Fixes the homepage link and the use of non-SSL `http` links
You can merge this pull request into a Git repository by running:
$ git pull https
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/171#issuecomment-56023737
Confirmed that the JNA library (and its companion 'platform' jar) are no
longer present in the Brooklyn binary build. Happy with the oth
GitHub user richardcloudsoft opened a pull request:
https://github.com/apache/incubator-brooklyn-site/pull/12
Fix jekyll server and other bits
Allows the `jekyll serve` command to work as expected in the default
configuration, _without_ breaking the behaviour of the existing build
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/9#issuecomment-55589728
Thanks Sam. Looks good; will merge this later on as part of a batch of
updates to the website.
Please note that if you modify the
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/10#issuecomment-55589002
Andrea, the scope of the JIRA issue is to add a *new* page to the
`documentation` tree that explains how to do a server install. This is
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/10#discussion_r17540484
--- Diff: quickstart/install.md ---
@@ -0,0 +1,117 @@
+---
+layout: normal
+title: Install Apache Brooklyn®
GitHub user richardcloudsoft opened a pull request:
https://github.com/apache/incubator-brooklyn-site/pull/8
Integrate links to the catalog from the front page
Change some of the text on the front page to link to the new entity catalog
page (interim step to getting the catalog page
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/6#issuecomment-54989293
Thanks for the PR Andrea - sorry that I have had to make quite a few
comments on it. It seems to be performing several different changes
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/6#discussion_r17307779
--- Diff: quickstart/index.md ---
@@ -1,179 +1,34 @@
---
-title: Getting Started
layout: normal
-children
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/6#discussion_r17307455
--- Diff: quickstart/index.md ---
@@ -1,179 +1,34 @@
---
-title: Getting Started
layout: normal
-children
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/6#discussion_r17307272
--- Diff: quickstart/index.md ---
@@ -1,179 +1,34 @@
---
-title: Getting Started
layout: normal
-children
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/6#discussion_r17307149
--- Diff: quickstart/install.md ---
@@ -0,0 +1,86 @@
+---
+layout: normal
+title: Install Apache Brooklyn®
+permalink
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/6#discussion_r17307177
--- Diff: quickstart/tutorial.md ---
@@ -0,0 +1,133 @@
+---
+title: Tutorial
+layout: normal
+children:
+- { path
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/6#discussion_r17307108
--- Diff: what-is-brooklyn.md ---
@@ -1,6 +1,7 @@
---
layout: normal
-title: Learn More
+title: What is Brooklyn
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/6#discussion_r17306533
--- Diff: index.md ---
@@ -63,8 +63,8 @@ View and modify using the *web console* or automate using
the *REST API
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/6#discussion_r17306767
--- Diff: quickstart/index.md ---
@@ -1,179 +1,34 @@
---
-title: Getting Started
layout: normal
-children
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/6#discussion_r17306290
--- Diff: index.md ---
@@ -3,13 +3,13 @@ layout: homepage
title: Home
navgroup: home
children:
-- { path
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/6#discussion_r17306018
--- Diff: index.md ---
@@ -3,13 +3,13 @@ layout: homepage
title: Home
navgroup: home
children:
-- { path
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/6#issuecomment-54978225
Can you split the content changes and the deployment script changes into
two different PRs please - they should not be related and need to be
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/128#issuecomment-54804544
Two minor comments:
* I'd prefer that the files added under usage/cli/src/main/resources/ are
moved into a subdirectory that is the sa
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/147#issuecomment-54621574
:+1:
Ran clean-build-test on location/jclouds, all OK. Merging now.
---
If your project is set up for it, you can reply to this email and have
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/142#issuecomment-54317078
BROOKLYN-60 is the issue for this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/142#issuecomment-54315552
On the transitive dependencies question, I'm OK with relaxing this. The
exercise I went through was useful to clarify our dependencies and wee
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/142#discussion_r17056955
--- Diff:
core/src/test/java/brooklyn/location/geo/HostGeoLookupIntegrationTest.java ---
@@ -56,4 +58,20 @@ public void testUtraceLookup
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/140#issuecomment-54184263
Thanks all. I have raised BROOKLYN-60 to add an integration for GeoIP v2.
I will proceed with merging this change now.
---
If your project is
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/140#issuecomment-54183371
@ahgittin, would you be prepared to accept this PR now (so we can resolve
the release blocker BROOKLYN-32), and we'll add MaxMind v2 later? Or d
GitHub user richardcloudsoft opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/140
BROOKLYN-32: remove LGPLed MaxMind GeoIP
Brooklyn `core` embeds a copy of MaxMind GeoIP Java library. This is
licensed under LGPL2.1, which is incompatible with the Apache
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/139#issuecomment-54152075
This covers JIRA BROOKLYN-53 (in part; persisting the location is not
considered)
-- for the record
---
If your project is set up for it, you
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/117#issuecomment-54078097
Can we do this *without* hacking files in `/dev`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/3#issuecomment-54077715
@ahgittin please feel free to put the image back, I wanted this to evolve!
The time for committee meetings about web design has ended, let's
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/4#issuecomment-54077359
@ahgittin, thanks for merging. I notice that you didn't do the [next step
to publish to the
website](https://github.com/apache/incu
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/127#issuecomment-53247816
@aledsage, this is looking good, but it now has merge conflicts. Could you
rebase? Then I'll run tests on the rebased version.
---
If your pr
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/4#issuecomment-52949456
Take a look at https://people.apache.org/~richard/ for a preview...
(community pages are the best example)
---
If your project is set up for it
GitHub user richardcloudsoft opened a pull request:
https://github.com/apache/incubator-brooklyn-site/pull/4
Add second-level menus and improve site structure handling
Second level menus appear both as drop-down menus on the top navbar, and on
the right side of pages.
You can
GitHub user richardcloudsoft opened a pull request:
https://github.com/apache/incubator-brooklyn-site/pull/3
Begin homepage rework and other minor changes
Actual HTML changes to turn the debate about the website homepage into
something real. Fork away and rip it to shreds
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/117#issuecomment-52497835
This whole idea of manipulating `/dev/random` to `/dev/urandom` is
something that has always made me feel uncomfortable, although I've kept
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/106#issuecomment-51202763
There's something not quite right in the history here. Prior to 'This
closes 99' is a commit by Aled, "JavaSoftwareProcessSshDriv
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/85#issuecomment-50760316
Comments addressed and rebased against master. Proceeding to merge.
---
If your project is set up for it, you can reply to this email and have your
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/85#issuecomment-50475810
@ahgittin: @aledsage's reasoning agrees with mine, with the added thought
if it's sometimes better to be explicit rather than implicit. T
1 - 100 of 130 matches
Mail list logo
