[GitHub] [incubator-brpc] Zheaoli opened a new issue #970: Build failed when build on MacOS 10.15

2019-11-19 Thread GitBox
Zheaoli opened a new issue #970: Build failed when build on MacOS 10.15 URL: https://github.com/apache/incubator-brpc/issues/970 **Describe the bug (描述bug)** When I try to build brpc on MacOS 10.15, the compiler throws multi errors like below: ```bash In file included

Re: [VOTE] Release Apache brpc(incubating) 0.9.7-rc01

2019-11-19 Thread tan zhongyi
Hi, von, thanks for your review, But I am not quite understanding your comments, please help me to verify, thanks 1. NOTICE, you said there is a slight problem, but where ? 2. Copyright for valgrind.h is in LICENSE, line 386, any problem for it? 3. we modified some files from chromium, which is

Re: [VOTE] Release Apache brpc(incubating) 0.9.7-rc01

2019-11-19 Thread Gosling Von
-1 asc and sha512 signature ok, but NOTICE and LICENSE seems to be a slight problem like the following. Some licenses listed in the LICESE doesn't match my checking path(src/butil/third_party/valgrind/valgrind.h, where is third_party in src tarball?). What’s more, why imported so many test

[GitHub] [incubator-brpc] aericpp commented on issue #968: https开启双向认证后,SSL Renegotiation功能失效

2019-11-19 Thread GitBox
aericpp commented on issue #968: https开启双向认证后,SSL Renegotiation功能失效 URL: https://github.com/apache/incubator-brpc/issues/968#issuecomment-555444971 > > > 由于之前一些SSL版本过低,renegotiation会引发安全问题,所以代码这里把这个关了 > > >