[GitHub] [incubator-brpc] jamesge commented on issue #994: Link to contributing page is invalid

2019-12-12 Thread GitBox
jamesge commented on issue #994: Link to contributing page is invalid URL: https://github.com/apache/incubator-brpc/issues/994#issuecomment-564896238 Do you have a screenshot? I don't know which link you're referring This is a

[GitHub] [incubator-brpc] ten2ton commented on issue #994: Link to contributing page is invalid

2019-12-12 Thread GitBox
ten2ton commented on issue #994: Link to contributing page is invalid URL: https://github.com/apache/incubator-brpc/issues/994#issuecomment-564899830 ---Original--- From: "Ge Jun"

[GitHub] [incubator-brpc] yockie opened a new issue #995: 能否支持过载时fastfail回调

2019-12-12 Thread GitBox
yockie opened a new issue #995: 能否支持过载时fastfail回调 URL: https://github.com/apache/incubator-brpc/issues/995 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** 我们的server期望加上限流功能,考虑使用brpc的自适应限流功能,减少测试工作量。但自适应限流目前超过最大并发度的请求会被拒绝(返回ELIMIT错误)。但我们期望超过最大并发度的请求可以回调我们提供的fastfail函数

[GitHub] [incubator-brpc] jamesge commented on issue #995: 能否支持过载时fastfail回调

2019-12-12 Thread GitBox
jamesge commented on issue #995: 能否支持过载时fastfail回调 URL: https://github.com/apache/incubator-brpc/issues/995#issuecomment-564925267 不知道我的理解是否准确,你们需要的是在触碰并发度上限时,给client端返回默认值(而不是失败),同时在server端打印错误日志? This is an automated message

[GitHub] [incubator-brpc] yockie commented on issue #995: 能否支持过载时fastfail回调

2019-12-12 Thread GitBox
yockie commented on issue #995: 能否支持过载时fastfail回调 URL: https://github.com/apache/incubator-brpc/issues/995#issuecomment-564926512 > 不知道我的理解是否准确,你们需要的是在触碰并发度上限时,给client端返回默认值(而不是失败),同时在server端打印错误日志? 嗯嗯,是的~ This is an au

[GitHub] [incubator-brpc] yockie commented on issue #995: 能否支持过载时fastfail回调

2019-12-12 Thread GitBox
yockie commented on issue #995: 能否支持过载时fastfail回调 URL: https://github.com/apache/incubator-brpc/issues/995#issuecomment-564926521 > 不知道我的理解是否准确,你们需要的是在触碰并发度上限时,给client端返回默认值(而不是失败),同时在server端打印错误日志? 嗯嗯,是的~ This is an au

[GitHub] [incubator-brpc] yockie removed a comment on issue #995: 能否支持过载时fastfail回调

2019-12-12 Thread GitBox
yockie removed a comment on issue #995: 能否支持过载时fastfail回调 URL: https://github.com/apache/incubator-brpc/issues/995#issuecomment-564926521 > 不知道我的理解是否准确,你们需要的是在触碰并发度上限时,给client端返回默认值(而不是失败),同时在server端打印错误日志? 嗯嗯,是的~ This

[GitHub] [incubator-brpc] jamesge commented on issue #995: 能否支持过载时fastfail回调

2019-12-12 Thread GitBox
jamesge commented on issue #995: 能否支持过载时fastfail回调 URL: https://github.com/apache/incubator-brpc/issues/995#issuecomment-564927619 这种情况下其实把max_concurrency关闭,自己在应用层做管理就行了,请求进来++,结束-- This is an automated message from the Apache

[GitHub] [incubator-brpc] yockie commented on issue #995: 能否支持过载时fastfail回调

2019-12-12 Thread GitBox
yockie commented on issue #995: 能否支持过载时fastfail回调 URL: https://github.com/apache/incubator-brpc/issues/995#issuecomment-564931686 ok,多谢老哥~ This is an automated message from the Apache Git Service. To respond to the message, pl

申请成为brpc committer

2019-12-12 Thread 牟盖东
hi,all 我是牟盖东, 来自爱奇艺广告部门,负责广告在线服务的架构。 2017年,我将brpc引入我们业务线,到2019年我们所有服务已经改造为基于brpc框架。期间,我提交过bug fix,并与2019年参加百度技术沙龙,分享brpc中熔断和限流的实现原理。 后面,希望能进一步参与brpc社区事务,参与代码review和宣传活动等。

committer 申请 -- 何磊

2019-12-12 Thread lhestz
Hi all: 我是何磊, 来自爱奇艺广告销售部,负责广告引擎基础架构的相关工作,github主页是 https://github.com/TousakaRin 。我们在17年引入了brpc,目前已经在所有的引擎后台服务应用。我们在爱奇艺内部维护了自己分支,并且会定期和社区同步代码,并将一些 feature 及 bug fix 推送到社区。期间我们为 brpc 贡献了consul名字服务、自动限流、单节点熔断,multi连接方式等功能,以及一些 bug fix。其中自动限流及单节点熔断功能均主要由我开发并且已经merge到master。 接下来我希望能够更进一步的参与

Re: 申请成为brpc committer

2019-12-12 Thread tan zhongyi
Welcome. I will translate it into English for better understanding, also. Here it is. " hello, I am Mou gaidong, from iqiyi advertising department, in charge of the structure of online advertising services. In 2017, I introduced brpc into our business line, and by 2019, all our services have

Re: 申请成为brpc committer

2019-12-12 Thread James Ge
+1 On Fri, Dec 13, 2019 at 10:57 AM tan zhongyi wrote: > Welcome. > > I will translate it into English for better understanding, also. > > Here it is. > > " hello, I am Mou gaidong, from iqiyi advertising department, > in charge of the structure of online advertising services. > > In 2017, I in

Re: vote to accept helei as committer

2019-12-12 Thread Bear Jiang
+1 On Thu, Dec 12, 2019 at 11:51 AM Zhangyi Chen wrote: > +1 > > On Thu, Dec 12, 2019 at 11:17 AM James Ge wrote: > > > +1 > > > > On Thu, Dec 12, 2019 at 11:12 AM JiashunZhu > > wrote: > > > > > +1. > > > > > > tan zhongyi 于2019年12月11日周三 下午11:26写道: > > > > > > > Hi, guys, > > > > > > > > Let

Re: 申请成为brpc committer

2019-12-12 Thread Bear Jiang
+1 On Fri, Dec 13, 2019 at 11:36 AM James Ge wrote: > +1 > > On Fri, Dec 13, 2019 at 10:57 AM tan zhongyi > wrote: > > > Welcome. > > > > I will translate it into English for better understanding, also. > > > > Here it is. > > > > " hello, I am Mou gaidong, from iqiyi advertising department, >

[GitHub] [incubator-brpc] Stupiddd opened a new issue #996: 多个bvar读值问题

2019-12-12 Thread GitBox
Stupiddd opened a new issue #996: 多个bvar读值问题 URL: https://github.com/apache/incubator-brpc/issues/996 你好,我在使用bvar的过程中遇到一些问题,我再程序中定义了多个bvar指标,在某个时间点去读值时发现在读值的过程中,多线程中仍然在给bvar写数据,这造成了我得到的数据不完全准确,请问该怎么解决。(我期望的是读值过程中这些bvar不能再写入数据) ---

[GitHub] [incubator-brpc] zgb40302 commented on issue #985: crash

2019-12-12 Thread GitBox
zgb40302 commented on issue #985: crash URL: https://github.com/apache/incubator-brpc/issues/985#issuecomment-565297679 1,asan 没有内存问题。 2,去掉 O2后,栈信息显示 operator() 的参数 obj=0x0,为啥还会core ? 35 template struct Destroyer { 36 void operator()(T* obj) const { if (obj) { obj->Destr

[GitHub] [incubator-brpc] zgb40302 edited a comment on issue #985: crash

2019-12-12 Thread GitBox
zgb40302 edited a comment on issue #985: crash URL: https://github.com/apache/incubator-brpc/issues/985#issuecomment-565297679 1,asan 没有内存问题。 2,去掉 O2后,用的是O1,栈信息显示 operator() 的参数 obj=0x0,为啥还会core ? 35 template struct Destroyer { 36 void operator()(T* obj) const { if (obj) { o

Re: 申请成为brpc committer

2019-12-12 Thread Zhangyi Chen
+1 On Fri, Dec 13, 2019 at 10:57 AM tan zhongyi wrote: > Welcome. > > I will translate it into English for better understanding, also. > > Here it is. > > " hello, I am Mou gaidong, from iqiyi advertising department, > in charge of the structure of online advertising services. > > In 2017, I in

[GitHub] [incubator-brpc] zgb40302 removed a comment on issue #985: crash

2019-12-12 Thread GitBox
zgb40302 removed a comment on issue #985: crash URL: https://github.com/apache/incubator-brpc/issues/985#issuecomment-562428619 线上环境,去掉-O2会影响性能。30多台设备,不是每台都有,所以应用代码的概率应该不大。 This is an automated message from the Apache Git Ser

[GitHub] [incubator-brpc] jamesge closed issue #995: 能否支持过载时fastfail回调

2019-12-12 Thread GitBox
jamesge closed issue #995: 能否支持过载时fastfail回调 URL: https://github.com/apache/incubator-brpc/issues/995 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR