Re: [VOTE] Release Apache brpc (Incubating) 1.2.0

2022-07-17 Thread He Lei
+1 (binding) I have checked: [x] Download links are valid. [x] Source code distributions have correct names matching the current release. [x] No compiled archives bundled in the source archive. Best regards, Lei He - To unsubsc

[GitHub] [incubator-brpc] chenBright commented on pull request #1817: fix additional refrerence can not release when socket is reviving

2022-07-17 Thread GitBox
chenBright commented on PR #1817: URL: https://github.com/apache/incubator-brpc/pull/1817#issuecomment-1186748873 @zyearn 麻烦也看看这个pr。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-brpc] chenBright commented on a diff in pull request #1814: fix ssl state exception coredump

2022-07-17 Thread GitBox
chenBright commented on code in PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r922961903 ## src/brpc/socket_map.cpp: ## @@ -301,6 +301,7 @@ void SocketMap::RemoveInternal(const SocketMapKey& key, _this_map_bvar = new bvar::PassiveS

[GitHub] [incubator-brpc] chenBright commented on a diff in pull request #1814: fix ssl state exception coredump

2022-07-17 Thread GitBox
chenBright commented on code in PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r922961903 ## src/brpc/socket_map.cpp: ## @@ -301,6 +301,7 @@ void SocketMap::RemoveInternal(const SocketMapKey& key, _this_map_bvar = new bvar::PassiveS

[GitHub] [incubator-brpc] chenBright commented on pull request #1814: fix ssl state exception coredump

2022-07-17 Thread GitBox
chenBright commented on PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#issuecomment-1186746706 > > > @chenBright 这个问题能不能通过在判断ssl_state和_ssl_session基础上解决呢?比如在DoWrite里 > > > ``` > > > current_ssl_session = _ssl_session > > > if (current_ssl_session == NULL) { > >

Re: [VOTE] Release Apache brpc (Incubating) 1.2.0

2022-07-17 Thread 牟盖东
+1 (binding) Lorin Lee 于2022年7月15日周五 22:15写道: > +1 (binding) > > I have checked: > > [x] Download links are valid. > [x] incubating in the name. > [x] Checksums and GPG signatures are valid. > [x] RELEASE_VERSION in the source code matches the current release. > [x] LICENSE and NOTICE files are

[GitHub] [incubator-brpc] wwbmmm closed issue #708: NamingService 初始化过多导致LOG(FATAL)

2022-07-17 Thread GitBox
wwbmmm closed issue #708: NamingService 初始化过多导致LOG(FATAL) URL: https://github.com/apache/incubator-brpc/issues/708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [incubator-brpc] wwbmmm commented on issue #708: NamingService 初始化过多导致LOG(FATAL)

2022-07-17 Thread GitBox
wwbmmm commented on issue #708: URL: https://github.com/apache/incubator-brpc/issues/708#issuecomment-1186693620 最新master已修复 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [incubator-brpc] wwbmmm commented on issue #502: DoublyBufferedData扩展性受限于_SC_THREAD_KEYS_MAX只能到1024

2022-07-17 Thread GitBox
wwbmmm commented on issue #502: URL: https://github.com/apache/incubator-brpc/issues/502#issuecomment-1186693302 > > > > 好的,感谢大佬,这个fix为啥不合并到master呢? 已合入master,可以试试 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[incubator-brpc] branch master updated: Fix DoublyBufferedData limits by _SC_THREAD_KEYS_MAX (#1838)

2022-07-17 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 583fe463 Fix DoublyBufferedData limits b

[GitHub] [incubator-brpc] wwbmmm closed issue #502: DoublyBufferedData扩展性受限于_SC_THREAD_KEYS_MAX只能到1024

2022-07-17 Thread GitBox
wwbmmm closed issue #502: DoublyBufferedData扩展性受限于_SC_THREAD_KEYS_MAX只能到1024 URL: https://github.com/apache/incubator-brpc/issues/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [incubator-brpc] wwbmmm merged pull request #1838: Fix DoublyBufferedData limits by _SC_THREAD_KEYS_MAX

2022-07-17 Thread GitBox
wwbmmm merged PR #1838: URL: https://github.com/apache/incubator-brpc/pull/1838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apa

[GitHub] [incubator-brpc] zyearn commented on pull request #1814: fix ssl state exception coredump

2022-07-17 Thread GitBox
zyearn commented on PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#issuecomment-1186602084 > ,该下游节点恢复 不会,HealthCheckTask持有一个引用,因为只有2个引用,rpc结束减1,HealthCheckTask结束减1,这时候socket就被回收了 -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-brpc] zyearn commented on pull request #1814: fix ssl state exception coredump

2022-07-17 Thread GitBox
zyearn commented on PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#issuecomment-1186601701 > > @chenBright 这个问题能不能通过在判断ssl_state和_ssl_session基础上解决呢?比如在DoWrite里 > > ``` > > current_ssl_session = _ssl_session > > if (current_ssl_session == NULL) { > >// necess

[GitHub] [incubator-brpc] zyearn commented on a diff in pull request #1814: fix ssl state exception coredump

2022-07-17 Thread GitBox
zyearn commented on code in PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r922891435 ## src/brpc/socket_map.cpp: ## @@ -301,6 +301,7 @@ void SocketMap::RemoveInternal(const SocketMapKey& key, _this_map_bvar = new bvar::PassiveStatu