zyearn commented on code in PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r922891435
##########
src/brpc/socket_map.cpp:
##########
@@ -301,6 +301,7 @@ void SocketMap::RemoveInternal(const SocketMapKey& key,
_this_map_bvar = new bvar::PassiveStatus<std::string>(
butil::StringPiece(namebuf, len), PrintSocketMap, this);
}
+ s->DisableHealthCheck(); // disable health check
Review Comment:
把这个变量名字改成_is_in_socket_map是不是更合适一些？
在WaitAndReset返回的时候判断一下这个值就知道等到的2个引用是不是预期的那2个引用了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
