Hi,
Since we have gotten more than 3+ +1 binding VOTES and the VOTE passed
72+ hours, I will close this and post the RESULT soon.
Thanks and regards,
Xiaofeng
On Wed, Feb 1, 2023 at 10:46 AM He Lei wrote:
>
> +1 binding
> I have checked:
>
> [x] Download links are valid.
> [x] Checksums and PGP
wasphin merged PR #129:
URL: https://github.com/apache/brpc-website/pull/129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache
wasphin commented on issue #2104:
URL: https://github.com/apache/brpc/issues/2104#issuecomment-1411485950
The 1.4.0 release, which is in the release process, contains the RDMA
feature and will be publicly available in the following few days.
--
This is an automated message from the Apache
cdjingit commented on code in PR #2102:
URL: https://github.com/apache/brpc/pull/2102#discussion_r1092730512
##
src/brpc/server.cpp:
##
@@ -642,6 +642,33 @@ int Server::InitializeOnce() {
return 0;
}
+int Server::InitALPNOptions(ServerSSLOptions* options) {
+if (opti
cdjingit commented on issue #2105:
URL: https://github.com/apache/brpc/issues/2105#issuecomment-1411425212
我理解ConcurrencyMaxer 需要在ConcurrencyWindow之后。另外如果ConcurrencyMaxer
不需要读取或expose，可以用WindowEx:
https://github.com/apache/brpc/blob/master/docs/cn/bvar_c%2B%2B.md#bvarwindowex
--
This is
cdjingit commented on code in PR #2102:
URL: https://github.com/apache/brpc/pull/2102#discussion_r1092736195
##
src/brpc/details/ssl_helper.cpp:
##
@@ -833,6 +874,23 @@ void Print(std::ostream& os, X509* cert, const char* sep) {
os << butil::StringPiece(bufp, len);
}
+st
cdjingit commented on code in PR #2102:
URL: https://github.com/apache/brpc/pull/2102#discussion_r1092734124
##
src/brpc/details/ssl_helper.cpp:
##
@@ -441,6 +441,42 @@ static int SetSSLOptions(SSL_CTX* ctx, const std::string&
ciphers,
return 0;
}
+static int ServerALPN
cdjingit commented on code in PR #2102:
URL: https://github.com/apache/brpc/pull/2102#discussion_r1092733973
##
src/brpc/details/ssl_helper.cpp:
##
@@ -441,6 +441,42 @@ static int SetSSLOptions(SSL_CTX* ctx, const std::string&
ciphers,
return 0;
}
+static int ServerALPN
cdjingit commented on code in PR #2102:
URL: https://github.com/apache/brpc/pull/2102#discussion_r1092733018
##
src/brpc/details/ssl_helper.cpp:
##
@@ -441,6 +441,42 @@ static int SetSSLOptions(SSL_CTX* ctx, const std::string&
ciphers,
return 0;
}
+static int ServerALPN
cdjingit commented on code in PR #2102:
URL: https://github.com/apache/brpc/pull/2102#discussion_r1092732331
##
src/brpc/details/ssl_helper.cpp:
##
@@ -470,6 +506,7 @@ SSL_CTX* CreateClientSSLContext(const ChannelSSLOptions&
options) {
SSL_CTX* CreateServerSSLContext(const std
cdjingit commented on code in PR #2102:
URL: https://github.com/apache/brpc/pull/2102#discussion_r1092731444
##
src/brpc/server.cpp:
##
@@ -1913,7 +1946,7 @@ int Server::AddCertificate(const CertInfo& cert) {
ssl_ctx.filters = cert.sni_filters;
ssl_ctx.ctx = std::make_
cdjingit commented on code in PR #2102:
URL: https://github.com/apache/brpc/pull/2102#discussion_r1092730512
##
src/brpc/server.cpp:
##
@@ -642,6 +642,33 @@ int Server::InitializeOnce() {
return 0;
}
+int Server::InitALPNOptions(ServerSSLOptions* options) {
+if (opti
cdjingit commented on code in PR #2102:
URL: https://github.com/apache/brpc/pull/2102#discussion_r1092728241
##
src/brpc/server.cpp:
##
@@ -642,6 +642,33 @@ int Server::InitializeOnce() {
return 0;
}
+int Server::InitALPNOptions(ServerSSLOptions* options) {
Review Comme
cdjingit commented on code in PR #2106:
URL: https://github.com/apache/brpc/pull/2106#discussion_r1092723022
##
src/brpc/policy/timeout_concurrency_limiter.cpp:
##
@@ -67,8 +67,9 @@ bool TimeoutConcurrencyLimiter::OnRequested(int
current_concurrency,
if (cntl != nullptr &&
+1 binding
I have checked:
[x] Download links are valid.
[x] Checksums and PGP signatures are correct.
[x] Source code distributions have correct names matching the current
release.
[x] LICENSE and NOTICE files are correct for each Apache bRPC repo.
[x] No compiled archives are bundled in the sour
yanglimingcn commented on PR #2106:
URL: https://github.com/apache/brpc/pull/2106#issuecomment-1411367126
done
> > 极端情况下average
latency可能会大于请求的timeout，校验在currency_concurrency是1的时候可以通过，这样能保证在average
latency大于请求的timeout的情况下，至少有一个请求可以被处理，这样average latency才能得到更新。
>
> 注释里说明一下？
wwbmmm commented on code in PR #2098:
URL: https://github.com/apache/brpc/pull/2098#discussion_r1092674319
##
src/brpc/socket.cpp:
##
@@ -590,6 +592,69 @@ int Socket::ResetFileDescriptor(int fd) {
return 0;
}
+void Socket::SetKeepalive(int fd) {
+if (!_keepalive_opti
wwbmmm commented on PR #2107:
URL: https://github.com/apache/brpc/pull/2107#issuecomment-1411332686
编译失败了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
chenBright opened a new pull request, #2107:
URL: https://github.com/apache/brpc/pull/2107
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed: 重载了一些函数，期望PtrContainer可以像std::unique_ptr一样可以直接操作指针。
wwbmmm commented on PR #2106:
URL: https://github.com/apache/brpc/pull/2106#issuecomment-1410238017
> 极端情况下average
latency可能会大于请求的timeout，校验在currency_concurrency是1的时候可以通过，这样能保证在average
latency大于请求的timeout的情况下，至少有一个请求可以被处理，这样average latency才能得到更新。
注释里说明一下？
--
This is an automated m
chenBright commented on code in PR #2098:
URL: https://github.com/apache/brpc/pull/2098#discussion_r1091834733
##
src/brpc/socket.cpp:
##
@@ -590,6 +592,69 @@ int Socket::ResetFileDescriptor(int fd) {
return 0;
}
+void Socket::SetKeepalive(int fd) {
+if (!_keepalive_
chenBright commented on code in PR #2098:
URL: https://github.com/apache/brpc/pull/2098#discussion_r1091834500
##
src/brpc/socket.cpp:
##
@@ -590,6 +592,69 @@ int Socket::ResetFileDescriptor(int fd) {
return 0;
}
+void Socket::SetKeepalive(int fd) {
+if (!_keepalive_
chenBright commented on code in PR #2098:
URL: https://github.com/apache/brpc/pull/2098#discussion_r1091834224
##
src/brpc/socket.cpp:
##
@@ -590,6 +592,69 @@ int Socket::ResetFileDescriptor(int fd) {
return 0;
}
+void Socket::SetKeepalive(int fd) {
Review Comment:
d
chenBright commented on code in PR #2098:
URL: https://github.com/apache/brpc/pull/2098#discussion_r1091833256
##
src/brpc/socket.h:
##
@@ -198,6 +212,31 @@ struct SocketOptions {
std::shared_ptr app_connect;
// The created socket will set parsing_context with this val
chenBright commented on code in PR #2098:
URL: https://github.com/apache/brpc/pull/2098#discussion_r1091833005
##
src/brpc/socket.h:
##
@@ -198,6 +212,31 @@ struct SocketOptions {
std::shared_ptr app_connect;
// The created socket will set parsing_context with this val
+1 binding
Best Regards,
James Ge
On Sun, Jan 29, 2023 at 5:22 PM Wang,Weibing wrote:
> > OK, besides these, is there anything else that needs highlight?
> #1958, #1990, #2041, #2057 these are also new features.
>
> Best regards
> Weibing
>
> On Sun, Jan 29, 2023 at 2:24 PM Wang Xiaofeng wrot
yanglimingcn opened a new pull request, #2106:
URL: https://github.com/apache/brpc/pull/2106
极端情况下average
latency可能会大于请求的timeout，校验在currency_concurrency是1的时候可以通过，这样能保证在average
latency大于请求的timeout的情况下，至少有一个请求可以被处理，这样average latency才能得到更新。
--
This is an automated message from the Apache Gi
chenBright opened a new issue, #2105:
URL: https://github.com/apache/brpc/issues/2105
```c++
typedef bvar::Maxer ConcurrencyMaxer;
typedef bvar::Window ConcurrencyWindow;
struct ConcurrencyBvar {
ConcurrencyBvar()
: concurrency_window("timer_task_concurrency", &conc
28 matches
Mail list logo
