Re: [PR] [feat] latency scale factor (brpc)

2024-06-03 Thread via GitHub
superhail commented on code in PR #2655: URL: https://github.com/apache/brpc/pull/2655#discussion_r1624632787 ## src/brpc/server.cpp: ## @@ -123,6 +123,8 @@ const int INITIAL_CERT_MAP = 64; // compilation units is undefined. const int s_ncore = sysconf(_SC_NPROCESSORS_ONLN);

Re: [I] 如何在requestMeta当中设置 traceId, parentSpanId, spanId? (brpc)

2024-06-03 Thread via GitHub
RagdollNoone commented on issue #2656: URL: https://github.com/apache/brpc/issues/2656#issuecomment-2145399067 目前的话 starlight框架 我读了些源码后 有了一定的思路 就是通过spi机制 创建新的filter 在filter当中 修改request的attachmentkv这个map 填充第三方生成的traceid spanid parentspanid 但是brpc框架该怎么操作? cpp不太会… 然后还有一点比较难受得是 traceid等字段在元数据当中

Re: [I] 如何在requestMeta当中设置 traceId, parentSpanId, spanId? (brpc)

2024-06-03 Thread via GitHub
RagdollNoone commented on issue #2656: URL: https://github.com/apache/brpc/issues/2656#issuecomment-2145380495 不太理解你说的意思 traceid等应该由第三方链路追踪框架生成 但是brpc和java进行分布式调用 需要传递这些值 这样链路追踪中间件才能收集信息 并且展示正确 回复的原邮件 | 发件人 | Weibing ***@***.***> | | 发送日期 | 2024年06月03日 16:37 | | 收件人

Re: [I] brpc异步server使用方式 (brpc)

2024-06-03 Thread via GitHub
wwbmmm commented on issue #2657: URL: https://github.com/apache/brpc/issues/2657#issuecomment-2145298662 > 好的,我想再确认一下您的建议: > > 1. SayHello中**直接调用** process_thread函数。 > 2. process_thread中也没有必要进行promise和future的操作。 > 3. TRITONSERVER_InferenceRequestSetResponseCallback中**捕获done,**,c

Re: [I] 动态设置"TCMALLOC_SAMPLE_PARAMETER"以支持动态开关pprof/heap采样 (brpc)

2024-06-03 Thread via GitHub
promoon commented on issue #2658: URL: https://github.com/apache/brpc/issues/2658#issuecomment-2144999473 @wwbmmm 明白了,看了下gperftools源码中是不支持动态设置的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [I] leveldb已经老旧化,是否考虑切到rocksdb (brpc)

2024-06-03 Thread via GitHub
corznoc commented on issue #2652: URL: https://github.com/apache/brpc/issues/2652#issuecomment-2144818861 好的,多谢。发自我的荣耀手机 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] brpc异步server使用方式 (brpc)

2024-06-03 Thread via GitHub
zhangyachen commented on issue #2657: URL: https://github.com/apache/brpc/issues/2657#issuecomment-2144667481 好的,我想再确认一下您的建议: 1. SayHello中**直接调用** process_thread函数。 2. process_thread中也没有必要进行promise和future的操作。 3. TRITONSERVER_InferenceRequestSetResponseCallback中**捕获done,**,callback收到

Re: [PR] Support thread local object iteration (brpc)

2024-06-03 Thread via GitHub
wwbmmm merged PR #2632: URL: https://github.com/apache/brpc/pull/2632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: Support thread local object iteration (#2632)

2024-06-03 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 02fd47ca Support thread local object iteration (#2

Re: [PR] Support proxy and generic call of baidu protocol (brpc)

2024-06-03 Thread via GitHub
wwbmmm commented on PR #2629: URL: https://github.com/apache/brpc/pull/2629#issuecomment-2144642932 @chenBright 这个也冲突了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

(brpc) branch master updated: Fix max concurrency of thrift protocol and nshead protocol (#2613)

2024-06-03 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 59a68dd6 Fix max concurrency of thrift protocol an

Re: [PR] Fix max concurrency of thrift protocol and nshead protocol (brpc)

2024-06-03 Thread via GitHub
wwbmmm merged PR #2613: URL: https://github.com/apache/brpc/pull/2613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: Support more meta for ServerNode (#2603)

2024-06-03 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new a0984f69 Support more meta for ServerNode (#2603)

Re: [PR] Support more meta for ServerNode (brpc)

2024-06-03 Thread via GitHub
wwbmmm merged PR #2603: URL: https://github.com/apache/brpc/pull/2603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

Re: [I] Naming server tag (brpc)

2024-06-03 Thread via GitHub
wwbmmm closed issue #850: Naming server tag URL: https://github.com/apache/brpc/issues/850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr.

(brpc) branch master updated: Reject http request without host (#2600)

2024-06-03 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new b7092a79 Reject http request without host (#2600)

Re: [PR] Reject http request without host (brpc)

2024-06-03 Thread via GitHub
wwbmmm merged PR #2600: URL: https://github.com/apache/brpc/pull/2600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: Support FastPthreadMutex contention profiler && expose FastPthreadMutex to user (#2589)

2024-06-03 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 3775b419 Support FastPthreadMutex contention profi

Re: [PR] Support FastPthreadMutex contention profiler && expose FastPthreadMutex to user (brpc)

2024-06-03 Thread via GitHub
wwbmmm merged PR #2589: URL: https://github.com/apache/brpc/pull/2589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

Re: [I] FastPthreadMutex 暴露到外边使用 (brpc)

2024-06-03 Thread via GitHub
wwbmmm closed issue #1354: FastPthreadMutex 暴露到外边使用 URL: https://github.com/apache/brpc/issues/1354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

Re: [PR] Fix invalid headers of multiple cookie and set-cookie (brpc)

2024-06-03 Thread via GitHub
wwbmmm merged PR #2577: URL: https://github.com/apache/brpc/pull/2577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

Re: [PR] Support connect on socket create (brpc)

2024-06-03 Thread via GitHub
wwbmmm commented on PR #2574: URL: https://github.com/apache/brpc/pull/2574#issuecomment-2144635581 @chenBright 又冲突了。。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

(brpc) branch master updated: Fix invalid headers of multiple cookie and set-cookie (#2577)

2024-06-03 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 4f85335d Fix invalid headers of multiple cookie an

Re: [I] brpc异步server使用方式 (brpc)

2024-06-03 Thread via GitHub
wwbmmm commented on issue #2657: URL: https://github.com/apache/brpc/issues/2657#issuecomment-2144632657 你通过future.get()的方式本质上还是阻塞当前线程来等待结果,那么使用异步接口就意义不大了。你可以不使用future.get(),而是在TRITONSERVER_InferenceRequestSetResponseCallback 设置的callback函数中调用done->Run()来发送回复。 这样的话,使用bthread_start_backgr

Re: [I] 动态设置"TCMALLOC_SAMPLE_PARAMETER"以支持动态开关pprof/heap采样 (brpc)

2024-06-03 Thread via GitHub
wwbmmm commented on issue #2658: URL: https://github.com/apache/brpc/issues/2658#issuecomment-2144621453 这是tcmalloc库的行为,tcmalloc在启动时读取TCMALLOC_SAMPLE_PARAMETER环境变量,即使你后面修改了这个环境变量,也是不生效的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [I] 如何在requestMeta当中设置 traceId, parentSpanId, spanId? (brpc)

2024-06-03 Thread via GitHub
wwbmmm commented on issue #2656: URL: https://github.com/apache/brpc/issues/2656#issuecomment-2144615693 这些变量应该是框架设置的,用户不需要设置。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [feat] latency scale factor (brpc)

2024-06-03 Thread via GitHub
wwbmmm commented on code in PR #2655: URL: https://github.com/apache/brpc/pull/2655#discussion_r1624030452 ## src/brpc/server.cpp: ## @@ -123,6 +123,8 @@ const int INITIAL_CERT_MAP = 64; // compilation units is undefined. const int s_ncore = sysconf(_SC_NPROCESSORS_ONLN); +D

Re: [PR] EventDispatcher supports various IO types (brpc)

2024-06-03 Thread via GitHub
wwbmmm merged PR #2560: URL: https://github.com/apache/brpc/pull/2560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: EventDispatcher supports various IO types (#2560)

2024-06-03 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 122355a2 EventDispatcher supports various IO types

Re: [I] EventDispatcher支持不同类型fd (brpc)

2024-06-03 Thread via GitHub
wwbmmm closed issue #2381: EventDispatcher支持不同类型fd URL: https://github.com/apache/brpc/issues/2381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-u

Re: [I] leveldb已经老旧化,是否考虑切到rocksdb (brpc)

2024-06-03 Thread via GitHub
wwbmmm commented on issue #2652: URL: https://github.com/apache/brpc/issues/2652#issuecomment-2144591854 可以考虑抽象出一个存储接口,默认提供leveldb实现,如果用户有需要可以自己实现这个接口。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

(brpc) branch master updated: circuit breaker with half open state (#2634)

2024-06-03 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 976c588f circuit breaker with half open state (#26

Re: [PR] circuit breaker with half open state (brpc)

2024-06-03 Thread via GitHub
wwbmmm merged PR #2634: URL: https://github.com/apache/brpc/pull/2634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

Re: [PR] remove old rpcz directory even if program crash (brpc)

2024-06-03 Thread via GitHub
wwbmmm commented on PR #2610: URL: https://github.com/apache/brpc/pull/2610#issuecomment-2144584435 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[I] 动态设置"TCMALLOC_SAMPLE_PARAMETER"以支持动态开关pprof/heap采样 (brpc)

2024-06-03 Thread via GitHub
promoon opened a new issue, #2658: URL: https://github.com/apache/brpc/issues/2658 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** pprof/heap 无法动态开启或关闭tcmalloc采样。 ``` bool has_TCMALLOC_SAMPLE_PARAMETER() { static bool val = check_TCMALLOC_SAMPLE_PARAME