ehds opened a new pull request, #2179:
URL: https://github.com/apache/brpc/pull/2179
### What problem does this PR solve?
Issue Number:https://github.com/apache/brpc/issues/1911
Problem Summary:
hostname maybe exceed to 64 bytes according to [RFC 1035 section
2.3.4](http://w
wwbmmm merged PR #2178:
URL: https://github.com/apache/brpc/pull/2178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
F
Huixxi commented on code in PR #2177:
URL: https://github.com/apache/brpc/pull/2177#discussion_r1148715423
##
test/brpc_channel_unittest.cpp:
##
@@ -1824,6 +1824,39 @@ class ChannelTest : public ::testing::Test{
MyEchoService _svc;
};
+void TestBlockServer(bool single_se
chenBright commented on code in PR #2177:
URL: https://github.com/apache/brpc/pull/2177#discussion_r1148731172
##
src/brpc/controller.cpp:
##
@@ -749,9 +780,8 @@ void Controller::Call::OnComplete(
// "single" streams are often maintained in a separate SocketMap and
jiangdongzi commented on issue #2142:
URL: https://github.com/apache/brpc/issues/2142#issuecomment-1484523189
> > 请问你那边开发到什么进度了？ 我这边已经实现了moved，但是在实现ASK时遇到了问题。能否交流下
>
> 可以参考下sougou的workflow, workflow 支持 异步redis cluster
简单看了下源码啊, 好像不支持smart client, 只是简单处理了MOVED ASK错误
--
This is
warriorpaw opened a new pull request, #2180:
URL: https://github.com/apache/brpc/pull/2180
OpenSSL does not guarantee that any of its objects can be used concurrently
by multiple threads:
https://github.com/openssl/openssl/issues/2165
https://github.com/openssl/openssl/issues/20446
netjia-cpu commented on issue #2146:
URL: https://github.com/apache/brpc/issues/2146#issuecomment-1485021340
>
请问“网络重启故障”具体是指什么呢？是如何注入的？我们也遇到了这个问题，client一直返回E112，直到重启才恢复，持续时间最长的client大约是40分钟。
就是执行 service network restart
--
This is an automated message from the Apache Git Service.
netjia-cpu commented on issue #2146:
URL: https://github.com/apache/brpc/issues/2146#issuecomment-1485037941
我升级到了brpc1.4版本，依然没有解决这个问题，不断注入网络故障：ifconfig down/up bond的一个口，又复现了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
netjia-cpu commented on issue #2146:
URL: https://github.com/apache/brpc/issues/2146#issuecomment-1485044876
这个问题对目前的业务影响很大，比较头疼。我想到的办法是：
1.放弃使用brpc，改用grpc，但是grpc没brpc好，c++的grpc太臃肿了
2.改源码，把Socket类改写掉，去掉那一堆复杂的原子计数，用最简单的方式实现
3.应用层规避，brpc持续出现这个错误码，进程就自杀（把channel delete掉，重连，不知道是否有效果）
-
netjia-cpu commented on issue #2146:
URL: https://github.com/apache/brpc/issues/2146#issuecomment-1485045065
这个问题对目前的业务影响很大，比较头疼。我想到的办法是：
1.放弃使用brpc，改用grpc，但是grpc没brpc好，c++的grpc太臃肿了
2.改源码，把Socket类改写掉，去掉那一堆复杂的原子计数，用最简单的方式实现
3.应用层规避，brpc持续出现这个错误码，进程就自杀（把channel delete掉，重连，不知道是否有效果）
-
netjia-cpu commented on issue #2146:
URL: https://github.com/apache/brpc/issues/2146#issuecomment-1485045503
这个问题对目前的业务影响很大，比较头疼。我想到的办法是：
1.放弃使用brpc，改用grpc，但是grpc没brpc好，c++的grpc太臃肿了
2.改源码，把Socket类改写掉，去掉那一堆复杂的原子计数，用最简单的方式实现
3.应用层规避，brpc持续出现这个错误码，进程就自杀（把channel delete掉，重连，不知道是否有效果）
-
chenBright opened a new pull request, #2181:
URL: https://github.com/apache/brpc/pull/2181
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects(性能影响):
qiuhuiming opened a new issue, #2182:
URL: https://github.com/apache/brpc/issues/2182
**Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)**
In some scenario, the task structures do not have copy constructor, but have
move constructor. In this case, we cannot use the `e
warriorpaw commented on issue #2172:
URL: https://github.com/apache/brpc/issues/2172#issuecomment-1485376483
增加--usercode_in_pthread=true参数再执行，asan的堆栈应该就是完整的，see:
https://github.com/google/sanitizers/issues/189 ,asan不支持swapcontext，但是
bthread就是基于swapcontext 实现的，usercode_in_pthread参数会让brpc在pt
kiminno opened a new pull request, #2183:
URL: https://github.com/apache/brpc/pull/2183
### What problem does this PR solve?
Issue Number: N/A
Problem Summary:
- A Travis CI build was last run 4 months ago, however, it is still
mentioned in the contributing guidelines. The n
wwbmmm merged PR #2181:
URL: https://github.com/apache/brpc/pull/2181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
F
wwbmmm merged PR #2183:
URL: https://github.com/apache/brpc/pull/2183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
F
zzjshaok commented on issue #2172:
URL: https://github.com/apache/brpc/issues/2172#issuecomment-1486093174
> 增加--usercode_in_pthread=true命令行参数再执行，asan的堆栈应该就是完整的，see:
[google/sanitizers#189](https://github.com/google/sanitizers/issues/189)
,asan不支持swapcontext，但是 bthread就是基于swapcontext
实现的，u
zzjshaok closed issue #2172:
使用asan检查程序内存时，brpc服务端函数内部的heap-use-after-free，无法提示内存被释放的完整堆栈
URL: https://github.com/apache/brpc/issues/2172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
wwbmmm commented on PR #2180:
URL: https://github.com/apache/brpc/pull/2180#issuecomment-1486094743
Does this affect performance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
wwbmmm merged PR #2179:
URL: https://github.com/apache/brpc/pull/2179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
F
wwbmmm commented on PR #2177:
URL: https://github.com/apache/brpc/pull/2177#issuecomment-1486096576
CI单测失败了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
jingshi-ant commented on PR #2180:
URL: https://github.com/apache/brpc/pull/2180#issuecomment-1486100599
> Does this affect performance?
about 20% slower in my 100w data set test. (mainly because of ssl enable. if
remove lock and enable ssl, the speed is almost the same with lock adde
Huixxi commented on code in PR #2177:
URL: https://github.com/apache/brpc/pull/2177#discussion_r1149950048
##
src/brpc/controller.cpp:
##
@@ -719,6 +719,37 @@ inline bool does_error_affect_main_socket(int error_code) {
error_code == EINVAL/*returned by connect "0.0.0.1"
Huixxi commented on PR #2177:
URL: https://github.com/apache/brpc/pull/2177#issuecomment-1486102286
> CI单测失败了
嗯嗯。。 我先在本地调试一下。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
wy1433 opened a new pull request, #2184:
URL: https://github.com/apache/brpc/pull/2184
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects(性能影响):
serverglen commented on PR #2184:
URL: https://github.com/apache/brpc/pull/2184#issuecomment-1486126613
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
wwbmmm merged PR #2184:
URL: https://github.com/apache/brpc/pull/2184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
F
serverglen commented on issue #2174:
URL: https://github.com/apache/brpc/issues/2174#issuecomment-1486129388
暂时没有计划，bRPC中的压缩算法是可扩展的，有兴趣的话欢迎给bRPC提交PR，可以参考snappy,zlib,gzip的视线。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
warriorpaw commented on PR #2180:
URL: https://github.com/apache/brpc/pull/2180#issuecomment-1486138968
> Does this affect performance?
Brpc already piped write requests by linked list and only one bthread calls
ssl_write.
In data reading, brpc use epoll in edge triggered mode
jiazhenjiang opened a new issue, #2185:
URL: https://github.com/apache/brpc/issues/2185
**Describe the bug (描述bug)**
通过postman以multipart/formdata格式发送文件到server
，文件内容只有一行 "this is a test file"
后端通过如下方式读出文件
int fd = open("./test", O_CREAT | O_WRONLY, 0666);
ssize_t size =
jinhuafeng- closed issue #2165: 能否支持四层请求接收真实的用户IP
URL: https://github.com/apache/brpc/issues/2165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-un
wayslog commented on issue #2142:
URL: https://github.com/apache/brpc/issues/2142#issuecomment-1487903812
> > > 请问你那边开发到什么进度了？ 我这边已经实现了moved，但是在实现ASK时遇到了问题。能否交流下
> >
> >
> > 可以参考下sougou的workflow, workflow 支持 异步redis cluster
>
> 简单看了下源码啊, 好像不支持smart client, 只是简单处理了MOVED ASK错误
hubble-insight commented on issue #780:
URL: https://github.com/apache/brpc/issues/780#issuecomment-1488024746
现在开源了吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
llwwjjj commented on issue #2001:
URL: https://github.com/apache/brpc/issues/2001#issuecomment-1488029530
触发了这条日志 +1，想知道这个日志是非预期的还是真的有问题？bug 有计划修复吗～
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jiangdongzi commented on issue #2142:
URL: https://github.com/apache/brpc/issues/2142#issuecomment-1488149408
> > > > 请问你那边开发到什么进度了？ 我这边已经实现了moved，但是在实现ASK时遇到了问题。能否交流下
> > >
> > >
> > > 可以参考下sougou的workflow, workflow 支持 异步redis cluster
> >
> >
> > 简单看了下源码啊, 好像不支持smart cl
FancyJan opened a new issue, #2186:
URL: https://github.com/apache/brpc/issues/2186
**Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)**
lalb在节点少的时候容易触发Fail to select server，可能与这个issue的部分触发条件一致
[https://github.com/apache/brpc/issues/699](url)
触发条件：SelectServer按照加权随机选择到了
wwbmmm commented on issue #2186:
URL: https://github.com/apache/brpc/issues/2186#issuecomment-1488309098
可以自定义 RetryPolicy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
wwbmmm commented on issue #2142:
URL: https://github.com/apache/brpc/issues/2142#issuecomment-1488311101
> redis专门定义一个retry_policy如何, 专门处理MOVED ASKING @wwbmmm
这也是一个思路
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
FancyJan commented on issue #2186:
URL: https://github.com/apache/brpc/issues/2186#issuecomment-1488480641
>
大佬的意思是实现一个RetryPolicy，然后这个RetryPolicy只对EHOSTDOWN做重试吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
wwbmmm commented on issue #2186:
URL: https://github.com/apache/brpc/issues/2186#issuecomment-1488555318
对
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
FancyJan closed issue #2186: Channel能否支持只重试SelectServer
URL: https://github.com/apache/brpc/issues/2186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jiangdongzi commented on issue #2142:
URL: https://github.com/apache/brpc/issues/2142#issuecomment-1489585288
> > > > > 请问你那边开发到什么进度了？ 我这边已经实现了moved，但是在实现ASK时遇到了问题。能否交流下
> > > >
> > > >
> > > > 可以参考下sougou的workflow, workflow 支持 异步redis cluster
> > >
> > >
> > > 简单看了下源码啊,
jiazhenjiang closed issue #2185:
使用brpc实现h2server时，通过postman以multipart/formdata格式发送文件到server端，server端无法正常读取
URL: https://github.com/apache/brpc/issues/2185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jiazhenjiang commented on issue #2185:
URL: https://github.com/apache/brpc/issues/2185#issuecomment-1489599370
已经有解决方案了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
jiangdongzi commented on issue #2142:
URL: https://github.com/apache/brpc/issues/2142#issuecomment-1489613134
> > 计算节点的时候，通过请求带的 request_code 来（request_code 应该由 RedisClusterRequest
自动计算填充，通过 CRC32/16384 计算）。
>
>
目前RedisRequest支持批量，但是多个批量请求的key可能hash到不同的server，而当前一次RPC过程会把请求都发到同一个serv
goldenbean opened a new pull request, #2187:
URL: https://github.com/apache/brpc/pull/2187
### What problem does this PR solve?
compile failed with error "error: macro "__has_attribute" requires an
identifier".
Issue Number:
Problem Summary:
### What is changed an
jiangdongzi commented on issue #2045:
URL: https://github.com/apache/brpc/issues/2045#issuecomment-1490110967
@wwbmmm 我想给brpc加上sentinel支持, 您有哪方面指导, 建议 或注意的点么
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
wwbmmm commented on issue #2045:
URL: https://github.com/apache/brpc/issues/2045#issuecomment-1490197931
> @wwbmmm 我想给brpc加上sentinel支持, 您有哪方面指导, 建议 或注意的点么
可以先建个issue，讨论一下需求场景，大概的使用方式
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
jiangdongzi opened a new issue, #2188:
URL: https://github.com/apache/brpc/issues/2188
brpc支持从redis sentinel获取redis server, 提高可用性
目前想到的是新增 NamingService, 可以是订阅频道的方式, 也可以是周期性获取的方式,
但是sentinel一般是ip/url:port的形式提供, 这样好像无法传入load_balancer, 同时也就无法使用naming_service?
我看只有有load_balancer时才用naming_s
chenBright commented on issue #2188:
URL: https://github.com/apache/brpc/issues/2188#issuecomment-1490505516
sentinel://ip/url:port这种形式吧，sentinel://对应redis sentinel的NamingService。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
wwbmmm merged PR #2187:
URL: https://github.com/apache/brpc/pull/2187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
F
jiangdongzi commented on issue #2188:
URL: https://github.com/apache/brpc/issues/2188#issuecomment-1491236903
> sentinel://ip/url:port这种形式吧，sentinel://对应redis sentinel的NamingService。
好主意
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
jiangdongzi commented on issue #2188:
URL: https://github.com/apache/brpc/issues/2188#issuecomment-1491320166
> sentinel://ip/url:port这种形式吧，sentinel://对应redis sentinel的NamingService。
这种只有一台server的, loadbalancer让用户传什么呢, 随便传就好?
--
This is an automated message from the Apache Git Servi
cooper-zhzhang commented on issue #2188:
URL: https://github.com/apache/brpc/issues/2188#issuecomment-1491344941
rc://127.0.0.1:6379
我目前的实现是这样传入的，rc是一个新的NamingService
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chenBright commented on issue #2188:
URL: https://github.com/apache/brpc/issues/2188#issuecomment-1491517083
> > sentinel://ip/url:port这种形式吧，sentinel://对应redis sentinel的NamingService。
>
> 这种只有一台server的, loadbalancer让用户传什么呢, 随便传就好?
lb都支持
--
This is an automated message from th
Flynn-Zh opened a new issue, #2189:
URL: https://github.com/apache/brpc/issues/2189
**Describe the bug (描述bug)**
使用 jmeter 压测 brpc server 的某个接口（200并发），持续10分钟，过程中使用中间使用 curl -i ip:port/rpcz
查看接口执行情况，curl 约 30s 返回，接口普遍延时很高（正常时是100ms级，此时是10s级），此时通过 gstack 查看 brpc server
堆栈如下：
..
.
Flynn-Zh commented on issue #2189:
URL: https://github.com/apache/brpc/issues/2189#issuecomment-1491540432
请问下，bthread_make_fcontext 之前的调用栈是什么？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jiangdongzi commented on issue #2188:
URL: https://github.com/apache/brpc/issues/2188#issuecomment-1491556008
>
没看明白? 就是随便传一个lb就可以了?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
santimont opened a new pull request, #2190:
URL: https://github.com/apache/brpc/pull/2190
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects(性能影响):
JennyJQ opened a new pull request, #2191:
URL: https://github.com/apache/brpc/pull/2191
This is the PR for the linter experiment to test all source files
It changes the `lines-changed-only:true` to `files-changed-only:false`
--
This is an automated message from the Apache Git Servic
JennyJQ closed pull request #2191: Linter experiment
URL: https://github.com/apache/brpc/pull/2191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-u
santimont closed pull request #2190: Refactor Repeated Instructions into Github
Actions
URL: https://github.com/apache/brpc/pull/2190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
tamim-khan opened a new pull request, #2192:
URL: https://github.com/apache/brpc/pull/2192
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects(性能影响):
tamim-khan closed pull request #2192: Create Bazel RBE Github Action
URL: https://github.com/apache/brpc/pull/2192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
chenBright commented on issue #2188:
URL: https://github.com/apache/brpc/issues/2188#issuecomment-1492836251
是的，只要按照NamingService的接口实现并注册了。框架的lb都是能支持的。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
leoncamel commented on issue #1363:
URL: https://github.com/apache/brpc/issues/1363#issuecomment-1493572721
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
Huixxi commented on issue #2146:
URL: https://github.com/apache/brpc/issues/2146#issuecomment-1495319116
> 这个问题对目前的业务影响很大，比较头疼。我想到的办法是： 1.放弃使用brpc，改用grpc，但是grpc没brpc好，c++的grpc太臃肿了
2.改源码，把Socket类改写掉，去掉那一堆复杂的原子计数，用最简单的方式实现 3.应用层规避，brpc持续出现这个错误码，进程就自杀（把channel
delete掉，重连，不知道是否有效果）
问下现在连
serverglen commented on PR #2137:
URL: https://github.com/apache/brpc/pull/2137#issuecomment-1495325800
LGTM
I think this PR can be merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
cmdmspaint opened a new issue, #2193:
URL: https://github.com/apache/brpc/issues/2193
项目中基于baidu-std协议应用了attachment技术，想咨询一下，brpc 中其他协议支持attachment吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Huixxi commented on issue #2193:
URL: https://github.com/apache/brpc/issues/2193#issuecomment-1495917958
除了std还有hulu协议支持。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
serverglen merged PR #137:
URL: https://github.com/apache/brpc-website/pull/137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apa
serverglen merged PR #138:
URL: https://github.com/apache/brpc-website/pull/138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apa
serverglen merged PR #139:
URL: https://github.com/apache/brpc-website/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apa
Huixxi closed issue #2193: brpc attachment 必须基于baidu-std协议吗？
URL: https://github.com/apache/brpc/issues/2193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
Huixxi commented on issue #2170:
URL: https://github.com/apache/brpc/issues/2170#issuecomment-1497464462
https://brpc.apache.org/zh/docs/benchmark/#%E5%90%8C%E6%9C%BA%E5%8D%95client%E5%8D%95server%E5%9C%A8%E5%9B%BA%E5%AE%9Aqps%E4%B8%8B%E7%9A%84%E5%BB%B6%E6%97%B6cdfbuiltin-servicesvars%E7%BB%
Huixxi closed issue #2170: 性能测试：同机单client→单server在固定QPS下的延时CDF（越左越好，越直越好）
URL: https://github.com/apache/brpc/issues/2170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
Huixxi commented on code in PR #2177:
URL: https://github.com/apache/brpc/pull/2177#discussion_r1159208682
##
test/brpc_socket_unittest.cpp:
##
@@ -608,11 +608,11 @@ TEST_F(SocketTest, app_level_health_check) {
for (int i = 0; i < 4; ++i) {
// although ::connect
Huixxi commented on code in PR #2177:
URL: https://github.com/apache/brpc/pull/2177#discussion_r1159208836
##
test/brpc_load_balancer_unittest.cpp:
##
@@ -1070,8 +1074,9 @@ TEST_F(LoadBalancerTest,
revived_from_all_failed_intergrated) {
// all servers are down, the very fi
leoncamel opened a new issue, #2194:
URL: https://github.com/apache/brpc/issues/2194
**Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)**
NO
**Describe the solution you'd like (描述你期望的解决方法)**
In the case we enable SSL, the common sense is we **force** every
leoncamel commented on issue #2194:
URL: https://github.com/apache/brpc/issues/2194#issuecomment-1498437289
As we investigate the function
[DetectSSLState](https://github.com/apache/brpc/blob/master/src/brpc/details/ssl_helper.cpp#L567),
it will auto-detect the first packet to enable SSL or
serverglen opened a new issue, #2195:
URL: https://github.com/apache/brpc/issues/2195
1. On Call已迁移至 brpc-website
2. brpc代码仓库下的community/oncall.md是不是可以删除了
3. 后续On Call可以提交到brpc/website仓库下，需要同时修改中文和英文文档
a.
中文地址：https://github.com/apache/brpc-website/blob/master/content/zh/docs/co
Huixxi commented on code in PR #136:
URL: https://github.com/apache/brpc-website/pull/136#discussion_r1158034351
##
content/zh/docs/blogs/sourcecodes/work_stealing_queue/index.md:
##
@@ -0,0 +1,90 @@
+---
+title: "bRPC源码解析·work_stealing_queue"
+linkTitle: "bRPC源码解析·work_stealing
yockie commented on issue #2120:
URL: https://github.com/apache/brpc/issues/2120#issuecomment-1498627455
mark，遇到相同的问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
wy1433 opened a new pull request, #2196:
URL: https://github.com/apache/brpc/pull/2196
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects(性能影响):
Huixxi commented on code in PR #2196:
URL: https://github.com/apache/brpc/pull/2196#discussion_r1159592942
##
src/butil/containers/flat_map.h:
##
@@ -416,7 +416,7 @@ struct DefaultHasher {
std::size_t operator()(const butil::StringPiece& s) const {
std::size_t resu
wy1433 closed pull request #2196: fix: remove an extra space
URL: https://github.com/apache/brpc/pull/2196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
wy1433 commented on code in PR #2196:
URL: https://github.com/apache/brpc/pull/2196#discussion_r1159601673
##
src/butil/containers/flat_map.h:
##
@@ -416,7 +416,7 @@ struct DefaultHasher {
std::size_t operator()(const butil::StringPiece& s) const {
std::size_t resu
Thunderbrook commented on code in PR #136:
URL: https://github.com/apache/brpc-website/pull/136#discussion_r1159899212
##
content/zh/docs/blogs/sourcecodes/work_stealing_queue/index.md:
##
@@ -0,0 +1,90 @@
+---
+title: "bRPC源码解析·work_stealing_queue"
+linkTitle: "bRPC源码解析·work_st
Huixxi merged PR #136:
URL: https://github.com/apache/brpc-website/pull/136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.
trevor211 commented on issue #2146:
URL: https://github.com/apache/brpc/issues/2146#issuecomment-1499812817
> 这个问题对目前的业务影响很大，比较头疼。我想到的办法是： 1.放弃使用brpc，改用grpc，但是grpc没brpc好，c++的grpc太臃肿了
2.改源码，把Socket类改写掉，去掉那一堆复杂的原子计数，用最简单的方式实现 3.应用层规避，brpc持续出现这个错误码，进程就自杀（把channel
delete掉，重连，不知道是否有效果）
第3
wwbmmm commented on issue #2146:
URL: https://github.com/apache/brpc/issues/2146#issuecomment-1499837221
>
> 第3点，应用层规避，这点应该解决不了问题，我们这边是每次都重新创建一个新的channel，但还是出现了这样的问题。
试试重建channel的时候，设置不同的ChannelOptions::connection_group
--
This is an automated message from the Apache Git Service
wy1433 opened a new pull request, #2197:
URL: https://github.com/apache/brpc/pull/2197
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects(性能影响):
netjia-cpu commented on issue #2146:
URL: https://github.com/apache/brpc/issues/2146#issuecomment-1499884991
> > 这个问题对目前的业务影响很大，比较头疼。我想到的办法是： 1.放弃使用brpc，改用grpc，但是grpc没brpc好，c++的grpc太臃肿了
2.改源码，把Socket类改写掉，去掉那一堆复杂的原子计数，用最简单的方式实现 3.应用层规避，brpc持续出现这个错误码，进程就自杀（把channel
delete掉，重连，不知道是否有效果）
>
xinyiZzz opened a new issue, #2198:
URL: https://github.com/apache/brpc/issues/2198
**Describe the bug (描述bug)**
I use brpc in my application. When I use UBSAN to compile my application, it
will crash. Other compilation methods are fine. But brpc compiles the same way
```
LDFLAG
Huixxi merged PR #140:
URL: https://github.com/apache/brpc-website/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.
Huixxi commented on issue #2198:
URL: https://github.com/apache/brpc/issues/2198#issuecomment-1501045608
It has already been fixed in doris, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Huixxi merged PR #2197:
URL: https://github.com/apache/brpc/pull/2197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
F
Huixxi commented on issue #2176:
URL: https://github.com/apache/brpc/issues/2176#issuecomment-1501049363
请问解决了么？看起来像是使用方式的问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Huixxi closed issue #2174: 是否有计划支持zstd压缩？
URL: https://github.com/apache/brpc/issues/2174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
501 - 600 of 1101 matches
Mail list logo
