[GitHub] [brpc-website] Huixxi merged pull request #141: update on call list

2023-04-09 Thread via GitHub
Huixxi merged PR #141: URL: https://github.com/apache/brpc-website/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.

[I] rdma performance test failed (brpc)

2023-04-09 Thread via GitHub
cldslnt opened a new issue, #2199: URL: https://github.com/apache/brpc/issues/2199 **Describe the bug (描述bug)** Client received `RPC call failed [E1008]Reached timeout=2000ms @10.0.1.142:8002` after handshake with server. **To Reproduce (复现方法)** just run test after compiling wit

Re: [I] rdma performance test failed (brpc)

2023-04-09 Thread via GitHub
Tuvie commented on issue #2199: URL: https://github.com/apache/brpc/issues/2199#issuecomment-1501432852 The GID index is 11. Can you run "show_gids" to check the GID table? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] rdma performance test failed (brpc)

2023-04-09 Thread via GitHub
cldslnt commented on issue #2199: URL: https://github.com/apache/brpc/issues/2199#issuecomment-1501455702 There are two VLAN under this bond interface, how can I choose which GID to use? I want to use GID 5 but client start with GID 9 in the following show_gids output. ``` mlx5_bond_0

Re: [I] rdma performance test failed (brpc)

2023-04-09 Thread via GitHub
cldslnt commented on issue #2199: URL: https://github.com/apache/brpc/issues/2199#issuecomment-1501458146 I found this config in rdma_helper.cpp `DEFINE_int32(rdma_gid_index, -1, "The GID index to use. -1 means using the last one.");`, and my test runs ok now. Thanks for help -- This is

Re: [I] rdma performance test failed (brpc)

2023-04-09 Thread via GitHub
Tuvie commented on issue #2199: URL: https://github.com/apache/brpc/issues/2199#issuecomment-1501465396 That's good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [I] rdma performance test failed (brpc)

2023-04-09 Thread via GitHub
Tuvie closed issue #2199: rdma performance test failed URL: https://github.com/apache/brpc/issues/2199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

Re: [I] 使用apisix作为网关, brpc作为grpc server, 只有链接的第一个请求可以成功, 后续报错终止链接 (brpc)

2023-04-10 Thread via GitHub
jiangdongzi commented on issue #2176: URL: https://github.com/apache/brpc/issues/2176#issuecomment-1501732253 > 请问解决了么?看起来像是使用方式的问题 还没, 直连没问题, 使用grpc作为server也没问题, 就是使用apisix作为grpc网关会出问题 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [I] 使用apisix作为网关, brpc作为grpc server, 只有链接的第一个请求可以成功, 后续报错终止链接 (brpc)

2023-04-10 Thread via GitHub
Huixxi commented on issue #2176: URL: https://github.com/apache/brpc/issues/2176#issuecomment-1501752959 > > 请问解决了么?看起来像是使用方式的问题 > > 还没, 直连没问题, 使用grpc作为server也没问题, 就是使用apisix作为grpc网关会出问题 网上似乎有个类似的case,感觉是apisix的问题😅 -- This is an automated message from the Apache Git Service.

[PR] Update project links (brpc)

2023-04-10 Thread via GitHub
wasphin opened a new pull request, #2200: URL: https://github.com/apache/brpc/pull/2200 ### What problem does this PR solve? Issue Number: NONE Problem Summary: - brpc/brpc -> apache/brpc ### What is changed and the side effects? Changed: - brpc/brpc

Re: [PR] Update project links (brpc)

2023-04-10 Thread via GitHub
wwbmmm merged PR #2200: URL: https://github.com/apache/brpc/pull/2200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

[PR] refactor: reduce code for operator[] of FlatMap (brpc)

2023-04-11 Thread via GitHub
wy1433 opened a new pull request, #2201: URL: https://github.com/apache/brpc/pull/2201 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: 精简FlatMap的operator[]函数的重复代码。 Side effects: - P

Re: [PR] refactor: reduce code for operator[] of FlatMap (brpc)

2023-04-11 Thread via GitHub
wy1433 closed pull request #2201: refactor: reduce code for operator[] of FlatMap URL: https://github.com/apache/brpc/pull/2201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] refactor: reduce code for operator[] of FlatMap (brpc)

2023-04-11 Thread via GitHub
wy1433 opened a new pull request, #2202: URL: https://github.com/apache/brpc/pull/2202 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: 精简FlatMap的operator[]函数的重复代码。 Side effects: - P

[I] 多次调用能使server用同一个线程处理么? (brpc)

2023-04-11 Thread via GitHub
Eviltuzki opened a new issue, #2203: URL: https://github.com/apache/brpc/issues/2203 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** 是否有办法使得server端处理client请求的时候,始终使用的是同一个线程,也就是调用bthread_self()返回的值保持不变 我这边现在有需求依赖上下文(是另外一个lib提供的),如果不同请求的线程切换了,上下文信息就丢失了,后续请求都会失败

Re: [I] 多次调用能使server用同一个线程处理么? (brpc)

2023-04-11 Thread via GitHub
ehds commented on issue #2203: URL: https://github.com/apache/brpc/issues/2203#issuecomment-1502936336 可以尝试开启 `usercode_in_pthread`, > 代码中广泛地使用pthread local传递session级别全局数据,在RPC前后均使用了相同的pthread local的数据,且数据有前后依赖性。比如在RPC前往pthread-local保存了一个值,RPC后又读出来希望和之前保存的相等,就会有问题。而像tcmalloc虽然也使用了pthread

Re: [I] brpc故障恢复bug (brpc)

2023-04-11 Thread via GitHub
netjia-cpu commented on issue #2146: URL: https://github.com/apache/brpc/issues/2146#issuecomment-1504379860 > > 第3点,应用层规避,这点应该解决不了问题,我们这边是每次都重新创建一个新的channel,但还是出现了这样的问题。 > > 试试重建channel的时候,设置不同的ChannelOptions::connection_group 这个方法有效,我用了后,没有再出了 -- This is an automated messag

Re: [I] brpc故障恢复bug (brpc)

2023-04-11 Thread via GitHub
trevor211 commented on issue #2146: URL: https://github.com/apache/brpc/issues/2146#issuecomment-1504489670 > 我升级到了brpc1.4版本,依然没有解决这个问题,不断注入网络故障:ifconfig down/up bond的一个口,又复现了 请问你们网络故障注入的具体流程是怎样的,每次网络注入故障多久后恢复? -- This is an automated message from the Apache Git Service. To respond

Re: [I] brpc故障恢复bug (brpc)

2023-04-11 Thread via GitHub
netjia-cpu commented on issue #2146: URL: https://github.com/apache/brpc/issues/2146#issuecomment-1504526525 > > 我升级到了brpc1.4版本,依然没有解决这个问题,不断注入网络故障:ifconfig down/up bond的一个口,又复现了 > > 请问你们网络故障注入的具体流程是怎样的,每次网络注入故障多久后恢复? 我们是bond4组网,ifconfig down/up bond的其中一个网口,注入故障10s内随机,一直循环10几个小时

[PR] Update iobuf.h (brpc)

2023-04-11 Thread via GitHub
20083017 opened a new pull request, #2204: URL: https://github.com/apache/brpc/pull/2204 ### What problem does this PR solve? fix word spell Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effec

Re: [I] brpc故障恢复bug (brpc)

2023-04-12 Thread via GitHub
trevor211 commented on issue #2146: URL: https://github.com/apache/brpc/issues/2146#issuecomment-1504796017 > > > 我升级到了brpc1.4版本,依然没有解决这个问题,不断注入网络故障:ifconfig down/up bond的一个口,又复现了 > > > > > > 请问你们网络故障注入的具体流程是怎样的,每次网络注入故障多久后恢复? > > 我们是bond4组网,ifconfig down/up bond的其中一个网口,注入故障

Re: [I] brpc故障恢复bug (brpc)

2023-04-12 Thread via GitHub
netjia-cpu commented on issue #2146: URL: https://github.com/apache/brpc/issues/2146#issuecomment-1504833117 > > > > 我升级到了brpc1.4版本,依然没有解决这个问题,不断注入网络故障:ifconfig down/up bond的一个口,又复现了 > > > > > > > > > 请问你们网络故障注入的具体流程是怎样的,每次网络注入故障多久后恢复? > > > > > > 我们是bond4组网,ifconfig dow

Re: [PR] Update iobuf.h (brpc)

2023-04-12 Thread via GitHub
serverglen merged PR #2204: URL: https://github.com/apache/brpc/pull/2204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.or

Re: [I] brpc故障恢复bug (brpc)

2023-04-12 Thread via GitHub
trevor211 commented on issue #2146: URL: https://github.com/apache/brpc/issues/2146#issuecomment-1505114580 > > > > > 我升级到了brpc1.4版本,依然没有解决这个问题,不断注入网络故障:ifconfig down/up bond的一个口,又复现了 > > > > > > > > > > > > 请问你们网络故障注入的具体流程是怎样的,每次网络注入故障多久后恢复? > > > > > > > > > 我们是bond4组网

[PR] bvar add is_hidden (brpc)

2023-04-12 Thread via GitHub
serverglen opened a new pull request, #2205: URL: https://github.com/apache/brpc/pull/2205 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):

Re: [PR] fix: remove an extra space (brpc)

2023-04-12 Thread via GitHub
wasphin commented on code in PR #2196: URL: https://github.com/apache/brpc/pull/2196#discussion_r1164798109 ## src/butil/containers/flat_map.h: ## @@ -416,7 +416,7 @@ struct DefaultHasher { std::size_t operator()(const butil::StringPiece& s) const { std::size_t res

Re: [I] brpc故障恢复bug (brpc)

2023-04-12 Thread via GitHub
netjia-cpu commented on issue #2146: URL: https://github.com/apache/brpc/issues/2146#issuecomment-1506190966 > > > > > > 我升级到了brpc1.4版本,依然没有解决这个问题,不断注入网络故障:ifconfig down/up bond的一个口,又复现了 > > > > > > > > > > > > > > > 请问你们网络故障注入的具体流程是怎样的,每次网络注入故障多久后恢复? > > > > > > > > > >

Re: [PR] bvar add is_hidden (brpc)

2023-04-12 Thread via GitHub
Huixxi merged PR #2205: URL: https://github.com/apache/brpc/pull/2205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

[PR] RdmaResource disallow copy and assign (brpc)

2023-04-12 Thread via GitHub
372046933 opened a new pull request, #2206: URL: https://github.com/apache/brpc/pull/2206 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):

Re: [I] 使用apisix作为网关, brpc作为grpc server, 只有链接的第一个请求可以成功, 后续报错终止链接 (brpc)

2023-04-12 Thread via GitHub
jiangdongzi commented on issue #2176: URL: https://github.com/apache/brpc/issues/2176#issuecomment-1506261478 > > > 请问解决了么?看起来像是使用方式的问题 > > > > > > 还没, 直连没问题, 使用grpc作为server也没问题, 就是使用apisix作为grpc网关会出问题 > > 网上似乎有个类似的case [https://github.com/Kong/kong/issues/8316,](https://gi

[PR] Add performance unittest of DoublyBufferedData (brpc)

2023-04-12 Thread via GitHub
chenBright opened a new pull request, #2207: URL: https://github.com/apache/brpc/pull/2207 ### What problem does this PR solve? Issue Number: Problem Summary: Add performance unittest of DoublyBufferedData ### What is changed and the side effects? Changed:

Re: [PR] Add performance unittest of DoublyBufferedData (brpc)

2023-04-12 Thread via GitHub
chenBright commented on PR #2207: URL: https://github.com/apache/brpc/pull/2207#issuecomment-1506280140 UT中起了一些pthread线程调用同一个DoublyBufferedData实例的Read函数,发现随着线程数的增加,Read的性能会下降了很多。下面是ci上跑的结果: ```shell [ RUN ] LoadBalancerTest.performance PROFILE: interrupts/evictions/bytes = 99/4

Re: [PR] Add performance unittest of DoublyBufferedData (brpc)

2023-04-12 Thread via GitHub
chenBright commented on PR #2207: URL: https://github.com/apache/brpc/pull/2207#issuecomment-1506285505 在我们自己的机器上测试,性能下降更加明显。 ```shell OS: Ubuntu 16.04 4.9.70-040970-generic Compiler: GCC 5.4.0 brpc: 1.3 ``` ```shell I0413 11:29:00.185243 {} 9458 1844674407370955

Re: [PR] Add performance unittest of DoublyBufferedData (brpc)

2023-04-12 Thread via GitHub
chenBright commented on PR #2207: URL: https://github.com/apache/brpc/pull/2207#issuecomment-1506295981 在自己机器上测试了每个pthread线程一个独立的pthread_mutex,只执行加锁解锁操作,性能下降的量级是一样的。 ```shell I0413 11:46:11.933795 {} 15638 18446744073709551615 brpc_doubly_buffered_data_unittest.cpp:414 [PerfTest]

[I] 这段代码有问题吗 (brpc)

2023-04-13 Thread via GitHub
jiangdongzi opened a new issue, #2208: URL: https://github.com/apache/brpc/issues/2208 ![image](https://user-images.githubusercontent.com/17529657/231682306-4cba9530-6f69-407c-813b-2638da3989b4.png) 切换到一个新bthread的时候, `saved_errno` 和 `saved_unique_user_ptr` 不是毫无意义的值么? 第一次运行时在下面重新赋值了毫无意义

Re: [I] 这段代码有问题吗 (brpc)

2023-04-13 Thread via GitHub
ehds commented on issue #2208: URL: https://github.com/apache/brpc/issues/2208#issuecomment-1506579232 jump_stack 会切换到其他 bthread 执行任务,上下文切换了,当执行到下面的逻辑,`saved_errno` 和 `saved_unique_user_ptr`已经发生了更改,需要重新赋值。 -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [I] 这段代码有问题吗 (brpc)

2023-04-13 Thread via GitHub
jiangdongzi commented on issue #2208: URL: https://github.com/apache/brpc/issues/2208#issuecomment-1506662433 > `jump_stack` 会切换到其他 bthread 执行任务,上下文切换了,当执行到下面的逻辑,`saved_errno` 和 `saved_unique_user_ptr`已经发生了更改,需要重新赋值。 我知道需要重新赋值, 我的意思是bthread首次运行, 那么在该bthread的栈里边还没有`saved_errno` 和 `sav

Re: [I] 这段代码有问题吗 (brpc)

2023-04-13 Thread via GitHub
jiangdongzi closed issue #2208: 这段代码有问题吗 URL: https://github.com/apache/brpc/issues/2208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...

Re: [I] 使用cmake依赖brpc编译成功,运行报undefined symbol: pthread_mutex_lock (brpc)

2023-04-14 Thread via GitHub
starrysky9959 commented on issue #1086: URL: https://github.com/apache/brpc/issues/1086#issuecomment-150803 ```bash ./mongodb/build/install/bin/mongod: symbol lookup error: /usr/lib/libbrpc.so: undefined symbol: pthread_mutex_lock ``` 用静态链接一切正常,用动态链接能通过编译链接,但一运行就出现上述报错。 -- Th

[I] 实现一种支持在查询逻辑中挂起bthread的新DBD数据结构 (brpc)

2023-04-16 Thread via GitHub
chenBright opened a new issue, #2209: URL: https://github.com/apache/brpc/issues/2209 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** > 我们需要写以某种形式和读同步,但读之间相互没竞争。一种解法是,读拿一把thread-local锁,写需要拿到所有的thread-local锁。具体过程如下: > > - 数据分前台和后台。 > - 读拿到自己所在线程的thread-local锁,

Re: [PR] Fix #2146 E112 EHOSTDOWN in short and pooled connection (brpc)

2023-04-16 Thread via GitHub
zyearn commented on code in PR #2177: URL: https://github.com/apache/brpc/pull/2177#discussion_r1167982737 ## src/brpc/controller.cpp: ## @@ -719,6 +719,37 @@ inline bool does_error_affect_main_socket(int error_code) { error_code == EINVAL/*returned by connect "0.0.0.1"

[PR] Feature: Server-end progressive reader for http protocol (brpc)

2023-04-16 Thread via GitHub
TangSiyang2001 opened a new pull request, #2210: URL: https://github.com/apache/brpc/pull/2210 ### What problem does this PR solve? Issue Number: #2145 Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects

Re: [PR] Feature: Server-end progressive reader for http protocol (brpc)

2023-04-16 Thread via GitHub
wwbmmm commented on code in PR #2210: URL: https://github.com/apache/brpc/pull/2210#discussion_r1168126757 ## src/brpc/details/http_message.h: ## @@ -82,6 +82,10 @@ class HttpMessage { bool read_body_progressively() const { return _read_body_progressively; } +void s

Re: [PR] Feature: Server-end progressive reader for http protocol (brpc)

2023-04-16 Thread via GitHub
TangSiyang2001 commented on code in PR #2210: URL: https://github.com/apache/brpc/pull/2210#discussion_r1168138986 ## src/brpc/policy/http_rpc_protocol.cpp: ## @@ -1545,6 +1549,26 @@ void ProcessHttpRequest(InputMessageBase *msg) { } else { // A http server, just k

Re: [PR] Mongo client support (brpc)

2023-04-16 Thread via GitHub
wwbmmm commented on code in PR #2171: URL: https://github.com/apache/brpc/pull/2171#discussion_r1168130775 ## CMakeLists.txt: ## @@ -152,6 +152,7 @@ endif() find_package(Protobuf REQUIRED) find_package(Threads REQUIRED) +find_package (bson-1.0 1.7 REQUIRED) Review Comment:

Re: [PR] Add performance unittest of DoublyBufferedData (brpc)

2023-04-16 Thread via GitHub
wwbmmm commented on code in PR #2207: URL: https://github.com/apache/brpc/pull/2207#discussion_r1168252993 ## test/brpc_load_balancer_unittest.cpp: ## @@ -1101,4 +1101,113 @@ TEST_F(LoadBalancerTest, la_selection_too_long) { ASSERT_EQ(EHOSTDOWN, lb.SelectServer(in, &out));

Re: [PR] refactor: reduce code for operator[] of FlatMap (brpc)

2023-04-17 Thread via GitHub
wwbmmm commented on PR #2202: URL: https://github.com/apache/brpc/pull/2202#issuecomment-1510815256 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Fix core when ssl is enabled (brpc)

2023-04-17 Thread via GitHub
wwbmmm commented on PR #2180: URL: https://github.com/apache/brpc/pull/2180#issuecomment-1510816717 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Fix #2146 E112 EHOSTDOWN in short and pooled connection (brpc)

2023-04-17 Thread via GitHub
wwbmmm commented on code in PR #2177: URL: https://github.com/apache/brpc/pull/2177#discussion_r1168292598 ## src/brpc/controller.cpp: ## @@ -719,6 +719,37 @@ inline bool does_error_affect_main_socket(int error_code) { error_code == EINVAL/*returned by connect "0.0.0.1"

Re: [PR] Fix #2146 E112 EHOSTDOWN in short and pooled connection (brpc)

2023-04-17 Thread via GitHub
wwbmmm commented on code in PR #2177: URL: https://github.com/apache/brpc/pull/2177#discussion_r1168294541 ## src/brpc/controller.cpp: ## @@ -1033,7 +1054,13 @@ void Controller::IssueRPC(int64_t start_realtime_us) { { start_realtime_us, true, has_requ

Re: [PR] Set http default method to "/" (brpc)

2023-04-17 Thread via GitHub
wwbmmm commented on PR #2168: URL: https://github.com/apache/brpc/pull/2168#issuecomment-1510847680 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [I] Redis cluster smart client support draft (brpc)

2023-04-17 Thread via GitHub
jiangdongzi commented on issue #2142: URL: https://github.com/apache/brpc/issues/2142#issuecomment-1510849628 @wayslog hi, 开发的怎么样了, 我可以协助一起开发 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] RdmaResource disallow copy and assign (brpc)

2023-04-17 Thread via GitHub
wwbmmm commented on PR #2206: URL: https://github.com/apache/brpc/pull/2206#issuecomment-1510854753 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Add performance unittest of DoublyBufferedData (brpc)

2023-04-17 Thread via GitHub
chenBright commented on code in PR #2207: URL: https://github.com/apache/brpc/pull/2207#discussion_r1168312352 ## test/brpc_load_balancer_unittest.cpp: ## @@ -1101,4 +1101,113 @@ TEST_F(LoadBalancerTest, la_selection_too_long) { ASSERT_EQ(EHOSTDOWN, lb.SelectServer(in, &out

Re: [I] 使用cmake依赖brpc编译成功,运行报undefined symbol: pthread_mutex_lock (brpc)

2023-04-17 Thread via GitHub
starrysky9959 commented on issue #1086: URL: https://github.com/apache/brpc/issues/1086#issuecomment-1510918042 感觉本质是因为brpc通过`dlsym(RTLD_NEXT, "pthread_mutex_lock");`hook了`libpthread`中的`pthread_mutex_lock`方法导致的. `RTLD_NEXT`意味着在load dynamic libraries时, `libpthread`必须在`libbrpc`之后被load, 且两者中间

Re: [PR] Fix #2146 E112 EHOSTDOWN in short and pooled connection (brpc)

2023-04-17 Thread via GitHub
Huixxi commented on code in PR #2177: URL: https://github.com/apache/brpc/pull/2177#discussion_r1168434516 ## src/brpc/controller.cpp: ## @@ -749,9 +780,8 @@ void Controller::Call::OnComplete( // "single" streams are often maintained in a separate SocketMap and

Re: [I] 实现一种支持在查询逻辑中挂起bthread的新DBD数据结构 (brpc)

2023-04-17 Thread via GitHub
wwbmmm commented on issue #2209: URL: https://github.com/apache/brpc/issues/2209#issuecomment-1511193631 是否可以把thread local的锁改成thread local的bthread::Mutex -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] 多次调用能使server用同一个线程处理么? (brpc)

2023-04-17 Thread via GitHub
wwbmmm commented on issue #2203: URL: https://github.com/apache/brpc/issues/2203#issuecomment-1511197353 可以把请求丢到bthread execution_queue去处理 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Support c++20 coroutine (brpc)

2023-04-17 Thread via GitHub
wwbmmm commented on PR #2121: URL: https://github.com/apache/brpc/pull/2121#issuecomment-1511201564 加了experimental命名空间 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[I] README h2 link is invalid (brpc)

2023-04-17 Thread via GitHub
Xiaoyao708 opened a new issue, #2211: URL: https://github.com/apache/brpc/issues/2211 **Describe the bug (描述bug)** README h2 link is invalid. **To Reproduce (复现方法)** Click on the h2 link, get 404 error code. **Expected behavior (期望行为)** Successfully visit h2 link for re

[PR] update h2 link in README and README_cn (brpc)

2023-04-17 Thread via GitHub
Xiaoyao708 opened a new pull request, #2212: URL: https://github.com/apache/brpc/pull/2212 ### What problem does this PR solve? Issue Number: #2211 Problem Summary: README h2 link is invalid ### What is changed and the side effects? Changed: Replace https://http2.g

Re: [I] 实现一种支持在查询逻辑中挂起bthread的新DBD数据结构 (brpc)

2023-04-17 Thread via GitHub
chenBright commented on issue #2209: URL: https://github.com/apache/brpc/issues/2209#issuecomment-1511518196 改成协程锁不太合适。thread local的线程锁是为了让不同线程之间的读无竞争的。如果换成了协程锁,某些情况下,对于同一个thread local的协程锁,会一直有竞争。例如,lb中使用了协程锁的实现,在更新实例信息时,读协程会被挂起,读协程被唤醒时可能被调度到其他worker线程。如果这些读协程比较多,则会跟后续的读协程形成竞争,导致后续的读协程被挂起,从而

Re: [I] 实现一种支持在查询逻辑中挂起bthread的新DBD数据结构 (brpc)

2023-04-17 Thread via GitHub
chenBright commented on issue #2209: URL: https://github.com/apache/brpc/issues/2209#issuecomment-1511535394 前面的方案对于写线程有一点比较友好:有一些读线程在写线程加锁前就看到了新前台,写线程不需要等这些读线程,只需要等那些还在读老前台的读线程就行了。原来的写线程需要等读线程读完才能获取到锁。 -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] update h2 link in README and README_cn (brpc)

2023-04-17 Thread via GitHub
wasphin commented on code in PR #2212: URL: https://github.com/apache/brpc/pull/2212#discussion_r1169361144 ## README.md: ## @@ -11,7 +11,7 @@ You can use it to: * Build a server that can talk in multiple protocols (**on same port**), or access all sorts of services - * re

Re: [PR] update h2 link in README and README_cn (brpc)

2023-04-17 Thread via GitHub
Xiaoyao708 commented on code in PR #2212: URL: https://github.com/apache/brpc/pull/2212#discussion_r1169423413 ## README.md: ## @@ -11,7 +11,7 @@ You can use it to: * Build a server that can talk in multiple protocols (**on same port**), or access all sorts of services - *

Re: [PR] update h2 link in README and README_cn (brpc)

2023-04-17 Thread via GitHub
Xiaoyao708 commented on code in PR #2212: URL: https://github.com/apache/brpc/pull/2212#discussion_r1169423724 ## README.md: ## @@ -11,7 +11,7 @@ You can use it to: * Build a server that can talk in multiple protocols (**on same port**), or access all sorts of services - *

Re: [PR] Add performance unittest of DoublyBufferedData (brpc)

2023-04-17 Thread via GitHub
chenBright commented on PR #2207: URL: https://github.com/apache/brpc/pull/2207#issuecomment-1512363650 增加了在读的过程中更新DoublyBufferedData的场景 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] update h2 link in README and README_cn (brpc)

2023-04-17 Thread via GitHub
wasphin merged PR #2212: URL: https://github.com/apache/brpc/pull/2212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

Re: [PR] update h2 link in README and README_cn (brpc)

2023-04-17 Thread via GitHub
wasphin commented on code in PR #2212: URL: https://github.com/apache/brpc/pull/2212#discussion_r1169475547 ## README.md: ## @@ -11,7 +11,7 @@ You can use it to: * Build a server that can talk in multiple protocols (**on same port**), or access all sorts of services - * re

Re: [PR] add avg latency for prometheus metrics (brpc)

2023-04-17 Thread via GitHub
Huixxi commented on PR #2024: URL: https://github.com/apache/brpc/pull/2024#issuecomment-1512494419 > 这个应该只是打印的时候多了一栏数值,名字是“avg”,具体的值是si->latency_avg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [I] Support TCP heartbeat to support the case that brpc client unaware of servers' down (brpc)

2023-04-18 Thread via GitHub
wumuzi520 commented on issue #1895: URL: https://github.com/apache/brpc/issues/1895#issuecomment-1512720109 如果Client和Server端有连接,但长时间没发送数据,Server端会主动关闭这个连接么? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Support TCP heartbeat to support the case that brpc client unaware of servers' down (brpc)

2023-04-18 Thread via GitHub
chenBright commented on issue #1895: URL: https://github.com/apache/brpc/issues/1895#issuecomment-1512761975 > 如果Client和Server端有连接,但长时间没发送数据(Server还活着),Server端会主动关闭这个连接么? brpc server支持关闭空闲连接 https://github.com/apache/brpc/blob/435b5120cb26992d0d7789d959e75135d72cb52e/src/brpc/serve

[GitHub] [brpc-website] Huixxi merged pull request #142: add didi into brpc users

2023-04-18 Thread via GitHub
Huixxi merged PR #142: URL: https://github.com/apache/brpc-website/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.

[GitHub] [brpc-website] Huixxi commented on pull request #143: fix issue #97

2023-04-18 Thread via GitHub
Huixxi commented on PR #143: URL: https://github.com/apache/brpc-website/pull/143#issuecomment-1513056943 #97 Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [brpc-website] Huixxi merged pull request #143: fix issue #97

2023-04-18 Thread via GitHub
Huixxi merged PR #143: URL: https://github.com/apache/brpc-website/pull/143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.

[GitHub] [brpc-website] Huixxi closed issue #97: 开始

2023-04-18 Thread via GitHub
Huixxi closed issue #97: 开始 URL: https://github.com/apache/brpc-website/issues/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.a

[I] RDMA coredump (brpc)

2023-04-18 Thread via GitHub
trevor211 opened a new issue, #2213: URL: https://github.com/apache/brpc/issues/2213 **Describe the bug (描述bug)** example/rdma_performance测试,client coredump。 https://user-images.githubusercontent.com/5462911/232948356-941f0854-2c18-415e-85c9-8a534b1def91.png";> **To Reproduce

Re: [I] README h2 link is invalid (brpc)

2023-04-18 Thread via GitHub
lorinlee closed issue #2211: README h2 link is invalid URL: https://github.com/apache/brpc/issues/2211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

Re: [I] bvar导致core (brpc)

2023-04-18 Thread via GitHub
haolujun commented on issue #2163: URL: https://github.com/apache/brpc/issues/2163#issuecomment-1514203735 > ![image](https://user-images.githubusercontent.com/11072802/225221450-c53c5853-2a52-4d06-8cb0-5e1c8847e6fe.png) 我这边也遇到类似问题。 不知道是不是一样的问题。 > > 集成的brpc版本是: brpc-0.9.7-rc05.tar.gz

Re: [I] Redis cluster smart client support draft (brpc)

2023-04-19 Thread via GitHub
jiangdongzi commented on issue #2142: URL: https://github.com/apache/brpc/issues/2142#issuecomment-1515631119 @wwbmmm @wayslog 又看了下draft, 感觉是不是不用定义新的PreHashLoadBalancer, 只是新定义 `ReplicaPolicy`即可 ![image](https://user-images.githubusercontent.com/17529657/233244575-f9401ebe-8124-4ac2-89dc

[I] 用brpc报free(): double free detected in tcache 2 (brpc)

2023-04-19 Thread via GitHub
trikker opened a new issue, #2214: URL: https://github.com/apache/brpc/issues/2214 **Describe the bug (描述bug)** 我们项目中用了0.9.7的brpc,代码是前同事写的,我在编译后运行的时候遇到了double free问题,报错如下,这个报错很奇怪,Succeeded to remove the node居然打印了2次, 但是Starts to remove timeout node只打了一次。 ``` E0329 19:17:15.66

[PR] add usercode thread pool for method (brpc)

2023-04-19 Thread via GitHub
yanglimingcn opened a new pull request, #2215: URL: https://github.com/apache/brpc/pull/2215 ### What problem does this PR solve? 1、应用不同接口的处理逻辑不尽相同,qps和延迟也不尽相同,很多时候我们想为某些接口预留一定的能力,比如heartbeat接口或者其它控制层面的接口。 2、应用有些接口延迟比较高,如果这些接口的请求比较多(超过worker数量)会导致其它请求的延迟增加,对于延迟敏感接口产生影响。因此需要将这些延迟高的接口独立出

Re: [PR] add usercode thread pool for method (brpc)

2023-04-19 Thread via GitHub
yanglimingcn commented on PR #2215: URL: https://github.com/apache/brpc/pull/2215#issuecomment-1515725562 @wwbmmm 有时间review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] RDMA coredump (brpc)

2023-04-19 Thread via GitHub
lorinlee commented on issue #2213: URL: https://github.com/apache/brpc/issues/2213#issuecomment-1515770240 这个问题辛苦 @Tuvie 帮忙看看哈 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[I] CHECK触发后不会终止程序 (brpc)

2023-04-19 Thread via GitHub
Gangbiao opened a new issue, #2216: URL: https://github.com/apache/brpc/issues/2216 **Describe the bug (描述bug)** CHECK触发后不会终止程序, **To Reproduce (复现方法)** 显示增加CHECK(0); **Expected behavior (期望行为)** 程序退出,并产生crush dump **Versions (各种版本)** OS: BigCloud Enterprise L

Re: [PR] Fix bug #1793 get_value core caused by the sampler thread start too early (brpc)

2023-04-20 Thread via GitHub
haolujun commented on PR #1863: URL: https://github.com/apache/brpc/pull/1863#issuecomment-1515868906 如何能保证sleep 10ms就能过解决问题呢?是否存在10ms都没有初始化的静态变量? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] bvar导致core (brpc)

2023-04-20 Thread via GitHub
haolujun commented on issue #2163: URL: https://github.com/apache/brpc/issues/2163#issuecomment-1515923944 debug 发现是core在了src/bvar/passive_status.h的get_value() 方法。官方给出的解决方法是:https://github.com/apache/brpc/commit/65b5fcdb2e74caeeae63a47f0674357ff4816efa 。 但是我这里依然会core。 -- This is an autom

Re: [I] RDMA coredump (brpc)

2023-04-20 Thread via GitHub
Tuvie commented on issue #2213: URL: https://github.com/apache/brpc/issues/2213#issuecomment-1515948620 这个故障注入的原理是什么?我通过所提供的脚本无法实现故障注入,仍然正常运行。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] RdmaResource disallow copy and assign (brpc)

2023-04-20 Thread via GitHub
372046933 commented on PR #2206: URL: https://github.com/apache/brpc/pull/2206#issuecomment-1516390901 @wwbmmm Can this PR be merge? The last commit 0db67815b98bd76d175cc95b0951d29093d17562 adds some log to IB verbs API. Found it very useful when debugging RDMA -- This is an automated me

Re: [I] RDMA coredump (brpc)

2023-04-20 Thread via GitHub
jiangzhuti commented on issue #2213: URL: https://github.com/apache/brpc/issues/2213#issuecomment-1517164672 > 这个故障注入的原理是什么?我通过所提供的脚本无法实现故障注入,仍然正常运行。 你好。这个脚本会关闭3队列网卡buffer,我们roce在3队列运行,关闭buffer后相当于主机侧rdma流量断开,用perftest打流测试表现为出现timeout cqe。我们通过这个脚本实现rdma的故障注入,并且不影响tcp协议 -- This is

Re: [PR] RdmaResource disallow copy and assign (brpc)

2023-04-20 Thread via GitHub
wwbmmm merged PR #2206: URL: https://github.com/apache/brpc/pull/2206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

Re: [I] 用brpc报free(): double free detected in tcache 2 (brpc)

2023-04-20 Thread via GitHub
lorinlee commented on issue #2214: URL: https://github.com/apache/brpc/issues/2214#issuecomment-1517230710 RemoveTimeoutNode 会不会业务上重复发起了多次,可以再加点日志确认下么?比如关键日志前面把bthread id也带上。另外release编译有使用RelWithDebInfo吗,或者带上-g -fno-omit-frame-pointer之类的参数试试,看ASAN的栈回溯不太完整,对象创建和double free的栈帧都有的话,问题更好查一点 -

Re: [I] 接口压测时 curl -i ip:port/rpcz 耗时 30s,gstack 查看 brpc 调用栈异常 (brpc)

2023-04-20 Thread via GitHub
lorinlee commented on issue #2189: URL: https://github.com/apache/brpc/issues/2189#issuecomment-1517234785 是enable了rpcz做压测吗,然后curl了下rpcz的接口,这时候curl很慢,然后其他query也受影响是么?现象是curl rpcz会导致普通query得延迟从100ms增长到10s? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [I] CHECK触发后不会终止程序 (brpc)

2023-04-20 Thread via GitHub
lorinlee commented on issue #2216: URL: https://github.com/apache/brpc/issues/2216#issuecomment-1517237161 有打开 -crash_on_fatal_log 这个flag吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] CHECK触发后不会终止程序 (brpc)

2023-04-20 Thread via GitHub
Gangbiao commented on issue #2216: URL: https://github.com/apache/brpc/issues/2216#issuecomment-1517340705 没有打开,默认的是FALSE,打开之后可以crush了,谢谢。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] 用brpc报free(): double free detected in tcache 2 (brpc)

2023-04-20 Thread via GitHub
trikker commented on issue #2214: URL: https://github.com/apache/brpc/issues/2214#issuecomment-1517349645 @lorinlee 是的,我也很想把ASAN的栈回溯打得完整些,但是我编译brpc时和编译我的项目时都用了-g -fno-omit-frame-pointer参数,也都用了RelWithDebInfo模式,都无法打出完整调用栈,还是显示下面的样子,请问我还要加哪些参数呢?把栈打完整了应该离真相就近了。 ``` 0x6030004f5ac0 is lo

Re: [I] CHECK触发后不会终止程序 (brpc)

2023-04-20 Thread via GitHub
lorinlee closed issue #2216: CHECK触发后不会终止程序 URL: https://github.com/apache/brpc/issues/2216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

[PR] Update gdb_bthread_stack.py (brpc)

2023-04-21 Thread via GitHub
AIxWall opened a new pull request, #2217: URL: https://github.com/apache/brpc/pull/2217 add "print all bthread frames" command ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side

[PR] Remove wordexp (brpc)

2023-04-21 Thread via GitHub
wwbmmm opened a new pull request, #2218: URL: https://github.com/apache/brpc/pull/2218 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):

Re: [PR] Remove wordexp (brpc)

2023-04-21 Thread via GitHub
lorinlee merged PR #2218: URL: https://github.com/apache/brpc/pull/2218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

<    2   3   4   5   6   7   8   9   10   11   >