[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r270436885 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,516 @@ +// Copyright

[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r270436885 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,516 @@ +// Copyright

[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r270414806 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,516 @@ +// Copyright

[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r270414806 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,516 @@ +// Copyright

[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r270414806 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,516 @@ +// Copyright

[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r270414806 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,516 @@ +// Copyright

[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r267283363 ## File path: src/brpc/socket.cpp ## @@ -1523,7 +1523,7 @@ int Socke