[GitHub] [incubator-brpc] zyearn commented on a diff in pull request #1814: fix ssl state exception coredump

2022-07-18 Thread GitBox
zyearn commented on code in PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r923810177 ## src/brpc/selective_channel.cpp: ## @@ -189,6 +189,7 @@ int ChannelBalancer::AddChannel(ChannelBase* sub_channel, SocketOptions options; options.user =

[GitHub] [incubator-brpc] zyearn commented on a diff in pull request #1814: fix ssl state exception coredump

2022-07-17 Thread GitBox
zyearn commented on code in PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r922891435 ## src/brpc/socket_map.cpp: ## @@ -301,6 +301,7 @@ void SocketMap::RemoveInternal(const SocketMapKey& key, _this_map_bvar = new bvar::PassiveStatu

[GitHub] [incubator-brpc] zyearn commented on a diff in pull request #1814: fix ssl state exception coredump

2022-07-04 Thread GitBox
zyearn commented on code in PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r913263559 ## src/brpc/socket_map.cpp: ## @@ -301,6 +301,7 @@ void SocketMap::RemoveInternal(const SocketMapKey& key, _this_map_bvar = new bvar::PassiveStatu

[GitHub] [incubator-brpc] zyearn commented on a diff in pull request #1814: fix ssl state exception coredump

2022-07-01 Thread GitBox
zyearn commented on code in PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r912206994 ## src/brpc/socket_map.cpp: ## @@ -301,6 +301,7 @@ void SocketMap::RemoveInternal(const SocketMapKey& key, _this_map_bvar = new bvar::PassiveStatu