zyearn commented on PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#issuecomment-1191925142
多谢贡献
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
zyearn commented on PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#issuecomment-1190187640
>
不管是来自于[SocketMap](https://github.com/apache/incubator-brpc/blob/master/src/brpc/socket_map.cpp#L247)还是selective_channel中的[_chan_map](https://github.com/apache/incubator-brpc/blob/m
zyearn commented on PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#issuecomment-1189559676
有一个问题：这个PR为什么会修改selective_channel？在socket_map.cpp中增删前设置in_socket_map是不是就足够了？
selective_channel里sub_channel中的Naming
service会在对端离开的时候通过SocketMapRemove将对端删除，从而间接影响selective_chann
zyearn commented on PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#issuecomment-1186602084
> ，该下游节点恢复
不会，HealthCheckTask持有一个引用，因为只有2个引用，rpc结束减1，HealthCheckTask结束减1，这时候socket就被回收了
--
This is an automated message from the Apache Git Service.
To respond to the messag
zyearn commented on PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#issuecomment-1186601701
> > @chenBright 这个问题能不能通过在判断ssl_state和_ssl_session基础上解决呢？比如在DoWrite里
> > ```
> > current_ssl_session = _ssl_session
> > if (current_ssl_session == NULL) {
> >// necess
zyearn commented on PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#issuecomment-1174382656
@chenBright 这个问题能不能通过在判断ssl_state和_ssl_session基础上解决呢？比如在DoWrite里
`
current_ssl_session = _ssl_session
if (current_ssl_session == NULL) {
// necessary comment
retu
zyearn commented on PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#issuecomment-1172661920
能不能把堆栈发一下？是不是core在了https://github.com/apache/incubator-brpc/blob/master/src/brpc/socket.cpp?#L1692？
--
This is an automated message from the Apache Git Service.
To respond to the
