[jira] [Created] (CALCITE-2878) Avoid use of new RuntimeException(e) in tests

2019-02-26 Thread Vladimir Sitnikov (JIRA)
Vladimir Sitnikov created CALCITE-2878: -- Summary: Avoid use of new RuntimeException(e) in tests Key: CALCITE-2878 URL: https://issues.apache.org/jira/browse/CALCITE-2878 Project: Calcite

[GitHub] asfgit merged pull request #1042: [CALCITE-2878] Avoid use of new RuntimeException(e) in tests

2019-02-26 Thread GitBox
asfgit merged pull request #1042: [CALCITE-2878] Avoid use of new RuntimeException(e) in tests URL: https://github.com/apache/calcite/pull/1042 This is an automated message from the Apache Git Service. To respond to the

[GitHub] vlsi commented on issue #1042: Avoid use of new RuntimeException(e) in tests

2019-02-26 Thread GitBox
vlsi commented on issue #1042: Avoid use of new RuntimeException(e) in tests URL: https://github.com/apache/calcite/pull/1042#issuecomment-467729795 @kgyrtkirk , oh, let me merge that. Apparently it received no objections.

[GitHub] julianhyde commented on issue #1055: [CALCITE-2855] Make RelOptCluster constructor public

2019-02-26 Thread GitBox
julianhyde commented on issue #1055: [CALCITE-2855] Make RelOptCluster constructor public URL: https://github.com/apache/calcite/pull/1055#issuecomment-467720535 Well, it's a bad idea for some other reasons that someone else raised.

[GitHub] chadasa opened a new pull request #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

2019-02-26 Thread GitBox
chadasa opened a new pull request #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071 [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

[jira] [Created] (CALCITE-2877) GeodeSchema change to make the constructor public to pass the client cahe directly

2019-02-26 Thread Sandeep Chada (JIRA)
Sandeep Chada created CALCITE-2877: -- Summary: GeodeSchema change to make the constructor public to pass the client cahe directly Key: CALCITE-2877 URL: https://issues.apache.org/jira/browse/CALCITE-2877

[GitHub] godfreyhe commented on issue #1055: [CALCITE-2855] Make RelOptCluster constructor public

2019-02-26 Thread GitBox
godfreyhe commented on issue #1055: [CALCITE-2855] Make RelOptCluster constructor public URL: https://github.com/apache/calcite/pull/1055#issuecomment-467701432 I had reverted some changes, only make non-deprecated constructor as public

[GitHub] XuQianJin-Stars commented on issue #1067: [CALCITE-2864]Add the JSON_DEPTH function

2019-02-26 Thread GitBox
XuQianJin-Stars commented on issue #1067: [CALCITE-2864]Add the JSON_DEPTH function URL: https://github.com/apache/calcite/pull/1067#issuecomment-467685627 hi @michaelmior I have already rebase that change and the others into a single commit. best qianjin

Re: Ordering table scans

2019-02-26 Thread Gopalakrishna Holla
Thank you for the pointers ! Will take a look On Fri, Feb 22, 2019 at 5:39 PM Walaa Eldin Moustafa wrote: > Also, since you are particularly interested in applying filters from > one table on another, that is actually a nested loops join rather than > a filter. Linq4j implementation has

Re: calcite does not support type implicit cast

2019-02-26 Thread Julian Hyde
You are correct. There is a JIRA case to add support for implicit casts, https://issues.apache.org/jira/browse/CALCITE-2302 . Julian > On Feb 25, 2019, at 10:12 PM, 宋之白(之白) wrote: > > > Hi >for current calcite master repo does not

Re: Supportin PostgreSQL OID casts

2019-02-26 Thread Julian Hyde
(Aside: I have so many problems with PostgreSQL’s “::” operator. It is not just a cast, or object-oriented. It is object-oriented as implemented by C++, circa 1995. Since C++ didn’t have gc, all of the object-oriented goodness was muddied with the demands of stack-based memory allocation,

calcite does not support type implicit cast

2019-02-26 Thread 宋之白(之白)
Hi for current calcite master repo does not support implicit type cast in validation, for example insert into emp values (1, 'nom', 'job', 0, timestamp '1970-01-01 00:00:00', 1, 1, 1, false) is OK for validator but insert into emp values (1, 'nom', 'job', 0,

Calcite-Master - Build # 1041 - Failure

2019-02-26 Thread Apache Jenkins Server
The Apache Jenkins build system has built Calcite-Master (build #1041) Status: Failure Check console output at https://builds.apache.org/job/Calcite-Master/1041/ to view the results.

[GitHub] beikov closed pull request #526: [CALCITE-1965] Support outer joins for materialized views

2019-02-26 Thread GitBox
beikov closed pull request #526: [CALCITE-1965] Support outer joins for materialized views URL: https://github.com/apache/calcite/pull/526 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] beikov commented on issue #526: [CALCITE-1965] Support outer joins for materialized views

2019-02-26 Thread GitBox
beikov commented on issue #526: [CALCITE-1965] Support outer joins for materialized views URL: https://github.com/apache/calcite/pull/526#issuecomment-467524517 Yeah, totally fine This is an automated message from the Apache

[GitHub] kgyrtkirk commented on issue #954: [CALCITE-2722] - SqlImplementor createLeftCall StackOverflowError fix

2019-02-26 Thread GitBox
kgyrtkirk commented on issue #954: [CALCITE-2722] - SqlImplementor createLeftCall StackOverflowError fix URL: https://github.com/apache/calcite/pull/954#issuecomment-467511558 I completely missed this - there was another PR for CALCITE-2722 I'll just close this now...

[GitHub] kgyrtkirk closed pull request #954: [CALCITE-2722] - SqlImplementor createLeftCall StackOverflowError fix

2019-02-26 Thread GitBox
kgyrtkirk closed pull request #954: [CALCITE-2722] - SqlImplementor createLeftCall StackOverflowError fix URL: https://github.com/apache/calcite/pull/954 This is an automated message from the Apache Git Service. To respond

error while executing a join query on mongodb

2019-02-26 Thread asma zgolli
Hello, I'm getting the following error while executing a join query. the on clause seems to be the issue : Command failed with error 16410: 'FieldPath field names may not start with '$'.' on server localhost:27017. The full response is { "ok" : 0.0, "errmsg" : "FieldPath field names may not

[GitHub] kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma

2019-02-26 Thread GitBox
kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma URL: https://github.com/apache/calcite/pull/1032#discussion_r257630221 ## File path:

[GitHub] kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma

2019-02-26 Thread GitBox
kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma URL: https://github.com/apache/calcite/pull/1032#discussion_r257633928 ## File path:

[GitHub] kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma

2019-02-26 Thread GitBox
kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma URL: https://github.com/apache/calcite/pull/1032#discussion_r257631585 ## File path:

Re: [DISCUSS] Towards Calcite 1.19.0

2019-02-26 Thread Michael Mior
I've started to review a few myself. Although it doesn't fix the root of the problem, it would be helpful if people who filed PRs that are now stale could close those out. It looks like many older PRs are abandoned and it would be nice to close out any that aren't actively being worked on. They

[GitHub] kgyrtkirk commented on issue #1042: Avoid use of new RuntimeException(e) in tests

2019-02-26 Thread GitBox
kgyrtkirk commented on issue #1042: Avoid use of new RuntimeException(e) in tests URL: https://github.com/apache/calcite/pull/1042#issuecomment-467508536 I thinked this was merged already. @vlsi do you plan to do any more changes?

[GitHub] michaelmior merged pull request #979: [CALCITE-2750] PI operator incorrectly identified as dynamic function

2019-02-26 Thread GitBox
michaelmior merged pull request #979: [CALCITE-2750] PI operator incorrectly identified as dynamic function URL: https://github.com/apache/calcite/pull/979 This is an automated message from the Apache Git Service. To

[GitHub] michaelmior merged pull request #1061: [CALCITE-2786] Add order by clause support for JSON_ARRAYAGG

2019-02-26 Thread GitBox
michaelmior merged pull request #1061: [CALCITE-2786] Add order by clause support for JSON_ARRAYAGG URL: https://github.com/apache/calcite/pull/1061 This is an automated message from the Apache Git Service. To respond to

[GitHub] michaelmior commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-02-26 Thread GitBox
michaelmior commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-467501655 What is the `with wapper` here? This is an automated message from the

[GitHub] michaelmior commented on issue #1067: [CALCITE-2864]Add the JSON_DEPTH function

2019-02-26 Thread GitBox
michaelmior commented on issue #1067: [CALCITE-2864]Add the JSON_DEPTH function URL: https://github.com/apache/calcite/pull/1067#issuecomment-467500637 I noted one minor correction that should be made and if you can also rebase that change and the others into a single commit, this should

[GitHub] michaelmior commented on a change in pull request #1067: [CALCITE-2864]Add the JSON_DEPTH function

2019-02-26 Thread GitBox
michaelmior commented on a change in pull request #1067: [CALCITE-2864]Add the JSON_DEPTH function URL: https://github.com/apache/calcite/pull/1067#discussion_r260360783 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@ -2712,6 +2714,48

Re: Supportin PostgreSQL OID casts

2019-02-26 Thread Michael Mior
There's no direct connection between the parser and the planner, so you'll have to configure the rule sets yourself based on the parser you're using. You could use a second rule, although you might also try avoiding rules altogether and just using RelNode#accept on the root node of your query and

Re: Supportin PostgreSQL OID casts

2019-02-26 Thread Muhammad Gelbana
I believe org.apache.calcite.prepare.CalcitePrepareImpl.createPlanner(Context, Context, RelOptCostFactory) is the correct location to add my rule(s). But since this should only run when the praser is Babel, I tried to find that information from within the mentioned method (*createPlanner*) but I

Re: Supportin PostgreSQL OID casts

2019-02-26 Thread Michael Mior
Writing a rule would certainly work. You would want to match a Filter RelNode and then perhaps use an implementation of RexShuttle on the condition and implement visitCall to check for appropriate casts to be transformed into the subquery you want using RexSubQuery.scalar to generate the new

[jira] [Created] (CALCITE-2876) Add MySQLSqlOperatorTable

2019-02-26 Thread Hongze Zhang (JIRA)
Hongze Zhang created CALCITE-2876: - Summary: Add MySQLSqlOperatorTable Key: CALCITE-2876 URL: https://issues.apache.org/jira/browse/CALCITE-2876 Project: Calcite Issue Type: Improvement

[GitHub] XuQianJin-Stars opened a new pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-02-26 Thread GitBox
XuQianJin-Stars opened a new pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070 ``` JSON_LENGTH(**json_doc**[, *path*]) ``` Returns the length of a JSON document, or, if a *path* argument is given, the length of the

[GitHub] XuQianJin-Stars opened a new pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-02-26 Thread GitBox
XuQianJin-Stars opened a new pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070 ``` JSON_LENGTH(**json_doc**[, *path*]) ``` Returns the length of a JSON document, or, if a *path* argument is given, the length of the

Supportin PostgreSQL OID casts

2019-02-26 Thread Muhammad Gelbana
I'm willing to implement running PostgreSQL queries involving OID casts *For example:* SELECT * FROM pg_attribute WHERE attrelid = 'mytable'::regclass; *Should be executed as:* SELECT * FROM pg_attribute WHERE attrelid = (SELECT oid FROM pg_class WHERE relname = 'mytable'); Note that *reglass*