The Apache Jenkins build system has built Calcite-Master (build #1236)
Status: Still Failing
Check console output at https://builds.apache.org/job/Calcite-Master/1236/ to
view the results.
Julian>I don’t think we should drop Java 8 or 9 support yet.
I support we keep Java 8, and we drop Java 9.
Vladimir
I know some companies that are still on Java 8.
I don’t think we should drop Java 8 or 9 support yet.
Julian
> On Jul 2, 2019, at 4:24 PM, Stamatis Zampetakis wrote:
>
> Good point Vladimir. Given that Java 9 reached already the end of its life
> I think we should remove it from our CI.
>
>
It is difficult to build LICENSE and NOTICE files automatically.
For example, if you have copied some code from a project that has a NOTICE file
you only need to copy the lines of the NOTICE that pertain to the code that you
have copied. If we don’t exercise judgment we will end up creating
Michael>Concatenating licenses
Michael>seems to be an easy fix
Frankly speaking, I have not implemented neither concatenation nor "folder
with licenses".
Both seem to be easy to implement.
Michael>We're nowhere near that for Calcite are we?
Could be.
maven-shade is used for Geode, and mvn
> For instance, in JMeter we have ~1MiB of license texts.
We're nowhere near that for Calcite are we? Concatenating licenses
seems to be an easy fix. That said, if the switch to Gradle makes
another approach equally easy, I don't have a real preference.
--
Michael Mior
mm...@apache.org
Le mer.
Stamatis>it seems that a single LICENCE
Stamatis>file with some separator is very common
I'm not that sure.
For instance, in JMeter we have ~1MiB of license texts.
Having that "with some separator" would probably be more like a torture for
the reader.
Stamatis>Lucene
That is an interesting
Thanks for taking care of this Vladimir.
I have not worked with LICENSE files directly but checking other Apache
projects (e.g., Spark, Lucene, Tomcat, etc.) it seems that a single LICENCE
file with some separator is very common so I would assume is an acceptable
choice.
Best,
Stamatis
On Tue,
godfrey he created CALCITE-3171:
---
Summary: RelOptUtil#pushDownJoinConditions should handle SEMI/ANTI
join specially about project shift mapping
Key: CALCITE-3171
URL:
godfrey he created CALCITE-3170:
---
Summary: join condition of ANTI join can not be pushed down
Key: CALCITE-3170
URL: https://issues.apache.org/jira/browse/CALCITE-3170
Project: Calcite
Issue
Thanks Stamatis! I appreciate all the work you've done. Just a note
for future reference so that I don't forget to mention later: the logo
should be committed to the comdev repo when finalized (see link
below).
https://www.apache.org/logos/about.html
--
Michael Mior
mm...@apache.org
Le mer. 3
11 matches
Mail list logo