Hi Vladimir,
Thanks for bringing this up. In general, I believe annotations for
nullability are beneficial for code readability and reasoning.
However, after reading the PR, I am having the same feelings as Nikolay.
Intuitively, the "@Nullable" annotation does not provide much information,
and
James Starr created CALCITE-4408:
Summary: Oracle substr operator throws an exception when matching
operand exception
Key: CALCITE-4408
URL: https://issues.apache.org/jira/browse/CALCITE-4408
Project:
Regardless of how it got there, the change to
2020-10-06-release-1.26.0.md is currently in the change that you are
proposing to commit (see the top of
https://patch-diff.githubusercontent.com/raw/apache/calcite/pull/2268.patch),
and it shouldn't be.
Julian
On Wed, Nov 18, 2020 at 1:12 PM Vladimir
Julian>Please remove the change you made to
Julian>site/_posts/2020-10-06-release-1.26.0.md in this PR
Julian, I rebase checkerframework branch from time to time, and the commit
you mention was on master branch.
I'm all ears if you have questions or suggestions regarding the checker
framework.
V
I think Haisheng is a great choice for chair, if he is willing.
Thanks for serving as chair this year, Stamatis. You've done a great
job keeping the community civilized and on track.
Julian
On Sat, Nov 14, 2020 at 10:23 PM Forward Xu wrote:
>
> Hi Stamatis,
>
> Thanks for your great work.
>
>
>
Vladimir,
Please remove the change you made to
site/_posts/2020-10-06-release-1.26.0.md in this PR. It is not related
to CALCITE-4199.
Julian
On Wed, Nov 18, 2020 at 9:53 AM Vladimir Sitnikov
wrote:
>
> Here's a recent issue identified by the checker framework. The bug was
> committed in CALCIT
Here's a recent issue identified by the checker framework. The bug was
committed in CALCITE-4251 a couple of hours ago.
https://github.com/apache/calcite/commit/f3c173c9220a83be0dfa0c80a39b015f384ffcd1#diff-639d388c38e469c9329bdf0456d429be21a5031ea6d59188e8abb7e4173e5e4aR699
org/apache/calcite/rel
Nikolay> annotation that doesn’t add any value to the code is a bad thing
It is really sad to hear "doesn't add any value".
Nullability annotations detect bugs, they make coding easier (IDE
understands nullability),
it makes the intention behind method signatures easier to understand.
Nikolay>Jav
Nikolay>Do we have some code style convention that requires it?
Even existing code convention is to explain if parameter can be nullable or
not.
Often it is explained in javadoc or requireNotNull(...) call.
The PR enforces that convention. For instance, it forbids (build would
fail) to return nul
Hello, Vladimir.
I’m looked through your PR and find it questionable.
Every java reference variable can be null.
So, is it really necessary to highlight this fact in the code one more time?
Do we have some code style convention that requires it?
Java is known as a very verbose programming langua
xzh_dz created CALCITE-4407:
---
Summary: Support unparse special syntax when operator is DELETA
Key: CALCITE-4407
URL: https://issues.apache.org/jira/browse/CALCITE-4407
Project: Calcite
Issue Type:
11 matches
Mail list logo
