Re: [DISCUSS] Towards Calcite 1.32.0

2022-09-08 Thread Julian Hyde
Main branch is now closed to commits. There will be an RC0 shortly. It will remain closed until we have a successful RC for release 1.32. Julian (Release manager, Calcite 1.32.) On 2022/09/08 20:31:11 Mark Grey wrote: > Hi, > > Apologies for including this in another feature topic thread, but

[jira] [Created] (CALCITE-5278) Upgrade Janino from 3.1.6 to 3.1.8

2022-09-08 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5278: Summary: Upgrade Janino from 3.1.6 to 3.1.8 Key: CALCITE-5278 URL: https://issues.apache.org/jira/browse/CALCITE-5278 Project: Calcite Issue Type: Bug

Re: [DISCUSS] Towards Calcite 1.32.0

2022-09-08 Thread Mark Grey
Hi, Apologies for including this in another feature topic thread, but might also be a good candidate. Like Aymeric's above also just needs +1 post-rebase. https://github.com/apache/calcite/pull/2683 Best, Mark On Thu, Sep 8, 2022 at 4:12 PM Aymeric Dispa wrote: > Hi, > > I've opened this

Re: [DISCUSS] Towards Calcite 1.32.0

2022-09-08 Thread Aymeric Dispa
Hi, I've opened this PR a few weeks ago and I think it can be released ( https://github.com/apache/calcite/pull/2860 - just waiting for one approval). Would it be possible to include it as part of 1.32.0 ? Thanks, Aymeric On Thu, Sep 8, 2022 at 9:08 PM Ruben Q L wrote: > Thanks for the

Re: [DISCUSS] Towards Calcite 1.32.0

2022-09-08 Thread Ruben Q L
Thanks for the comment, Gavin. It seems there are still some open points in that PR, so it looks like a bit rushed for this one, let's aim for the next release (1.33). We try to keep a rhythm of one release every two months approximately, so in around two months we shall have a new opportunity to

Re: [DISCUSS] Towards Calcite 1.32.0

2022-09-08 Thread Gavin Ray
This may not be the appropriate place to ask, but is there any chance of merging the below for this release, or maybe next release? It's been around a few years and I think it is one of the few blockers in place for taking advantage of MULTISET functionality, much-appreciated if you want to return

Re: [DISCUSS] Towards Calcite 1.32.0

2022-09-08 Thread Julian Hyde
I would like to make a release candidate and start a vote this evening (i.e. 11 hours from now). In three hours I shall close the main branch. If you are a committer and there is a PR that you would like to merge, please either do it in the next three hours or reply to this email asking for

[DISCUSS] Towards Calcite 1.32.0

2022-09-08 Thread Ruben Q L
Hello, It has been more than one month since our last release. It is a good time to keep momentum and try to move on with the next one. On a separate thread, Julian Hyde volunteered to be Release Manager for this one (thanks Julian!). As usual, there are several unresolved tickets [1], let's

Re: How to get lineage for virtual column

2022-09-08 Thread Mark Grey
I had attempted this once before in the case of non-virtual columns, and can only second what Julian mentioned regarding starting from the tests and working backwards through the Validator APIs specifically in a debugger. This does remind me though that I filed this addressing a bug I found while

Re: How to get lineage for virtual column

2022-09-08 Thread Jiajun Xie
My real goal is to know which virtual columns are used in query. - I tried to use `getColumnOrigins`, here is one test in RelMetadataTest ``` @Test void testVirtualColumnOrigins() { final String sql = "select E from VIRTUALCOLUMNS.VC_T1 " + "for system_time as of TIMESTAMP '2011-01-02 00:00:00'";

[jira] [Created] (CALCITE-5277) Make EnumerableRelImplementor stashedParameters order deterministic to increase BINDABLE_CACHE hit rate

2022-09-08 Thread Ruben Q L (Jira)
Ruben Q L created CALCITE-5277: -- Summary: Make EnumerableRelImplementor stashedParameters order deterministic to increase BINDABLE_CACHE hit rate Key: CALCITE-5277 URL:

[jira] [Created] (CALCITE-5276) Implicitly convert strings to geometries

2022-09-08 Thread Bertil Chapuis (Jira)
Bertil Chapuis created CALCITE-5276: --- Summary: Implicitly convert strings to geometries Key: CALCITE-5276 URL: https://issues.apache.org/jira/browse/CALCITE-5276 Project: Calcite Issue

Re: How to get lineage for virtual column

2022-09-08 Thread Julian Hyde
You know, when people ask ‘Does Calcite support lineage?’, I’m never quite sure. People mean different things by lineage, and it takes a bit of effort to set up the required APIs. I think the way to solve this question is with unit tests. Can write a unit test that fails, or point to an