Re: [DISCUSS] Sharing the load of reviewing PRs

2023-04-10 Thread Benchao Li
Thanks Julian for starting the discussion! I'm spending my spare time to contribute to Calcite, usually at weekends, and sometimes in the break of weekdays, hence my time would be limited because the spare time may varies. Review work is not that simple for me because Calcite has many complicated

Re: [DISCUSS] Sharing the load of reviewing PRs

2023-04-10 Thread Charles Givre
I for one would very much like to help with reviews. I don't have a lot of time this month, but next month should have more time. Best, -- C > On Apr 10, 2023, at 10:56 PM, Dan Zou wrote: > > +1, thanks Julian for proposing this. From my observation, there are many > pending PRs in Calcite

[jira] [Created] (CALCITE-5638) Assertion Failure during planning correlated query with orderby

2023-04-10 Thread Mihai Budiu (Jira)
Mihai Budiu created CALCITE-5638: Summary: Assertion Failure during planning correlated query with orderby Key: CALCITE-5638 URL: https://issues.apache.org/jira/browse/CALCITE-5638 Project: Calcite

Re: [DISCUSS] Sharing the load of reviewing PRs

2023-04-10 Thread Dan Zou
+1, thanks Julian for proposing this. From my observation, there are many pending PRs in Calcite and only a few active committers, this puts a lot of pressure on these committers. For example Julian have reviewed 34 PR in 2023 Q1, it is an unimaginable number. I am very supportive of achieving

Re: Draft: board report for 2023 Q1

2023-04-10 Thread LakeShen
+1, Thanks Stamatis.It clearly helps me to understand the latest progress of Calcite community Best, Lake Shen Dan Zou 于2023年4月7日周五 20:43写道: > +1, Thanks Stamatis > Best, > Dan Zou > > > > > > > 2023年4月7日 10:11,Benchao Li 写道: > > > > +1, it's very insightful, thanks Stamatis! > > > > Francis

Re: How to utilize parser hooks such as SqlInsertKeywords

2023-04-10 Thread Julian Hyde
To research this, I would use 'git annotate' and identify the commits and Jira cases that added those particular hooks. On Tue, Apr 4, 2023 at 9:22 AM Jonathan Sternberg wrote: > > Hi, > > We're utilizing Calcite's parser and need to customize it for a certain > dialect. In the past, we've just

[DISCUSS] Sharing the load of reviewing PRs

2023-04-10 Thread Julian Hyde
I don't enjoy reviewing and merging PRs. And every time I do, I feel like a sucker, because there are over a few dozen committers who are enjoying the project and not doing the work. (There is a small group of committers who regularly review and merge PRs. I don't know how they feel about the

Re: Automatically publish Calcite SNAPSHOT artefacts?

2023-04-10 Thread James Turton
Hi Calcite and Drill devs I have a quick follow up on the discussion of running Drill tests against the Calcite main branch. Firstly, as feedback on Stamatis' comments below, the Drill unit test suite is big, diverse, slow, resource hungry and temperamental. By which I mean that it does

Re: Question about the deprecated CachingRelMetadataProvider

2023-04-10 Thread Dan Zou
Hi Stephen, I can provide some information that I have observed, there are two ways to drive metadata in Calcite: code generated based handler and another way with java reflection. And we prefer the former for performance and safety reasons. And the 'CachingRelMetadataProvider' is used for java