Re: Removing FLOAT

2023-10-26 Thread Julian Hyde
Treating FLOAT as sugar for REAL would work. I don’t think we can go as far as making SqlTypeName.FLOAT deprecated, but we can add checks that it is not used. I’ll note that Java-based SQL engines (Spark, Hive) got the TIMESTAMP type wrong because they assumed that it was equivalent to java.sql

Re: Removing FLOAT

2023-10-26 Thread Mihai Budiu
I am only proposing to remove it from the IR. The type would still be accepted by the parser, just represented as DOUBLE. No SQL programs would need to change. Just treat it the same way DECIMAL and NUMERIC are handled; there is only one representation for both. Julian's solution is the first I t

Re: Removing FLOAT

2023-10-26 Thread Julian Hyde
Removing a type that is in the SQL standard is not practical. The best way to deal with the confusion is to state the rules again. If there are a few inconsistencies in the code, fix the inconsistencies. REAL is a 32 bit float (similar to Java float); DOUBLE is a 64 bit float (similar to Java do

Re: Removing FLOAT

2023-10-26 Thread Mihai Budiu
You are in essence asking whether there can be any difference between FLOAT and DOUBLE. If the code generated by Calcite cares, then there can​ be such a difference. However, I believe that Calcite already assumes implicitly that these two types are the same. This means that it is very dangerou

Re: Removing FLOAT

2023-10-26 Thread Paul Jackson
Doesn't having two types help distinguish which type is in the source database for platforms that support both? A call to org.apache.calcite.sql.type.SqlTypeName#getNameForJdbcType would lose that distinction. I don't know offhand whether there are databases that require a CAST when converting

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Mihai Budiu
Thank you for your introduction. I have only gotten started with Calcite, so I hope to be able to do more. Calcite is a relatively weak as a mineral, but we want the software to be rock-solid, since it is really the foundation of many other projects. I have been mostly a researcher, but current

Build failed in Jenkins: Calcite » Calcite-snapshots #658

2023-10-26 Thread Apache Jenkins Server
See Changes: -- [...truncated 393.94 KB...]  13.7sec, org.apache.calcite.test.PigRelOpTest > testRank()  2.4sec

[jira] [Created] (CALCITE-6078) Explicit cast to DECIMAL types do not check for overflow

2023-10-26 Thread Mihai Budiu (Jira)
Mihai Budiu created CALCITE-6078: Summary: Explicit cast to DECIMAL types do not check for overflow Key: CALCITE-6078 URL: https://issues.apache.org/jira/browse/CALCITE-6078 Project: Calcite

Re: [DISCUSS] State of the project 2023

2023-10-26 Thread Ran Tao
Really, totally agree with Mihai & Hongyu about documentation. In fact, I have a similar problem. The learning curve of calcite is indeed steep, most of my learning comes from source code. Fortunately, we still have a relatively rich javadoc in the source code. If there is no javadoc, I mostly r

Removing FLOAT

2023-10-26 Thread Mihai Budiu
Hello, It turns out that there is a lot of confusion in Calcite about what FLOAT is. I have filed an issue about it: https://issues.apache.org/jira/browse/CALCITE-6074 It seems that the intent is for FLOAT to be an exact alias of DOUBLE. If that's the case, we can remove a lot of code and preven

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Julian Hyde
Welcome, Mihai. Thank you for the excellent work that you have already done, and discussions you have started about how we can become better. > On Oct 26, 2023, at 8:33 AM, Tanner Clary > wrote: > > Congrats, Mihai! You've definitely helped me along the way. > > Best, > Tanner > > On Thu,

Re: [DISCUSS] State of the project 2023

2023-10-26 Thread Hongyu Guo
Hi devs, There is no doubt that Calcite boasts powerful capabilities, but the curve of acquiring and learning calcite is quite steep. After studying Calcite for a year, I have only gained a limited understanding of some of its modules. Mihai is about to contribute several documents related to calc

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Tanner Clary
Congrats, Mihai! You've definitely helped me along the way. Best, Tanner On Thu, Oct 26, 2023 at 7:40 AM Runkang He wrote: > Congratulations Mihai! > > Best, > Runkang He > > Zhe Hu 于2023年10月26日周四 21:40写道: > > > Congrats, Mihai ! > > > > > > Best > > ZheHu > > > > > > Replied Message

Re: How to handle a dynamic param as a set of values?

2023-10-26 Thread Benedek Halasi
Hey, Firstly, thank you all for your help! In the meantime, we found this stack overflow thread: [ https://stackoverflow.com/questions/178479/preparedstatement-in-clause-alternatives/10240302#10240302 ] The interesting part is the second example: `SELECT my_column FROM my_table WHERE search_colu

[jira] [Created] (CALCITE-6077) Add FACTORIAL functions (enabled in Hive and Spark library)

2023-10-26 Thread Runkang He (Jira)
Runkang He created CALCITE-6077: --- Summary: Add FACTORIAL functions (enabled in Hive and Spark library) Key: CALCITE-6077 URL: https://issues.apache.org/jira/browse/CALCITE-6077 Project: Calcite

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Runkang He
Congratulations Mihai! Best, Runkang He Zhe Hu 于2023年10月26日周四 21:40写道: > Congrats, Mihai ! > > > Best > ZheHu > > > Replied Message > | From | Bertil Chapuis | > | Date | 10/26/2023 21:09 | > | To | | > | Subject | Re: [ANNOUNCE] New committer: Mihai Budiu | > Congratulations and wel

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Zhe Hu
Congrats, Mihai ! Best ZheHu Replied Message | From | Bertil Chapuis | | Date | 10/26/2023 21:09 | | To | | | Subject | Re: [ANNOUNCE] New committer: Mihai Budiu | Congratulations and welcome! Bertil On 26 Oct 2023, at 10:56, Stamatis Zampetakis wrote: Apache Calcite's Project Ma

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Bertil Chapuis
Congratulations and welcome! Bertil > On 26 Oct 2023, at 10:56, Stamatis Zampetakis wrote: > > Apache Calcite's Project Management Committee (PMC) has invited Mihai > Budiu to become a committer, and we are pleased to announce that he > has accepted. > > Mihai has addressed numerous compile an

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Jiajun Xie
Congratulations Mihai! Well deserved! On Thu, 26 Oct 2023 at 20:08, Ran Tao wrote: > Congratulations, Mihai ! > and thanks for the review in the issue and PR ! > > Best Regards, > Ran Tao > > Stamatis Zampetakis 于2023年10月26日周四 16:57写道: > > > Apache Calcite's Project Management Committee (PMC) h

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Andrei Sereda
Congratulations, Mihai! On Thu, Oct 26, 2023 at 08:08 Ran Tao wrote: > Congratulations, Mihai ! > and thanks for the review in the issue and PR ! > > Best Regards, > Ran Tao > > Stamatis Zampetakis 于2023年10月26日周四 16:57写道: > > > Apache Calcite's Project Management Committee (PMC) has invited Mih

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Ran Tao
Congratulations, Mihai ! and thanks for the review in the issue and PR ! Best Regards, Ran Tao Stamatis Zampetakis 于2023年10月26日周四 16:57写道: > Apache Calcite's Project Management Committee (PMC) has invited Mihai > Budiu to become a committer, and we are pleased to announce that he > has accepted

[jira] [Created] (CALCITE-6076) Table function can not refer other table columns

2023-10-26 Thread hongyu guo (Jira)
hongyu guo created CALCITE-6076: --- Summary: Table function can not refer other table columns Key: CALCITE-6076 URL: https://issues.apache.org/jira/browse/CALCITE-6076 Project: Calcite Issue Type

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Dan Zou
Congratulations, Mihai! Best, Dan Zou > 2023年10月26日 19:19,Sergey Nuyanzin 写道: > > Congratulations

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Hongyu Guo
Congratulations! On Thu, Oct 26, 2023 at 7:20 PM Sergey Nuyanzin wrote: > Congratulations Mihai! > > On Thu, Oct 26, 2023 at 1:15 PM LakeShen > wrote: > > > Congratulations Mihai. > > > > Best, > > LakeShen > > > > Alessandro Solimando 于2023年10月26日周四 > > 17:55写道: > > > > > Congratulations Miha

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Sergey Nuyanzin
Congratulations Mihai! On Thu, Oct 26, 2023 at 1:15 PM LakeShen wrote: > Congratulations Mihai. > > Best, > LakeShen > > Alessandro Solimando 于2023年10月26日周四 > 17:55写道: > > > Congratulations Mihai, very well deserved! > > > > On Thu, 26 Oct 2023 at 11:46, Ruben Q L wrote: > > > > > Congratulati

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread LakeShen
Congratulations Mihai. Best, LakeShen Alessandro Solimando 于2023年10月26日周四 17:55写道: > Congratulations Mihai, very well deserved! > > On Thu, 26 Oct 2023 at 11:46, Ruben Q L wrote: > > > Congratulations! Welcome on board! > > > > > > > > > > On Thu, Oct 26, 2023 at 10:37 AM Benchao Li > wrote:

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Alessandro Solimando
Congratulations Mihai, very well deserved! On Thu, 26 Oct 2023 at 11:46, Ruben Q L wrote: > Congratulations! Welcome on board! > > > > > On Thu, Oct 26, 2023 at 10:37 AM Benchao Li wrote: > > > Congrats, Mihai! Well deserved! > > > > Francis Chuang 于2023年10月26日周四 16:59写道: > > > > > > Congrats,

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Ruben Q L
Congratulations! Welcome on board! On Thu, Oct 26, 2023 at 10:37 AM Benchao Li wrote: > Congrats, Mihai! Well deserved! > > Francis Chuang 于2023年10月26日周四 16:59写道: > > > > Congrats, Mihai! > > > > On 26/10/2023 7:56 pm, Stamatis Zampetakis wrote: > > > Apache Calcite's Project Management Comm

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Benchao Li
Congrats, Mihai! Well deserved! Francis Chuang 于2023年10月26日周四 16:59写道: > > Congrats, Mihai! > > On 26/10/2023 7:56 pm, Stamatis Zampetakis wrote: > > Apache Calcite's Project Management Committee (PMC) has invited Mihai > > Budiu to become a committer, and we are pleased to announce that he > > h

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Francis Chuang
Congrats, Mihai! On 26/10/2023 7:56 pm, Stamatis Zampetakis wrote: Apache Calcite's Project Management Committee (PMC) has invited Mihai Budiu to become a committer, and we are pleased to announce that he has accepted. Mihai has addressed numerous compile and runtime issues in SQL functions and

[ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Stamatis Zampetakis
Apache Calcite's Project Management Committee (PMC) has invited Mihai Budiu to become a committer, and we are pleased to announce that he has accepted. Mihai has addressed numerous compile and runtime issues in SQL functions and has made several significant improvements to the test infrastructure

[jira] [Created] (CALCITE-6075) There is a problem with the git clone address link

2023-10-26 Thread Jira
蔡灿材 created CALCITE-6075: Summary: There is a problem with the git clone address link Key: CALCITE-6075 URL: https://issues.apache.org/jira/browse/CALCITE-6075 Project: Calcite Issue Type: Improvemen