Re: Is there a document that can help understand Calcite's code generation?

2019-08-01 Thread Chunwei Lei
Hi,Muhammad. As far as I know, there is no documents about the process of generation module of Calcite. Please correct me if I am wrong. Best, Chunwei On Thu, Aug 1, 2019 at 9:00 PM Muhammad Gelbana wrote: > Hopefully there is something I can read to help me go through the code > generation

Re: Some issues with release 1.20

2019-08-02 Thread Chunwei Lei
Hi, Amit. Thank you for reporting this. I suggest you opening a jira to track this. Besides, it would be great if you can provide more details to reproduce these issues. Best, Chunwei On Fri, Aug 2, 2019 at 10:22 AM Amit Chavan wrote: > Hello, > > I wanted to see if I can get some help on

Re: Some issues with release 1.20

2019-08-03 Thread Chunwei Lei
, 2019 at 9:17 PM Julian Hyde wrote: > > > > > Do you think you are running into > > > https://issues.apache.org/jira/browse/CALCITE-3145 < > > > https://issues.apache.org/jira/browse/CALCITE-3145>? > > > > > > > On Aug 2, 2019, at 2:00 AM, Ch

Re: [DISCUSS] Towards Calcite 1.21.0

2019-08-26 Thread Chunwei Lei
Thanks for your work, Stamatis. As for 1581, I have reviewed it and it looks good to me. So I am +1 for the change. Best, Chunwei On Mon, Aug 26, 2019 at 1:39 PM Stamatis Zampetakis wrote: > I see that Chunwei has reviewed 1581 and he gave a +1 so I suppose it is > ready to go. > > On Mon,

Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 1)

2019-09-10 Thread Chunwei Lei
+1 (non-binding) Environment: Mac OS X 10.12.6, JDK 1.8.0_201, Maven 3.5.0 - Checked signatures and checksums - OK - Checked release note - OK - Ran unit tests (mvn clean install) - OK Best, Chunwei On Tue, Sep 10, 2019 at 10:14 AM Danny Chan wrote: > +1 Binding > > Environment:

Re: How does Calcite implement `Column Prune`?

2019-09-15 Thread Chunwei Lei
Hi, Ham and Stamatis. In our use case, we use transformation rules like ProjectXXXTransposeRule to do column pruning. For example, if we have a sql: select a from t where b > 10; the logical plan is LogcaiProject(a) LogicalFilter(b>10) LogcicalTableScan(a,b,c) then we ca

Re: [ANNOUNCE] New committer: Julian Feinauer

2019-09-17 Thread Chunwei Lei
Congratulations, Julian! Best, Chunwei On Wed, Sep 18, 2019 at 9:24 AM Danny Chan wrote: > Congratulations, Muhammad ! Welcome to join us ! Thanks for your huge > contribution for the Match Recognize. > > Best, > Danny Chan > 在 2019年9月18日 +0800 AM5:55,Francis Chuang ,写道: > > Apache Calcite's

Re: [ANNOUNCE] New committer: Muhammad Gelbana

2019-09-17 Thread Chunwei Lei
Congratulations , Muhammad! Best, Chunwei On Wed, Sep 18, 2019 at 9:23 AM Danny Chan wrote: > Congratulations, Muhammad ! Welcome to

Re: [DISCUSS] State of the project 2019

2019-10-22 Thread Chunwei Lei
Thank you for your great work, Francis! In the past year, I deeply feel that Calcite community is becoming more and more active, which means that more and more companies start to use Apache Calcite. This is very exciting and encouraging. Thanks to active contributions and committers, pull request

Re: [DISCUSSION] Extension of Metadata Query

2019-10-22 Thread Chunwei Lei
I agree with Danny. We should believe that uses can handle it well. Best, Chunwei On Tue, Oct 22, 2019 at 3:26 PM Danny Chan wrote: > > I don’t trust the typical Calcite user to be able to write a sub-class > that works correctly and efficiently. > > People who sub-class RelMetadataQuery are

Re: Re: [ANNOUNCE] Danny Chan joins Calcite PMC

2019-10-30 Thread Chunwei Lei
Congrats, Danny! Best, Chunwei On Thu, Oct 31, 2019 at 10:19 AM TANG Wen-hui < winifred.wenhui.t...@gmail.com> wrote: > Congratulations ! Danny > > > > winifred.wenhui.t...@gmail.com > > From: Feng Zhu > Date: 2019-10-31 10:17 > To: dev > Subject: Re: [ANNOUNCE] Danny Chan joins Calcite PMC >

Re: [ANNOUNCE] Haisheng Yuan joins Calcite PMC

2019-11-10 Thread Chunwei Lei
Congrats Haisheng! Well deserved! Best, Chunwei On Mon, Nov 11, 2019 at 12:49 PM Xiening Dai wrote: > Congrats Haisheng! Well deserved. > > > On Nov 10, 2019, at 7:45 PM, Francis Chuang > wrote: > > > > I'm pleased to announce that Haisheng has accepted an invitation to > > join the Calcite

Re: [DISCUSS] New Apache Calcite Chair

2019-11-24 Thread Chunwei Lei
Francis, thank you for your great job. I really respect it. I am +1 for Stamatis being the PMC chair. He is such a humble, energetic person. I believe he can bring more excellent ideas about our project. Best, Chunwei On Mon, Nov 25, 2019 at 9:26 AM Danny Chan wrote: > Thanks for the grea

Re: Release managers

2019-12-02 Thread Chunwei Lei
It's great to know that committers can be release manager. I volunteer to be the release manager if there is a chance. BTW, If Julian doesn't mind, I would like to take 1.24 ~~ Best, Chunwei On Tue, Dec 3, 2019 at 5:43 AM Francis Chuang wrote: > Just a quick note regarding the move to Gradle

Re: [DISCUSS] Towards Calcite 1.22

2019-12-02 Thread Chunwei Lei
Thank you for your work, Anderi. Let's get CALCITE-1581[1] into 1.22. +1 for release at early-mid January '20 (to have more time to review prs). [1] https://github.com/apache/calcite/pull/1138 Best, Chunwei On Tue, Dec 3, 2019 at 8:02 AM Andrei Sereda wrote: > Hello, > > Calcite 1.21 was

Re: Release managers

2019-12-06 Thread Chunwei Lei
Many thanks, Julian. +1 for Avatica release-train. Best, Chunwei On Thu, Dec 5, 2019 at 6:06 AM Julian Hyde wrote: > Sure, take 1.24. > > By the way, if people are eager to be release managers, we might need some > for Avatica release-train. > > > > > On Dec 2, 20

Re: [DISCUSS] Tests vs multiline strings

2019-12-15 Thread Chunwei Lei
I agree with Julian. Changing to Kotlin needs lots of error, but gets a little gain. Besides, It costs much more time to write a test if developers are not familiar with Kotlin. I prefer to use Java as it is now. Best, Chunwei On Mon, Dec 16, 2019 at 9:02 AM Julian Hyde wrote: > I don't thin

Re: [DISCUSS] Remove Kotlin

2019-12-16 Thread Chunwei Lei
As far as I can see, introducing Kotlin does not have remarkable benefits. Furthermore, it brings some extra burdens. So I am +1 for removing Kotlin. Best, Chunwei On Tue, Dec 17, 2019 at 8:38 AM Kevin Risden wrote: > Focusing on the technical side of things, I agree that introducing a new >

Re: Re: [ANNOUNCE] New Calcite PMC chair: Stamatis Zampetakis

2019-12-18 Thread Chunwei Lei
Congratulations Stamatis! Best, Chunwei On Thu, Dec 19, 2019 at 9:36 AM Danny Chan wrote: > Congratulations Stamatis! > > Best, > Danny Chan > 在 2019年12月19日 +0800 AM7:37,dev@calcite.apache.org,写道: > > > > Congratulations Stamatis! >

Re: Jira Contributor list

2019-12-19 Thread Chunwei Lei
Hi, Pranay. You should provide your jira id so that someone can add you as a contributor. Best, Chunwei On Fri, Dec 20, 2019 at 2:20 PM Pranay Parmar wrote: > Hi, > > I would like to be added to the JIRA/GitHub contributors list. I have a > pull request raised but not able to assign myself.

Re: Re: [DISCUSS] CALCITE-2450 reorder predicates to a canonical form

2019-12-30 Thread Chunwei Lei
Personally I would prefer to display the expression as what users write. But I agree with Haisheng. Maybe we can add an optimizer config option to enable/disable this feature. Best, Chunwei On Tue, Dec 31, 2019 at 9:50 AM Haisheng Yuan wrote: > Normalizing scalar expressions is helpful, espe

Re: Re: Draft board report for January 2020

2020-01-01 Thread Chunwei Lei
+1, looks good. Thanks, Stamatis~~ Best, Chunwei On Thu, Jan 2, 2020 at 8:41 AM Haisheng Yuan wrote: > +1, looks good to me. > Thanks. > > - Haisheng > > -- > 发件人:Francis Chuang > 日 期:2020年01月02日 04:54:46 > 收件人: > 主 题:Re: Draft b

Re: [discuss] Enhanced MATH Function

2020-01-05 Thread Chunwei Lei
Thanks for proposing this, Forward. IMHO, we can implement functions that are supported by major vendors. As for others, we can implement it when there is a need. Best, Chunwei On Mon, Jan 6, 2020 at 10:38 AM Forward Xu wrote: > Hi everybody, > > > > I'd like to kick off a discussion on Enhan

Re: Contributors of 2019

2020-01-12 Thread Chunwei Lei
Thank you for your effort, Stamatis! Best, Chunwei On Sun, Jan 12, 2020 at 11:36 PM Forward Xu wrote: > Hi Stamatis > > Thank you very much. I will also participate in the review later. > > Best, > Forward > > Forward Xu 于2020年1月12日周日 下午10:59写道: > > > Hi Stamatis > > > > Thank you very mu

Re: [DISCUSS] Towards Calcite 1.22.0

2020-02-20 Thread Chunwei Lei
Thanks, Danny. +1 to Danny’s timetable (RC on 2/24, release by 2/29). Best, Chunwei On Fri, Feb 21, 2020 at 2:37 AM Julian Hyde wrote: > +1 to Danny’s timetable (RC on 2/24, release by 2/29). > > We can have a quick 1.23 (say 1 month after 1.22) if there are important > PRs that we don’t hav

Re: [DISCUSS] Commit messages, again

2020-02-22 Thread Chunwei Lei
Thanks for Julian sharing your point. I totally agree that commit messages should make sense to end-users. But personally, I believe the process/tool more than self-demand. So I think a code review might help(just as Xiening said). The individual doesn't have so much time to figure our every pr tr

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 0)

2020-02-25 Thread Chunwei Lei
Should this vote be canceled since there is release candida 1? Best, Chunwei On Tue, Feb 25, 2020 at 5:08 PM Danny Chan wrote: > Without a plan diff of each case, it’s hard to tell whether the change is > expected or turned to be wrong. > > There are indeed some commits that modify the Calcite

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 1)

2020-02-25 Thread Chunwei Lei
> I have created a build for Apache Calcite 1.22.0, release candidate 0. Should be candidate 1? : ) +1 (non-binding) macOS 10.14.6, jdk 1.8.0_151, maven 3.5.4 * Went over release note OK * Run Calcite tests with the RC OK Best, Chunwei On Tue, Feb 25, 2020 at 5:04 PM Danny Chan wrote: >

Re: [DISCUSS] Code freeze policy during release

2020-02-26 Thread Chunwei Lei
Thanks for pointing out this, Ruben. I also have this question. But in our scrum, we can merge commits to master at the moment we have a release branch. Best, Chunwei On Wed, Feb 26, 2020 at 8:52 PM Ruben Q L wrote: > Hello everyone, > > as you know, we are in the middle of the release proce

Re: [DISCUSS] Code freeze policy during release

2020-02-27 Thread Chunwei Lei
; >>>>> In principle, if there is a commit that should go in it should pass > by > >>>> the > >>>>> release manager and its up to him to decide if he wants to include it > >> or > >>>>> not. > >>>>> Now if I

Re: [ANNOUNCE] New committer: Feng Zhu

2020-02-29 Thread Chunwei Lei
Congratulations! Best, Chunwei On Sat, Feb 29, 2020 at 4:41 PM Danny Chan wrote: > Congratulations! > > Francis Chuang 于2020年2月29日 周六下午4:35写道: > > > Congrats, well-deserved! > > > > On 29/02/2020 6:26 pm, Stamatis Zampetakis wrote: > > > Apache Calcite's Project Management Committee (PMC) has

Re: Quicksql

2020-03-04 Thread Chunwei Lei
Thank you for your introduction, Siyuan. Quicksql is an interesting project and full of potential. I'd like to learn more about it. Best, Chunwei On Tue, Mar 3, 2020 at 3:26 AM Siyuan Liu wrote: > Hi, everyone: > > Glad to see a lot of old friends here. Quicksql is a project born in early >

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

2020-03-04 Thread Chunwei Lei
+1 (non-binding) macOS 10.14.6, jdk 1.8.0_151, maven 3.5.4 * Went over release note OK * Run Calcite tests OK * Checked signatures and checksums OK Best, Chunwei On Wed, Mar 4, 2020 at 2:50 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Stamatis>It is worth mentioning that the

[DISCUSS] Should RexSimplify retain the order of the predicates or not

2020-03-05 Thread Chunwei Lei
Currently, RexSimplify would decompose and compose the AND expression, which particularly puts IS NOT NULL and NOT predicates at the end of the AND expression[1][2]. For instance, `$1 is not null and $2=1` will be changed to `$2=1 and $1 is not null` after being simplified. I know it is not a bug

Re: [DISCUSS] Code reviews

2020-03-15 Thread Chunwei Lei
Thanks for your effort, Stamatis. I totally agree that breaking and other significant changes should be reviewed and receive +1 before committing. Regarding the minimum wait time to commit, I think 72 hours might be too long. Maybe 24-48 hours is enough. Best, Chunwei On Sun, Mar 15, 2020 at

Re: [DISCUSS] Should RexSimplify retain the order of the predicates or not

2020-03-15 Thread Chunwei Lei
t;> > >> [1] https://twitter.com/Teggy/status/1234935448310603777 < > >> https://twitter.com/Teggy/status/1234935448310603777 < > https://twitter.com/Teggy/status/1234935448310603777>> > >> > >> [2] https://www.cs.princeton.edu/~appel/papers/ssafun.pdf &

Re: [DISCUSS] get RexExecutor from RexSimplify in method reduceExpressionsInternal

2020-03-24 Thread Chunwei Lei
IMHO, A disadvantage of supplying a default RexExecutor is that we cannot make sure that the reduced result is the same as the result of the execution engine, especially when there is some customized implementation. Best, Chunwei On Fri, Mar 20, 2020 at 11:16 AM Danny Chan wrote: > This is a

Re: Doubts about TPCH queries with volcano planner

2020-03-26 Thread Chunwei Lei
Calcite is a framework for paring and optimizing the query. The volcano planner is always available if you leverage it correctly. Besides, am I the only person who cannot see the picture? Best, Chunwei On Thu, Mar 26, 2020 at 1:30 PM JiaTao Tao wrote: > Hi all > Currently, I'm studying the v

Re: Draft board report for April 2020

2020-04-01 Thread Chunwei Lei
Nice job, Stamatis! LGTM~ Best, Chunwei On Thu, Apr 2, 2020 at 6:11 AM Francis Chuang wrote: > Looks good to me, Stamatis! One very minor thing is a typo in "pull > requests" in the very last sentence. > > Francis > > On 2/04/2020 9:07 am, Stamatis Zampetakis wrote: > > (~174 open > > pullvr

Re: The Travis CI build failure

2020-04-19 Thread Chunwei Lei
I am a little confused too. Sometimes the traivs ci build of master fails when I merge the pr which passes all tests. Best, Chunwei On Mon, Apr 20, 2020 at 10:33 AM XING JIN wrote: > In PR https://github.com/apache/calcite/pull/1926 and > https://github.com/apache/calcite/pull/1925, The Trav

Re: [discuss] Add the default mode to the path in the Json functions.

2020-04-19 Thread Chunwei Lei
Thank you for proposing this, Forward. I am wondering whether it is really useful for users who want to use these functions since they probably know what the syntax is. But personally I would like to have the default mode since it is more convenient. Best, Chunwei On Sun, Apr 19, 2020 at 9:51

Re: [DISCUSS] Towards Cascades Optimizer

2020-04-21 Thread Chunwei Lei
Haisheng and Xiening, thanks for sharing these wonderful ideas. I believe this will be a huge improvement and definitely benefits all users. >From my experience of upgrading calcite version, there are always some changes in the new version which may lead to unexpected behavior due to a lack of eno

Re: [ANNOUNCE] New committer: Vineet Garg

2020-04-25 Thread Chunwei Lei
Congrats, Vineet! Best, Chunwei On Sun, Apr 26, 2020 at 8:24 AM Haisheng Yuan wrote: > Congrats, Vineet! > > On 2020/04/25 22:18:35, Forward Xu wrote: > > Congratulations > > > > best, > > Forward > > > > Francis Chuang 于2020年4月26日周日 上午6:04写道: > > > > > Congrats, Vineet! > > > > > > On 26/0

Re: [ANNOUNCE] New committer: Jin Xing

2020-04-28 Thread Chunwei Lei
Congrats, Jin! Best, Chunwei On Wed, Apr 29, 2020 at 10:07 AM Forward Xu wrote: > Congrats > > > best, > > Forward > > 953396112 <953396...@qq.com> 于2020年4月29日周三 上午8:21写道: > > > Congrats, Jin Xing! > > > > > > ---Original--- > > From: "Stamatis Zampetakis" > Date: Wed, Apr 29, 2020 05:47 AM >

Re: [ANNOUNCE] New committer: Wang Yanlin

2020-04-28 Thread Chunwei Lei
Congrats, Yanlin! Best, Chunwei On Wed, Apr 29, 2020 at 10:07 AM Forward Xu wrote: > Congrats > > > Best, > > Forward > > 953396112 <953396...@qq.com> 于2020年4月29日周三 上午8:26写道: > > > Congrats, Wang Yanlin! > > > > > > > > > > ---Original--- > > From: "Stamatis Zampetakis" > Date: Wed, Apr 29, 2

Re: [ANNOUNCE] New committer: Forward Xu

2020-04-28 Thread Chunwei Lei
Congrats, Forward! Best, Chunwei On Wed, Apr 29, 2020 at 6:46 AM Rui Wang wrote: > Congrats! > > > -Rui > > On Tue, Apr 28, 2020 at 3:04 PM Francis Chuang > wrote: > > > Congrats, Forward! > > > > Francis > > > > On 29/04/2020 7:53 am, Stamatis Zampetakis wrote: > > > Apache Calcite's Proje

Re: [DISCUSS] Towards Calcite 1.23.0

2020-05-05 Thread Chunwei Lei
Hi, Haisheng, I would like to review the PR for CALCITE-3896. Best, Chunwei On Wed, May 6, 2020 at 4:50 AM Rui Wang wrote: > Thanks for leading 1.23.0 release, Haisheng! > > I will actively contact Danny and Feng to see if we can reach a conclusion > on https://github.com/apache/calcite/pull/

Re: [DISCUSS] Keep 'master' branch closed after 1.23 release until we address the PR backlog

2020-05-12 Thread Chunwei Lei
There're some PRs which have been a long time. I suggest closing some of them if nobody are working on it. But I don't figure out why we should keep the master branch closed. To avoid conflict? Best, Chunwei On Wed, May 13, 2020 at 2:22 AM Julian Hyde wrote: > I noticed that yesterday Haishen

Re: [ANNOUNCE] Apache Calcite 1.23.0 released

2020-05-27 Thread Chunwei Lei
Nice job, Haisheng! Best, Chunwei On Thu, May 28, 2020 at 10:42 AM XING JIN wrote: > Thanks a lot for driving this, Haisheng! > > Best, > Jin > > Stamatis Zampetakis 于2020年5月28日周四 上午7:14写道: > > > Many thanks again Haisheng, the release has your signature on it and it > is > > in many places

Re: Recommendation for matchLimit for HepProgram

2020-06-30 Thread Chunwei Lei
Hi, Maytas. In my system, we set the matchLimit to 1200, which can cover most cases. Best, Chunwei On Tue, Jun 30, 2020 at 4:30 PM Maytas Monsereenusorn wrote: > Hi, > > I am encountering a problem in Calcite that causes my query to result in an > StackOverflow exception. A simple query that

Re: Recommendation for matchLimit for HepProgram

2020-07-01 Thread Chunwei Lei
Druid. > > Best Regards, > Maytas > > On Tue, Jun 30, 2020 at 7:57 PM Chunwei Lei > wrote: > > > Hi, Maytas. > > > > In my system, we set the matchLimit to 1200, which can cover most cases. > > > > Best, > > Chunwei > > > > > &g

Re: Draft board report for July 2020

2020-07-02 Thread Chunwei Lei
Looks great! Thanks Stamatis~~ Best, Chunwei On Fri, Jul 3, 2020 at 9:08 AM Julian Hyde wrote: > Looks good. Thanks! > > I regard the report as for the quarter (April 1st - June 30th), so the > Avatica-go release should rightly go into the Summer report. > > Julian > > > On Jul 2, 2020, at 4:3

Re: Re: [DISCUSS] Refactor how planner rules are parameterized

2020-07-06 Thread Chunwei Lei
If I am right, I am the release manager of 1.24. I suggest releasing 1.24 a bit later(at the end of this month) since 1.23 was released not long ago(on 2020.5.23). Best, Chunwei On Fri, Jul 3, 2020 at 10:54 PM Michael Mior wrote: > I'll just add for the relatively common case where a rule is

[DISCUSS] Towards Calcite 1.24.0

2020-07-08 Thread Chunwei Lei
Hi all, Approximately one and a half months have passed from the previous release (Calcite 1.23.0) and I was thinking that it would be nice to have the next release around the 20 of July, considering there are already ~70 commits and some commits of pull#2024[1] to be merged after 1.24 is large an

Re: [DISCUSS] Towards Calcite 1.24.0

2020-07-09 Thread Chunwei Lei
i, > > > > Thanks for kicking this off. RC on 7/14 sounds good. > > > > I have logged https://issues.apache.org/jira/browse/CALCITE-4117 > > ("Release Calcite 1.24.0") and assigned it to you. I have a couple of > > bugs that I want to make depend on i

Re: [DISCUSS] Towards Calcite 1.24.0

2020-07-14 Thread Chunwei Lei
ed it? [1] https://issues.apache.org/jira/browse/CALCITE-4000 [2] https://issues.apache.org/jira/browse/CALCITE-4118 Best, Chunwei On Fri, Jul 10, 2020 at 2:46 PM Chunwei Lei wrote: > Rui, > > > Question: are you planning to follow the practice of the last release > (i.e. >

Re: [DISCUSS] Towards Calcite 1.24.0

2020-07-16 Thread Chunwei Lei
y only get back to it on > Tuesday or so...which might be too late for the release. So it would be > probably the best if > someone could take it over. > > cheers, > Zoltan > > > On 7/15/20 8:11 AM, Chunwei Lei wrote: > > Thank you for all your effort. > > > >

Re: [DISCUSS] Towards Calcite 1.24.0

2020-07-17 Thread Chunwei Lei
; next one. > > For example, I've been trying to get the InnoDB adapter ( > https://issues.apache.org/jira/browse/CALCITE-4034 ) in shape for > 1.24. But it's taking longer than expected. So, don't hold the release > for me. > > Julian > > On Thu, Jul 16, 20

Re: [DISCUSS] Towards Calcite 1.24.0

2020-07-19 Thread Chunwei Lei
Julian > > > > On Jul 17, 2020, at 12:14 AM, Chunwei Lei > wrote: > > > > Julian, thank you for your kindly reminder. I am about to ask whether I > > should hold the release or not. > > > > I don't want to see that we merge PR in a hurry just for cat

[VOTE] Release apache-calcite-1.24.0 (release candidate 0)

2020-07-20 Thread Chunwei Lei
Hi all, I have created a build for Apache Calcite 1.24.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.24.0-rc0/site/_docs/history.md The commit to be voted upon: https://gitbox

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

2020-07-23 Thread Chunwei Lei
Thanks to everyone who has tested the release candidate and given their comments. I have revised the release notes and updated the LICENSE[1]. Regarding CALCITE-4136[2], I have not looked into it yet. But from what I can see, it is not a blocking issue. [1] https://github.com/chunweilei/calcite

[RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

2020-07-23 Thread Chunwei Lei
Thanks to everyone who has tested the release candidate and given their comments and votes. The tally is as follows. 5 binding +1s: Michael Mior Julian Hyde Haisheng Yuan Francis Chuang Danny Chen 4 non-binding +1s: Enrico Olivelli Ruleben Q L Rui Wang Chunwei Lei 1 binding 0s: Stamatis

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

2020-07-23 Thread Chunwei Lei
may miss? Best, Chunwei On Fri, Jul 24, 2020 at 12:28 AM Chunwei Lei wrote: > Thanks to everyone who has tested the release candidate and given > their comments and votes. > > The tally is as follows. > > 5 binding +1s: > Michael Mior > Julian Hyde > Haisheng Yuan &

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

2020-07-23 Thread Chunwei Lei
wrote: > You need to include your username and password using the -Pasf* flags. > > Here's how I use those flags to publish an avatica release using docker: > https://github.com/apache/calcite-avatica/blob/master/docker.sh#L251 > > Francis > > On 24/07/2020 12:43 pm,

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

2020-07-23 Thread Chunwei Lei
;> [dev/calcite/apache-calcite-1.24.0-rc0] at > >>>> https://dist.apache.org/repos/dist: svn: warning: W160013: URL > >>>> ' > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.24.0-rc0' > >>>> non-existent in revision 406

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

2020-07-23 Thread Chunwei Lei
Thank you very much for your help, Francis and Haisheng. Best, Chunwei On Fri, Jul 24, 2020 at 1:09 PM Chunwei Lei wrote: > > Chunwei, did `prepareVote` fail when you were making rc0? If so, I think > those nexus repos were a byproduct and can be dropped. > > Yes. it indee

Changing JIRAs' status to “Closed”

2020-07-24 Thread Chunwei Lei
Hi, I tried to do a bulk update changing JIRAs' status to “Closed”. But I can not find the button. Is it because I don't have such permission? Appreciate your help! Best, Chunwei

[ANNOUNCE] Apache Calcite 1.24.0 released

2020-07-25 Thread Chunwei Lei
The Apache Calcite team is pleased to announce the release of Apache Calcite 1.24.0. Calcite is a dynamic data management framework. Its cost-based optimizer converts queries, represented in relational algebra, into executable plans. Calcite supports many front-end languages and back-end data engi

Re: Changing JIRAs' status to “Closed”

2020-07-25 Thread Chunwei Lei
5fb1b93%40%3Cdev.calcite.apache.org%3E > > On 2020/07/25 07:55:00, Francis Chuang wrote: > > I've added you to the administrator role. You should be able to do that > now. > > > > Francis > > > > On 25/07/2020 4:45 pm, Chunwei Lei wrote: > > &g

Re: [ANNOUNCE] Apache Calcite 1.24.0 released

2020-07-25 Thread Chunwei Lei
aracter literals as column aliases), 4128 (refactor CSV/file adapters). > > Julian > > > > On Jul 25, 2020, at 9:19 AM, Stamatis Zampetakis > wrote: > > > > Thanks Chunwei for leading this and of course all of our contributors for > > their high quality work.

Master branch is open for commits

2020-07-25 Thread Chunwei Lei
Hi, all. Apache Calcite 1.24.0 has been released, therefor the master is open for commits now. Best, Chunwei

Re: [ANNOUNCE] Apache Calcite 1.24.0 released

2020-07-26 Thread Chunwei Lei
his release! > > > > -Rui > > On Sun, Jul 26, 2020 at 1:48 AM Forward Xu wrote: > > > Thanks! Chunwei! Good job. > > > > The link address of the Presto dialect implementation in > > https://calcite.apache.org/news/2020/07/24/release-1.24.0/ seems to be > > wron

Re: [ANNOUNCE] Apache Calcite 1.24.0 released

2020-07-27 Thread Chunwei Lei
Mon, Jul 27, 2020 at 9:53 AM Chunwei Lei wrote: > > The link address of the Presto dialect implementation seems to be wrong. > > Oops, you're right. I will update it as soon as possible. Thanks for your > kindly reminder, Forward. > > > Best, > Chunwei > > >

Re: [ANNOUNCE] Apache Calcite 1.24.0 released

2020-07-27 Thread Chunwei Lei
Julian, I have sent the email to annou...@apache.org. [image: image.png] But now I found that it failed because I didn't use the apache email address. [image: image.png] I will send it again. Sorry about that. Best, Chunwei On Tue, Jul 28, 2020 at 6:02 AM Julian Hyde wrote: > Chunwei,

Re: [ANNOUNCE] Apache Calcite 1.24.0 released

2020-07-27 Thread Chunwei Lei
I just sent the announcement email to annou...@apache.org using the apache email address. Thanks for your kindly reminder, Julian. P.S. I will add this note to the document. Best, Chunwei On Tue, Jul 28, 2020 at 10:28 AM Chunwei Lei wrote: > Julian, > > I have sent the email

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-12 Thread Chunwei Lei
> Once this release is done, we should consider whether we should give committers write access to SVN to avoid these issues in the future. I am not sure if this is possible or if this is just the way ASF's infra is set up, but it's worth a look. I cannot agree more. Thank you for pointing out, Fra

Re: [DISCUSS] Open SVN dist access to committers

2020-08-13 Thread Chunwei Lei
Awesome! It really helps for the committers as release manager. Best, Chunwei On Fri, Aug 14, 2020 at 6:58 AM Julian Hyde wrote: > Thanks for the clarification, Sebb. We now know, and accept, that the risk > is non-zero. > > > On Aug 13, 2020, at 2:17 PM, sebbaz wrote: > > > > > > > > On 2020

Re: Where to config elasticsearch username/password?

2020-08-30 Thread Chunwei Lei
Hi, I hope the doc[1] helps. [1] https://calcite.apache.org/docs/elasticsearch_adapter.html. Best, Chunwei On Tue, Aug 25, 2020 at 2:08 PM 发给官兵 wrote: > Hi, the dev of calcite: > I asked a question at JIRA. > > > https://issues.apache.org/jira/browse/CALCITE-4180?focusedCommentId=17180256&

Re: [DISCUSS] Sarg (search argument) to generalize and replace IN in RexCall

2020-08-30 Thread Chunwei Lei
Hi, Julian. I would like to review it. Best, Chunwei On Sat, Aug 29, 2020 at 5:19 AM Julian Hyde wrote: > I now have a PR for this change. Can some people review? > > https://github.com/apache/calcite/pull/2124 < > https://github.com/apache/calcite/pull/2124> > > There are legitimate concern

Re: How about add a method for "RelNode" that can get the same string like RelOptUtil.toString

2020-09-03 Thread Chunwei Lei
Tips: we can discuss in JIRA[1]. [1] https://issues.apache.org/jira/browse/CALCITE-4224 Best, Chunwei On Thu, Sep 3, 2020 at 4:49 PM JiaTao Tao wrote: > As a calcite dev, I call this method dozens of times, especially in > debugging, it's not so convenient. > > "RelNode" has an API for its ow

Re: [ANNOUNCE] New committer: Rui Wang

2020-09-09 Thread Chunwei Lei
Congratulations, Rui! Well deserved! Best, Chunwei On Thu, Sep 10, 2020 at 10:28 AM Feng Zhu wrote: > Congrats Rui! > Good Job in Streams, well deserved! > > Best, > Feng > > Stamatis Zampetakis 于2020年9月10日周四 上午5:51写道: > > > Apache Calcite's Project Management Committee (PMC) has invited R

Re: [DISCUSS] Towards Calcite 1.26.0

2020-09-24 Thread Chunwei Lei
Thank you for driving this, Ruben. The schedule looks good to me. Best, Chunwei On Thu, Sep 24, 2020 at 3:26 AM Rui Wang wrote: > Thanks for all your help! Will experiment how it works best for me! > > > -Rui > > On Wed, Sep 23, 2020 at 12:06 PM Ruben Q L wrote: > > > Rui, > > I am not a git

Re: [RESULT] [VOTE] Release apache-calcite-1.26.0 (release candidate 0)

2020-10-12 Thread Chunwei Lei
Thank you for your work, Ruben! Rlease is not easy for the first time. It would be great if every new release manager can make some improvements to the doc. Best, Chunwei On Wed, Oct 7, 2020 at 6:22 PM Ruben Q L wrote: > Thanks Danny. > > It is hard work (especially the first time), but our

Re: TableScan#explainTerms may be not enough for digest

2020-10-12 Thread Chunwei Lei
I agree with Danny. In our system, we also have to override the RelOptTable#getQualifiedName to get more information except for the table name. Best, Chunwei On Sat, Oct 10, 2020 at 10:37 AM JiaTao Tao wrote: > Hi Haishen > See this: > HepPlanner#addRelToGraph > > Pair> key = key(rel)

Re: [DISCUSS] Apache Calcite Online Meetup January 2021

2020-10-15 Thread Chunwei Lei
It would be great! I am glad to attend such a meetup. Best, Chunwei On Fri, Oct 16, 2020 at 12:50 PM Julian Hyde wrote: > Nice idea, Stamatis. I'm happy to give a talk if people want to hear > it - possible topics include geospatial in Calcite, quick intro to > RelBuilder, and lattices/materi

Re: Physical Query Plan Generation

2020-10-18 Thread Chunwei Lei
Hi Shubh, I think some test cases in Calcite would help you a lot. For example, you can refer to TopDownOptTest to see how it works. [1] https://github.com/apache/calcite/blob/master/core/src/test/java/org/apache/calcite/test/TopDownOptTest.java Best, Chunwei On Sun, Oct 18, 2020 at 10:00 PM

Re: JavaCC version being used in Calcite?

2020-10-22 Thread Chunwei Lei
Hi, Rui. I think the javaCC version is 4.0. I used the following command: ./gradlew core:dependencies | grep javacc javaccClaspath \--- net.java.dev.javacc:javacc:4.0 Best, Chunwei On Thu, Oct 22, 2020 at 12:03 PM Rui Wang wrote: > Hi community, > > Where to find the current JavaCC used i

Re: Why ProjectJoinTransposeRule not in Calcite default rule set.

2020-10-26 Thread Chunwei Lei
Note that RelOptUtil#registerDefaultRules is marked as experimental and it excludes quite a few rules. It might not be as perfect as expected. Feel free to improve it if needed. Best, Chunwei On Tue, Oct 27, 2020 at 2:13 AM Rui Wang wrote: > If you include "ProjectJoinTransposeRule" as a defa

Re: [DISCUSS] Make SqlNodeList implement List

2020-11-04 Thread Chunwei Lei
Thank you for raising this, Julian. How much performance improvement can we get? Best, Chunwei On Thu, Nov 5, 2020 at 5:32 AM Julian Hyde wrote: > Currently class SqlNodeList [1] implements Iterable but it > does not implement List. How do people feel about doing that? > (Or Collection?) >

Re: [DISCUSS] State of the project 2020

2020-11-08 Thread Chunwei Lei
Hi Stamatis, Thank you for sharing this detailed information and appreciate your excellent work as our chair. It's an honor to be part of this awesome project. As we can see, we have more and more people who are willing to contribute. But some of them might do not know our convention. So the firs

Re: Status of JIRA tasks labeled "newbie"

2020-11-15 Thread Chunwei Lei
Welcome, Louis. You can take over some tickets that do not have an assignee. Best, Chunwei On Mon, Nov 16, 2020 at 4:22 AM Xiaowei Kuang wrote: > Hi everyone, > > I'm trying to learn more and build up my understanding about > Calcite's system internals by working on small beginner tasks. The

Re: Decouple core from linq4j and Avatica

2020-11-24 Thread Chunwei Lei
I like the idea. But I have the same worry as Haisheng. Best, Chunwei On Wed, Nov 25, 2020 at 3:07 PM Xin Wang wrote: > +1 for this idea. We only use the parser/optimizer part. > > JiaTao Tao 于2020年11月25日周三 下午2:38写道: > > > +1 for this idea, I have been developing Calcite for a long time(coun

Re: [DISCUSS] Does anybody think this is debuging unfriendly: "call.transformTo(relBuilder.build())"

2020-11-24 Thread Chunwei Lei
I have the same feeling. But I am +0 on this change considering: 1) we can not forbid users to write such code. 2) there might be other codes that are not debug-friendly and we can not change them all. Best, Chunwei On Tue, Nov 24, 2020 at 10:59 AM JiaTao Tao wrote: > Hi James > My point is

Re: How to convert a logical operator into multiple physical operators

2020-11-26 Thread Chunwei Lei
Hi, Bhavya. I think all you need to do is to create the node correctly. You can refer to how the EnumerableMergeJoin is created[1]. [1] https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableJoinRule.java#L86 Best, Chunwei On Fri, Nov

Re: TpchTest#testQuery07 timeout when running continuous-integration/appveyor/pr

2020-12-03 Thread Chunwei Lei
Thank you for your effort, Aron. I am wondering if you can file a jira issue and paste your findings. I would like to look into it if I find some time. Best, Chunwei On Thu, Dec 3, 2020 at 1:15 PM JiaTao Tao wrote: > Hi Vladimir > Thanks for your reply: > 1. I run TpchTest#testQuery07 in my M

[HELP] Local build fails

2020-12-04 Thread Chunwei Lei
Hi, all. Currently when I build the Calcite code using the following command: > dev_src/calcite$ ./gradlew build It fails with an exception: > Task :plus:forbiddenApisMain FAILED Build calcite FAILURE reason: Execution failed for task ':plus:forbiddenApisMain': Caused by: de.thetap

Re: [HELP] Local build fails

2020-12-04 Thread Chunwei Lei
My Java version is: java version "1.8.0_151" Java(TM) SE Runtime Environment (build 1.8.0_151-b12) Java HotSpot(TM) 64-Bit Server VM (build 25.151-b12, mixed mode) The exception happened recently. I would try the latest JDK. Thank you very much for your suggestion, Vladimir. Best, Chunwei On

Re: [Bug Report]RelToSqlConverter stack error in 1.24-1.26

2020-12-07 Thread Chunwei Lei
Hi, Tao. Thank you for your report. It would be great if you can file an JIRA and provide a test case that can reproduce the error. Best, Chunwei On Tue, Dec 8, 2020 at 2:33 PM tonytao wrote: > Hi folks, > > I found a RelToSqlConverter bug existed in 1.24-1.26. > > I has a logical plan as bel

Re: [HELP] Local build fails

2020-12-08 Thread Chunwei Lei
I have tried jdk1.8.0_271. But I still get the error. > Task :plus:forbiddenApisMain FAILED > Task :release:distTar Source distribution is created: /Users/chunwei.lcw/Desktop/dev_src/calcite/release/build/distributions/apache-calcite-1.27.0-SNAPSHOT-src.tar.gz Build calcite FAILURE reason: E

Re: [HELP] Local build fails

2020-12-09 Thread Chunwei Lei
Vladimir, Julian, Liya, thank you very much for your help. It works now. Best, Chunwei On Thu, Dec 10, 2020 at 4:12 AM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Fixed. > > Vladimir >

  1   2   3   >