Re: [GITHUB-HELP] The Committer how to merge a PR correctly

2021-12-03 Thread xiong duan
Thank you for your reply. It is very helpful to me about the procedure of how to merge the PR. Actually, I have tested in another git repository before. I want to find a "standard procedure" to guarantee What I do is the right procedure. I believe this email will help the new Committer who is not

Re: [GITHUB-HELP] The Committer how to merge a PR correctly

2021-12-03 Thread Stamatis Zampetakis
Hello, Many guidelines about how to do something, including merging pull requests [1] can be found on the Calcite website. Best, Stamatis [1] https://calcite.apache.org/docs/howto.html#merging-pull-requests On Fri, Dec 3, 2021 at 4:42 AM Jing Zhang wrote: > Hi Xiong, > Congratulations to be

Re: [GITHUB-HELP] The Committer how to merge a PR correctly

2021-12-02 Thread Jing Zhang
Hi Xiong, Congratulations to be a committer of Calcite. I'm not a Calcite committer. However I could share the PR merge workflow which I get from a PMC member of Apache Flink community. Maybe it could help you. 1. get the PR in your local repository --- > git fetch pull//head:

Re: [GITHUB-HELP] The Committer how to merge a PR correctly

2021-12-02 Thread Julian Hyde
Did you search for an answer before posting this question? What did you find? > On Dec 2, 2021, at 5:24 PM, xiong duan wrote: > > Hi, PMC and Committers. As a newcomer, I have one problem want to know. > > Do we have a procedure about The Committer how to merge a PR correctly? > > Every time

[GITHUB-HELP] The Committer how to merge a PR correctly

2021-12-02 Thread xiong duan
Hi, PMC and Committers. As a newcomer, I have one problem want to know. Do we have a procedure about The Committer how to merge a PR correctly? Every time I merge the PR, I always worried whether have a wrong step. So If have the standard procedure, It will be very helpful.