Re: [RESULT] [VOTE] Release Apache Calcite 1.34.0 (release candidate 0)

2023-03-14 Thread Sergey Nuyanzin
Thanks for being release manager, Stamatis! On Tue, Mar 14, 2023 at 1:21 PM Stamatis Zampetakis wrote: > I accidentally put Ruben in non-binding votes; sorry about that. Here is > the corrected version: > > N binding +1s: > Stamatis Zampetakis > Benchao Li > Julian Hyde > Francis Chuang > Ruben

Re: [RESULT] [VOTE] Release Apache Calcite 1.34.0 (release candidate 0)

2023-03-14 Thread Stamatis Zampetakis
I accidentally put Ruben in non-binding votes; sorry about that. Here is the corrected version: N binding +1s: Stamatis Zampetakis Benchao Li Julian Hyde Francis Chuang Ruben Quesada Lopez N non-binding +1s: Sergey Nuyanzin Scott Reynolds On Tue, Mar 14, 2023 at 1:14 PM Stamatis Zampetakis

[RESULT] [VOTE] Release Apache Calcite 1.34.0 (release candidate 0)

2023-03-14 Thread Stamatis Zampetakis
Thanks to everyone who has tested the release candidate and given their comments and votes. Special mention to Sergey, Scott, Ruben, and James for taking the extra burden to test with downstream projects; an incredibly valuable step for quality releases. The tally is as follows. N binding +1s:

Re: [VOTE] Release Apache Calcite 1.34.0 (release candidate 0)

2023-03-14 Thread James Turton
Thanks and understood Stamatis. At some point in the future (not in the context of this RC) it would be nice to bounce around ideas about making syntax optional. I have no idea what mechanism, if any, might support something like "iff application has set FLAG_FOO then include the parsing logic

Re: [VOTE] Release Apache Calcite 1.34.0 (release candidate 0)

2023-03-13 Thread Scott Reynolds
+1 (non-binding) * Downloaded * checked LICENSE, NOTICE, README * compiled and ran tests on MacOS * reviewed release notes * Ran Twilio's internal test suite Twilio's internal test suite is affected by CALCITE-5510 -- Order by using literals in RelToSqlConverter -- but happy to make this

Re: [VOTE] Release Apache Calcite 1.34.0 (release candidate 0)

2023-03-13 Thread Stamatis Zampetakis
Thanks for reporting this James! I was checking the code and preparing a more elaborate reply but just saw that Julian covered many of the things that I wanted to mention under CALCITE-5575. Although the problem surfaced with the addition of the new parsing logic in CALCITE-5469 this is merely

Re: [VOTE] Release Apache Calcite 1.34.0 (release candidate 0)

2023-03-13 Thread James Turton
Hi In the context of this RC, may I ask for comment on CALCITE-5575[1]? I'm not well enough informed to decide if it is actually a Calcite bug (even a regression?) but I have the sense that it could be. I've been working on accommodating Calcite's recently added DATE_DIFF function definition

Re: [VOTE] Release Apache Calcite 1.34.0 (release candidate 0)

2023-03-13 Thread Ruben Q L
Thanks Stamatis for being RM. - Release notes: ok - Checksum and signature: ok - Diff source release and git repository: ok - Build + tests: ok - Calcite-based application test suite: ok +1 (binding) Best regards, Ruben On Sat, Mar 11, 2023 at 9:38 PM Sergey Nuyanzin wrote: > +1

Re: [VOTE] Release Apache Calcite 1.34.0 (release candidate 0)

2023-03-11 Thread Sergey Nuyanzin
+1 (non-binding) * Downloaded * verified signatures and hashes * checked LICENSE, NOTICE, README * compiled and ran tests on Fedora Linux * reviewed release notes * checked that there is no new issues while running against Flink tests On Sat, Mar 11, 2023 at 7:50 AM Francis Chuang wrote:

Re: [VOTE] Release Apache Calcite 1.34.0 (release candidate 0)

2023-03-10 Thread Francis Chuang
Thanks for being RM for this release, Stamatis! My vote is: +1 (binding) - Verified GPG signature - OK - Verified SHA512 - OK - Diffed source release and git repository - OK - Checked release notes on tag (https://github.com/apache/calcite/blob/calcite-1.34.0-rc0/site/_docs/history.md) - OK

Re: [VOTE] Release Apache Calcite 1.34.0 (release candidate 0)

2023-03-10 Thread Julian Hyde
+1 (binding) Steps: * Downloaded; * checked signatures/hashes; * checked LICENSE, NOTICE, README, README.md; * compiled and ran tests on Ubuntu Linux, OpenJDK 18 using 'gradle build'; * also compiled and ran tests with -Pguava.version=16.0.1, the lowest supported Guava version; * checked

Re: [VOTE] Release Apache Calcite 1.34.0 (release candidate 0)

2023-03-10 Thread Benchao Li
+1 (binding) - checked signature and checksum : ok - went through the release note : ok - checked diff between src tar and tag content : ok - checked readme/readme.md/notice/history.md: ok - build and test from source : ok - verified some files in staged repo : ok Stamatis Zampetakis

Re: [VOTE] Release Apache Calcite 1.34.0 (release candidate 0)

2023-03-10 Thread Benchao Li
+1 (binding) - checked signature and checksum : ok - went through the release note : ok - checked diff between src tar and tag content : ok - checked readme/readme.md/notice/history.md: ok - build and test from source : ok - verified some files in staged repo : ok Stamatis Zampetakis

[VOTE] Release Apache Calcite 1.34.0 (release candidate 0)

2023-03-10 Thread Stamatis Zampetakis
Hi all, I have created a build for Apache Calcite 1.34.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.34.0-rc0/site/_docs/history.md The commit to be voted upon: