[VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-17 Thread xiong duan
Hi all, I have created a build for Apache Calcite 1.35.0, release candidate 2. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.35.0-rc2/site/_docs/history.md The commit to be voted upon: https:/

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-17 Thread Stamatis Zampetakis
Ubuntu 20.04.6 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 7.6.1 * Checked signatures and checksums OK * Went over release note OK * Checked README, LICENSE, NOTICE, and licenses directory (in source distribution) OK * Checked diff between git repo and release sources (diff -qr calcite-git calci

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-17 Thread Francis Chuang
Xiong, Your committer key doesn't exist. Visiting https://people.apache.org/keys/committer/xiong.asc returns a 404. Can you check to see if you've added the fingerprint to your LDAP profile? Instructions here: https://infra.apache.org/new-committers-guide.html#set-up-security-and-pgp-keys

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-17 Thread xiong duan
Hi, Francis, I have added my key fingerprints to the LDAP profile, But the URL still not update. I have uploaded my key fingerprints to the public key server. Here is the link[1]. [1] https://keyserver.ubuntu.com/pks/lookup?op=index&fingerprint=on&search=0xEC78877D98B8CDD496133DF2B989C696D102A552

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-17 Thread Jacky Lau
hi xiong: the release note has some problem here, it belongs to spark instead of bigquery Supporting new SQL functions in BigQuery: - [CALCITE-5751 ] Add ARRAY_APPEND, ARRAY_POSITION, ARRAY_REMOVE, ARRAY_PREPEND function (enabled in

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-17 Thread xiong duan
Hi jacky, Yes, I noticed this, Thanks for the review. If no other problem, I will update it when release.

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-17 Thread xiong duan
Hi Francis, Now, The URL https://people.apache.org/keys/committer/xiong.asc is online. xiong duan 于2023年7月18日周二 10:01写道: > Hi jacky, > Yes, I noticed this, Thanks for the review. If no other problem, I will > update it when release. >

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-17 Thread Francis Chuang
Thanks for being RM for this release, Xiong! My vote is: +1 (binding) - Verified GPG signature - OK - Verified SHA512 - OK - Diffed source release and git repository - OK - Checked release notes on tag (https://github.com/apache/calcite/blob/calcite-1.35.0-rc2/site/_docs/history.md) - OK - Ch

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-18 Thread Ruben Q L
Thanks again Xiong Duan for being RM for this release. - Release notes: ok - Checksum: ok - Signature: ok - Diff source release and git repository: ok - Build + tests: ok - Calcite-based application test suite: ok +1 (binding) Best, Ruben On Tue, Jul 18, 2023 at 3:23 AM Francis Chuang wrote:

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-19 Thread Gian Merlino
When testing this with Apache Druid we found a problem: the change in CALCITE-5747 broke a few of our test cases due to this piece: https://github.com/apache/calcite/pull/3245/files#diff-e873041549333502af52ece8a1b34301ae5a059ff4719e9bddbaef48929e7047L7338-L7341 Essentially, FLOOR and CEIL no lo

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-19 Thread Chunwei Lei
Thanks Xiong Duan for being RM for this release. - Checked release notes on tag: some comments > Some improvements in simplify an expression. Some improvements in simplifying an expression. > [CALCITE-5717] RelBuilder.project of literals on a single-row `Aggregate` should create a Values I thin

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-20 Thread Ruben Q L
Thanks Gian for signaling this issue. Since this is a regression introduced in 1.35 (and it looks more or less simple to fix) IMO we should cancel the rc2 vote, fix CALCITE-5865 and move to a rc3. Best, Ruben On Thu, Jul 20, 2023 at 3:29 AM Chunwei Lei wrote: > Thanks Xiong Duan for being RM

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-20 Thread Francis Chuang
+1 as this is a regression. Thanks, Gian, for discovering this. On 20/07/2023 6:36 pm, Ruben Q L wrote: Thanks Gian for signaling this issue. Since this is a regression introduced in 1.35 (and it looks more or less simple to fix) IMO we should cancel the rc2 vote, fix CALCITE-5865 and move to a

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-20 Thread Xiong Duan
Hi, Thanks, everyone, I will close this voting thread because this RC2 testing failed with Apache Druid, and some Release Notes need to improve. Best, Xiong Duan Francis Chuang 于2023年7月20日周四 16:45写道: > +1 as this is a regression. Thanks, Gian, for discovering this. > > On 20/07/2023 6:36

[CANCEL][VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-20 Thread Xiong Duan
Hello Calcite Community, I'm canceling this vote [VOTE] Release Apache Calcite 1.35.0 (release candidate 2) <https://lists.apache.org/thread/zwspmk8zh764fzgf8oq9my48v5g2k1o1> because of some problem. When the bug is fixed and I will start the round 3 vote process. Th

Re: [CANCEL][VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

2023-07-20 Thread Stamatis Zampetakis
Just to clarify that only CALCITE-5865 is a release blocker. All the other things are just minor that can be fixed after the release. On Thu, Jul 20, 2023 at 3:12 PM Xiong Duan wrote: > > Hello Calcite Community, > I'm canceling this vote [VOTE] Release Apache Calcite 1.3